mirror of
https://github.com/dashpay/dash.git
synced 2024-12-28 05:23:01 +01:00
9436caf89a
b9f226b41f rpc: Remove cs_main lock from blockToJSON and blockHeaderToJSON (João Barbosa) 343b98cbcd rpc: Specify chain tip instead of chain in GetDifficulty (João Barbosa) 54dc13b6a2 rpc: Fix SoftForkMajorityDesc and SoftForkDesc signatures (João Barbosa) Pull request description: Motivated by https://github.com/bitcoin/bitcoin/pull/11913#discussion_r157798157, this pull makes `blockToJSON` and `blockheaderToJSON` free of `cs_main` locks. Locking `cs_main` was required to access `chainActive` in order to check if the block was in the chain and to retrieve the next block index. With the this approach, `CBlockIndex::GetAncestor()` is used in a way to check if the block belongs to the specified chain tip and, at the same time, get the next block index. Tree-SHA512: a6720ace0182c19033bbed1a404f729d793574db8ab16e0966ffe412145611e32c30aaab02975d225df6d439d7b9ef2070e732b16137a902b0293c8cddfeb85f
72 lines
1.9 KiB
C++
72 lines
1.9 KiB
C++
#include <boost/test/unit_test.hpp>
|
|
|
|
#include <stdlib.h>
|
|
|
|
#include <rpc/blockchain.h>
|
|
#include <test/test_dash.h>
|
|
|
|
/* Equality between doubles is imprecise. Comparison should be done
|
|
* with a small threshold of tolerance, rather than exact equality.
|
|
*/
|
|
static bool DoubleEquals(double a, double b, double epsilon)
|
|
{
|
|
return std::abs(a - b) < epsilon;
|
|
}
|
|
|
|
static CBlockIndex* CreateBlockIndexWithNbits(uint32_t nbits)
|
|
{
|
|
CBlockIndex* block_index = new CBlockIndex();
|
|
block_index->nHeight = 46367;
|
|
block_index->nTime = 1269211443;
|
|
block_index->nBits = nbits;
|
|
return block_index;
|
|
}
|
|
|
|
static void RejectDifficultyMismatch(double difficulty, double expected_difficulty) {
|
|
BOOST_CHECK_MESSAGE(
|
|
DoubleEquals(difficulty, expected_difficulty, 0.00001),
|
|
"Difficulty was " + std::to_string(difficulty)
|
|
+ " but was expected to be " + std::to_string(expected_difficulty));
|
|
}
|
|
|
|
/* Given a BlockIndex with the provided nbits,
|
|
* verify that the expected difficulty results.
|
|
*/
|
|
static void TestDifficulty(uint32_t nbits, double expected_difficulty)
|
|
{
|
|
CBlockIndex* block_index = CreateBlockIndexWithNbits(nbits);
|
|
double difficulty = GetDifficulty(block_index);
|
|
delete block_index;
|
|
|
|
RejectDifficultyMismatch(difficulty, expected_difficulty);
|
|
}
|
|
|
|
BOOST_FIXTURE_TEST_SUITE(blockchain_tests, BasicTestingSetup)
|
|
|
|
BOOST_AUTO_TEST_CASE(get_difficulty_for_very_low_target)
|
|
{
|
|
TestDifficulty(0x1f111111, 0.000001);
|
|
}
|
|
|
|
BOOST_AUTO_TEST_CASE(get_difficulty_for_low_target)
|
|
{
|
|
TestDifficulty(0x1ef88f6f, 0.000016);
|
|
}
|
|
|
|
BOOST_AUTO_TEST_CASE(get_difficulty_for_mid_target)
|
|
{
|
|
TestDifficulty(0x1df88f6f, 0.004023);
|
|
}
|
|
|
|
BOOST_AUTO_TEST_CASE(get_difficulty_for_high_target)
|
|
{
|
|
TestDifficulty(0x1cf88f6f, 1.029916);
|
|
}
|
|
|
|
BOOST_AUTO_TEST_CASE(get_difficulty_for_very_high_target)
|
|
{
|
|
TestDifficulty(0x12345678, 5913134931067755359633408.0);
|
|
}
|
|
|
|
BOOST_AUTO_TEST_SUITE_END()
|