dash/src/interfaces
Wladimir J. van der Laan 8a03aaa5c0
Merge #17250: Avoid unused call to GuessVerificationProgress in NotifyHeaderTip
fa398091b7ad683dfd3cd3c2cd030eaf9f336737 Avoid unused call to GuessVerificationProgress in NotifyHeaderTip (MarcoFalke)

Pull request description:

  `GuessVerificationProgress` for a header (not a block) is always 0 because the number of txs in the block can not be determined from the header alone. Anyway, this result was never used, so we can optimize this call by hardcoding 0.

  This is the next commit in a series of changes toward removing nChainTx (see #14863, #13875)

ACKs for top commit:
  promag:
    Code review ACK fa398091b7ad683dfd3cd3c2cd030eaf9f336737, missed that.
  laanwj:
    ACK fa398091b7ad683dfd3cd3c2cd030eaf9f336737

Tree-SHA512: 11016f8dbb1af1cf75241948d1ad35eac0c79d1311cd0db8c6ec806df2a9e3dc5f998dbd66ccbad5d84564e6cec7fe21ce7a2a13c2b34c746e2d3b31aa1db53a
2022-04-15 13:08:30 +05:30
..
chain.cpp Merge #18922: gui: Do not translate InitWarning messages in debug.log 2022-04-07 11:28:43 -05:00
chain.h Merge #18922: gui: Do not translate InitWarning messages in debug.log 2022-04-07 11:28:43 -05:00
handler.cpp Merge #13769: Mark single-argument constructors "explicit" 2021-08-03 13:34:34 -03:00
handler.h scripted-diff: Merge #12906: Avoid interface keyword to fix windows gitian build 2020-10-14 12:10:12 +01:00
node.cpp Merge #17250: Avoid unused call to GuessVerificationProgress in NotifyHeaderTip 2022-04-15 13:08:30 +05:30
node.h merge bitcoin#19176: Error message bilingual_str consistency 2022-04-07 11:28:43 -05:00
README.md Merge #15531: Suggested interfaces::Chain cleanups from #15288 2021-11-30 00:01:17 -05:00
wallet.cpp merge bitcoin#18699: Avoid translating RPC errors 2022-04-07 10:13:16 +05:30
wallet.h merge bitcoin#18699: Avoid translating RPC errors 2022-04-07 10:13:16 +05:30

Internal c++ interfaces

The following interfaces are defined here:

  • Chain — used by wallet to access blockchain and mempool state. Added in #14437, #14711, #15288, and #10973.

  • ChainClient — used by node to start & stop Chain clients. Added in #14437.

  • Node — used by GUI to start & stop bitcoin node. Added in #10244.

  • Wallet — used by GUI to access wallets. Added in #10244.

  • Handler — returned by handleEvent methods on interfaces above and used to manage lifetimes of event handlers.

  • Init — used by multiprocess code to access interfaces above on startup. Added in #10102.

The interfaces above define boundaries between major components of bitcoin code (node, wallet, and gui), making it possible for them to run in different processes, and be tested, developed, and understood independently. These interfaces are not currently designed to be stable or to be used externally.