sikkienl/dash
1
0
Fork 0
mirror of https://github.com/dashpay/dash.git synced 2024-12-27 04:52:59 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity
8a84a9b7c0
dash/src
History
MarcoFalke 8a84a9b7c0
Merge #16024: [rpc] deriveaddresses: Correction of descriptor checksum in RPC example 
e23809a05b [rpc] deriveaddresses: Correct descriptor checksum in RPCExamples (Chris Capobianco)

Pull request description:

  Trvial: This fixes the descriptor checksum found the in the deriveaddresses RPC example.

  The current checksum value does work, but only if the "h" used for the hardened derivation key origin are replaced with "'".

  Given the discussion to switch from "'" to "h" [here](https://github.com/bitcoin/bitcoin/issues/15740), I thought it made more sense to update the checksum rather then changing all the "h" to "'" in this example.

ACKs for commit e23809:
  instagibbs:
    tACK e23809a05b

Tree-SHA512: 06a2b9f3e714ecde9b9a80b3b7a4082eb072e71d8abcc455ff5387e470d48839f22a70b78bbae1cf9122cb133fee46830819b6f39d67aec8c3c8d5889ae94e04
2021-12-25 18:32:18 +05:30
..
bench Merge pull request #4619 from PastaPastaPasta/remove-includes 2021-12-17 20:21:12 +03:00
bls util: add ranges.h to emulate c++20 std::ranges (#4622) 2021-12-21 15:05:29 +03:00
coinjoin merge bitcoin#16208: Consume ReserveDestination on successful CreateTransaction 2021-12-22 19:43:18 +05:30
compat merge bitcoin#15146: Solve SmartOS FD_ZERO build issue 2021-12-21 12:25:17 +05:30
config
consensus Merge pull request #4619 from PastaPastaPasta/remove-includes 2021-12-17 20:21:12 +03:00
crc32c Merge #20603: build: Update crc32c subtree 2021-09-24 13:26:41 -04:00
crypto 16659 continuation 2021-12-17 12:02:16 -05:00
evo util: add ranges.h to emulate c++20 std::ranges (#4622) 2021-12-21 15:05:29 +03:00
governance merge bitcoin#16566: refactor upper/lowercase functions 2021-11-01 21:41:35 +05:30
index Merge #16659: refactoring: Remove unused includes 2021-12-12 16:44:54 -05:00
interfaces merge bitcoin#16208: Consume ReserveDestination on successful CreateTransaction 2021-12-22 19:43:18 +05:30
leveldb build: enable experimental Cxx20 support (#4600) 2021-12-12 01:14:17 +03:00
llmq util: add ranges.h to emulate c++20 std::ranges (#4622) 2021-12-21 15:05:29 +03:00
logging Fix more spelling errors 2021-07-19 12:52:03 -05:00
masternode util: add ranges.h to emulate c++20 std::ranges (#4622) 2021-12-21 15:05:29 +03:00
node merge bitcoin#16452: use RelayTransaction in BroadcastTransaction utility 2021-12-22 19:43:18 +05:30
policy merge bitcoin#16257: abort when attempting to fund a transaction above -maxtxfee 2021-12-22 19:43:18 +05:30
primitives Merge #16659: refactoring: Remove unused includes 2021-12-12 16:44:54 -05:00
qt merge bitcoin#16257: abort when attempting to fund a transaction above -maxtxfee 2021-12-22 19:43:18 +05:30
rpc Merge #16024: [rpc] deriveaddresses: Correction of descriptor checksum in RPC example 2021-12-25 18:32:18 +05:30
script merge bitcoin#16542: Return more specific errors about invalid descriptors 2021-12-22 19:43:18 +05:30
secp256k1 Partial merge #22448: Update libsecp256k1 subtree to latest upstream 2021-08-11 00:05:23 +03:00
support Merge bitcoin#23181: refactor: remove references to deprecated values under std::allocator (#4534) 2021-10-23 19:26:55 +03:00
test merge bitcoin#16542: Return more specific errors about invalid descriptors 2021-12-22 19:43:18 +05:30
univalue Merge #20424: build: Update univalue subtree 2021-07-17 12:09:42 -05:00
util merge bitcoin#16257: abort when attempting to fund a transaction above -maxtxfee 2021-12-22 19:43:18 +05:30
wallet Merge #16557: [wallet] restore coinbase and confirmed/conflicted checks in SubmitMemoryPoolAndRelay() (#4633) 2021-12-23 22:09:42 +03:00
zmq 16659 continuation 2021-12-17 12:02:16 -05:00
.clang-format Merge #19454: tools: .clang-format compat with clang versions < 9 2021-07-15 19:30:07 -05:00
addrdb.cpp Merge #21222: log: Clarify log message when file does not exist 2021-09-18 21:41:47 -04:00
addrdb.h Merge #14605: Return of the Banman 2021-07-17 22:32:12 -05:00
addressindex.h
addrman.cpp Merge #13258: uint256: Remove unnecessary crypto/common.h dependency 2021-10-21 17:41:33 +05:30
addrman.h Merge #15109: refactor: Use C++11 default member initializers 2021-08-10 22:20:30 -03:00
amount.h Merge #14244: amount: Move CAmount CENT to unit test header 2021-07-01 16:57:02 -05:00
arith_uint256.cpp Merge #16659: refactoring: Remove unused includes 2021-12-12 16:44:54 -05:00
arith_uint256.h Merge #16659: refactoring: Remove unused includes 2021-12-12 16:44:54 -05:00
attributes.h
banman.cpp Merge pull request #4435 from PastaPastaPasta/backport-trivial-pr20 2021-09-24 23:10:10 +03:00
banman.h Merge #14929: net: Allow connections from misbehavior banned peers 2021-07-19 18:57:23 -05:00
base58.cpp Merge #14585: refactor: remove usage of locale dependent std::isspace 2021-09-09 10:53:54 -07:00
base58.h
batchedlogger.cpp 16659 continuation 2021-12-17 12:02:16 -05:00
batchedlogger.h
bech32.cpp Merge #13249: Make objects in range declarations immutable by default. Avoid unnecessary copying of objects in range declarations. 2021-07-19 17:11:18 -05:00
bech32.h Merge #16792: Assert that the HRP is lowercase in Bech32::Encode 2021-07-12 20:52:56 -05:00
bip39_english.h
bip39.cpp
bip39.h
blockencodings.cpp
blockencodings.h Merge #16659: refactoring: Remove unused includes 2021-12-12 16:44:54 -05:00
blockfilter.cpp Merge #15532: Remove sharp edge (uninit member) when using the compiler-generated ctor for BlockFilter 2021-10-13 23:44:38 -05:00
blockfilter.h Merge #15532: Remove sharp edge (uninit member) when using the compiler-generated ctor for BlockFilter 2021-10-13 23:44:38 -05:00
bloom.cpp 16659 continuation 2021-12-17 12:02:16 -05:00
bloom.h Merge #19968: doc: clarify CRollingBloomFilter size estimate 2021-07-15 19:37:59 -05:00
cachemap.h refactor: replace instances of typedef with using in dash code (#4488) 2021-10-06 00:26:29 +03:00
cachemultimap.h refactor: replace instances of typedef with using in dash code (#4488) 2021-10-06 00:26:29 +03:00
chain.cpp
chain.h Merge #14556: qt: fix confirmed transaction labeled "open" (#13299) 2021-10-13 23:44:02 -05:00
chainparams.cpp Merge pull request #4570 from kittywhiskers/miscports_again_again 2021-12-12 16:00:56 -05:00
chainparams.h refactor: more LLMQ params related refactoring (#4517) 2021-10-15 13:28:19 +03:00
chainparamsbase.cpp merge bitcoin#16097: Add Flags enum to ArgsManager class (#4569) 2021-11-12 19:25:46 -05:00
chainparamsbase.h
chainparamsseeds.h
checkqueue.h Merge #17971: refactor: Remove redundant conditional 2021-09-18 17:15:44 -04:00
clientversion.cpp
clientversion.h
coins.cpp merge bitcoin#16355: move CCoinsViewErrorCatcher out of init.cpp 2021-10-22 08:15:38 +05:30
coins.h merge bitcoin#16355: move CCoinsViewErrorCatcher out of init.cpp 2021-10-22 08:15:38 +05:30
compat.h Merge #14715: Drop defunct prevector compat handling 2021-10-11 17:17:07 -05:00
compressor.cpp Merge #16659: refactoring: Remove unused includes 2021-12-12 16:44:54 -05:00
compressor.h
core_io.h Merge bitcoin#13399: rpc: Add submitheader (#4326) 2021-08-10 22:37:50 +03:00
core_memusage.h
core_read.cpp 16659 continuation 2021-12-17 12:02:16 -05:00
core_write.cpp merge bitcoin#16725: Don't show addresses or P2PK in decoderawtransaction 2021-12-21 12:25:17 +05:30
ctpl_stl.h Fix data races in bls_worker and use ctpl_stl queue. (#4240) 2021-07-11 22:25:27 -05:00
cuckoocache.h Merge #13249: Make objects in range declarations immutable by default. Avoid unnecessary copying of objects in range declarations. 2021-07-19 17:11:18 -05:00
cxxtimer.hpp
dash-cli-res.rc
dash-cli.cpp Merge #16659: refactoring: Remove unused includes 2021-12-12 16:44:54 -05:00
dash-tx-res.rc
dash-tx.cpp Merge #16659: refactoring: Remove unused includes 2021-12-12 16:44:54 -05:00
dash-wallet-res.rc Merge #13926: [Tools] bitcoin-wallet - a tool for creating and managing wallets offline 2021-11-13 11:04:56 -05:00
dash-wallet.cpp Merge #16659: refactoring: Remove unused includes 2021-12-12 16:44:54 -05:00
dashd-res.rc
dashd.cpp Merge #16659: refactoring: Remove unused includes 2021-12-12 16:44:54 -05:00
dbwrapper.cpp Merge #13954: Warn (don't fail!) on spelling errors. Fix typos reported by codespell. 2021-07-19 12:51:24 -05:00
dbwrapper.h Merge #16659: refactoring: Remove unused includes 2021-12-12 16:44:54 -05:00
dsnotificationinterface.cpp refactor: Misc LLMQ refactoring (#4590) 2021-11-29 08:12:09 +03:00
dsnotificationinterface.h
dummywallet.cpp Remove KeePass integration (#4628) 2021-12-22 12:53:11 +03:00
flat-database.h refactor: Include adjustments (#4526) 2021-10-25 16:55:34 +03:00
flatfile.cpp bitcoin#15118: Refactor block file logic 2021-08-12 12:32:29 +05:30
flatfile.h bitcoin#15118: Refactor block file logic 2021-08-12 12:32:29 +05:30
fs.cpp Merge #15782: Avoid redefine warning 2021-09-28 14:46:47 -04:00
fs.h Merge #14768: revert removal of fstream.hpp header in fs.h 2021-08-10 20:24:28 -04:00
hash.cpp
hash.h Merge #13258: uint256: Remove unnecessary crypto/common.h dependency 2021-10-21 17:41:33 +05:30
hdchain.cpp
hdchain.h Hold locks in CHDChain::swap() 2021-07-13 19:43:31 +03:00
httprpc.cpp 16659 continuation 2021-12-17 12:02:16 -05:00
httprpc.h Merge #16659: refactoring: Remove unused includes 2021-12-12 16:44:54 -05:00
httpserver.cpp 16659 continuation 2021-12-17 12:02:16 -05:00
httpserver.h Merge #16659: refactoring: Remove unused includes 2021-12-12 16:44:54 -05:00
indirectmap.h
init.cpp Remove KeePass integration (#4628) 2021-12-22 12:53:11 +03:00
init.h Merge #14437: Refactor: Start to separate wallet from node 2021-10-20 12:29:45 -04:00
key_io.cpp 16659 continuation 2021-12-17 12:02:16 -05:00
key_io.h refactor: Include adjustments (#4526) 2021-10-25 16:55:34 +03:00
key.cpp Merge #19228: Update libsecp256k1 subtree 2021-08-11 00:05:22 +03:00
key.h Merge #12461: scripted-diff: Rename key size consts to be relative to their class 2021-08-11 00:05:22 +03:00
keystore.cpp merge bitcoin#16753: extract PubKey from P2PK script with Solver 2021-12-22 19:43:18 +05:30
keystore.h
limitedmap.h
logging.cpp Remove KeePass integration (#4628) 2021-12-22 12:53:11 +03:00
logging.h Remove KeePass integration (#4628) 2021-12-22 12:53:11 +03:00
Makefile.am Remove KeePass integration (#4628) 2021-12-22 12:53:11 +03:00
Makefile.bench.include merge bitcoin#16299: Move generated data to a dedicated translation unit 2021-12-12 22:36:50 +05:30
Makefile.crc32c.include Merge #20603: build: Update crc32c subtree 2021-09-24 13:26:41 -04:00
Makefile.leveldb.include partial merge #17398: Update leveldb to 1.22+ (#4230) 2021-07-15 15:42:55 -05:00
Makefile.qt.include merge bitcoin#15928: Move QRImageWidget to its own file-pair 2021-12-12 20:32:49 +05:30
Makefile.qttest.include merge bitcoin#15788: Unify testing setups for fuzz, bench, and unit tests 2021-10-25 21:28:37 +05:30
Makefile.test.include test: replace feature_block_reward_reallocation.py with two corresponding unit tests (#4603) 2021-12-11 23:01:20 +03:00
memusage.h
merkleblock.cpp Merge #15139: util: Remove [U](BEGIN|END) macros 2021-08-24 19:14:49 -04:00
merkleblock.h
messagesigner.cpp merge bitcoin#15638: Pull wallet code out of libbitcoin_server (#4560) 2021-11-16 10:19:47 -05:00
messagesigner.h Fix more spelling errors 2021-07-19 12:52:03 -05:00
miner.cpp 16659 continuation 2021-12-17 12:02:16 -05:00
miner.h Merge #19283: refactor: Remove unused BlockAssembler::pblock member var 2021-07-15 19:30:07 -05:00
net_permissions.cpp Merge #16248: Make whitebind/whitelist permissions more flexible 2021-07-19 19:00:04 -05:00
net_permissions.h Merge #16248: Make whitebind/whitelist permissions more flexible 2021-07-19 19:00:04 -05:00
net_processing.cpp merge bitcoin#16452: use RelayTransaction in BroadcastTransaction utility 2021-12-22 19:43:18 +05:30
net_processing.h merge bitcoin#16452: use RelayTransaction in BroadcastTransaction utility 2021-12-22 19:43:18 +05:30
net.cpp Merge #16659: refactoring: Remove unused includes 2021-12-12 16:44:54 -05:00
net.h Merge #16847: doc: add comments clarifying how local services are advertised 2021-11-16 07:13:49 +05:30
netaddress.cpp 16659 continuation 2021-12-17 12:02:16 -05:00
netaddress.h Merge #16659: refactoring: Remove unused includes 2021-12-12 16:44:54 -05:00
netbase.cpp 16659 continuation 2021-12-17 12:02:16 -05:00
netbase.h merge bitcoin#16566: refactor upper/lowercase functions 2021-11-01 21:41:35 +05:30
netfulfilledman.cpp Merge #13235: Break circular dependency: init -> * -> init by extracting shutdown.h 2021-07-02 00:42:18 +03:00
netfulfilledman.h
netmessagemaker.h
noui.cpp 16659 continuation 2021-12-17 12:02:16 -05:00
noui.h merge bitcoin#16277: suppress output in test_bitcoin for expected errors 2021-10-20 12:29:45 -04:00
optional.h Merge #15292: Remove 'boost::optional'-related false positive -Wmaybe-uninitialized warnings on GCC compiler (#4635) 2021-12-22 12:59:27 +03:00
pow.cpp 16659 continuation 2021-12-17 12:02:16 -05:00
pow.h
prevector.h Merge #16659: refactoring: Remove unused includes 2021-12-12 16:44:54 -05:00
protocol.cpp refactor: introduce MAKE_MSG macro for compile time check to ensure the p2p message name is short enough (#4614) 2021-12-12 01:15:00 +03:00
protocol.h Merge #16659: refactoring: Remove unused includes 2021-12-12 16:44:54 -05:00
psbt.cpp Merge #15408: Remove unused TransactionError constants 2021-09-30 16:18:49 -07:00
psbt.h 16659 continuation 2021-12-17 12:02:16 -05:00
pubkey.cpp Merge #12461: scripted-diff: Rename key size consts to be relative to their class 2021-08-11 00:05:22 +03:00
pubkey.h Merge #12461: scripted-diff: Rename key size consts to be relative to their class 2021-08-11 00:05:22 +03:00
random.cpp 16659 continuation 2021-12-17 12:02:16 -05:00
random.h Merge #15250: Use RdSeed when available, and reduce RdRand load 2021-09-16 13:34:59 +03:00
rest.cpp Merge #16659: refactoring: Remove unused includes 2021-12-12 16:44:54 -05:00
reverse_iterator.h
saltedhasher.cpp
saltedhasher.h
scheduler.cpp partial Merge #18234: refactor: Replace boost::mutex,condition_var,chrono with std equivalents in scheduler 2021-09-28 19:42:22 -04:00
scheduler.h partial Merge #19090: refactor: Misc scheduler cleanups 2021-09-28 19:42:27 -04:00
serialize.h refactor: misc spork refactoring (#4620) 2021-12-17 20:22:11 +03:00
shutdown.cpp Merge #13235: Break circular dependency: init -> * -> init by extracting shutdown.h 2021-07-02 00:42:18 +03:00
shutdown.h Merge #13235: Break circular dependency: init -> * -> init by extracting shutdown.h 2021-07-02 00:42:18 +03:00
span.h
spentindex.h
spork.cpp util: add ranges.h to emulate c++20 std::ranges (#4622) 2021-12-21 15:05:29 +03:00
spork.h refactor: misc spork refactoring (#4620) 2021-12-17 20:22:11 +03:00
stacktraces.cpp Merge bitcoin#16205: Refactor: Replace fprintf with tfm::format (#4531) 2021-10-24 13:51:47 +03:00
stacktraces.h
statsd_client.cpp
statsd_client.h
streams.h Merge #16659: refactoring: Remove unused includes 2021-12-12 16:44:54 -05:00
sync.cpp Merge #16659: refactoring: Remove unused includes 2021-12-12 16:44:54 -05:00
sync.h merge bitcoin#19340: Preserve the LockData initial state if "potential deadlock detected" exception thrown 2021-10-12 19:48:19 -04:00
threadinterrupt.cpp
threadinterrupt.h Merge #16659: refactoring: Remove unused includes 2021-12-12 16:44:54 -05:00
threadsafety.h Merge #14437: Refactor: Start to separate wallet from node 2021-10-20 12:29:45 -04:00
timedata.cpp Merge #13249: Make objects in range declarations immutable by default. Avoid unnecessary copying of objects in range declarations. 2021-07-19 17:11:18 -05:00
timedata.h
tinyformat.h Merge bitcoin#16205: Refactor: Replace fprintf with tfm::format (#4531) 2021-10-24 13:51:47 +03:00
torcontrol.cpp Merge #16186: doc/lint: Fix spelling errors identified by codespell 1.15.0 2021-10-05 20:34:00 +03:00
torcontrol.h Merge #16659: refactoring: Remove unused includes 2021-12-12 16:44:54 -05:00
txdb.cpp Merge #17059: util: Simplify path argument for CBlockTreeDB ctor 2021-11-03 12:24:05 -04:00
txdb.h Merge #16659: refactoring: Remove unused includes 2021-12-12 16:44:54 -05:00
txmempool.cpp merge bitcoin#15638: Pull wallet code out of libbitcoin_server (#4560) 2021-11-16 10:19:47 -05:00
txmempool.h Merge #16659: refactoring: Remove unused includes 2021-12-12 16:44:54 -05:00
ui_interface.cpp merge bitcoin#15288: Remove wallet -> node global function calls 2021-11-14 15:32:37 +05:30
ui_interface.h Merge #16659: refactoring: Remove unused includes 2021-12-12 16:44:54 -05:00
uint256.cpp Merge #16659: refactoring: Remove unused includes 2021-12-12 16:44:54 -05:00
uint256.h Merge #16659: refactoring: Remove unused includes 2021-12-12 16:44:54 -05:00
undo.h Merge #18433: serialization: prevent int overflow for big Coin::nHeight 2021-07-13 21:19:48 -05:00
unordered_lru_cache.h Fix error int64_t was not declared (#4419) 2021-09-13 12:56:35 -04:00
validation.cpp merge bitcoin#16854: Prevent UpdateTip log message from being broken up 2021-12-21 12:25:17 +05:30
validation.h Merge pull request #4619 from PastaPastaPasta/remove-includes 2021-12-17 20:21:12 +03:00
validationinterface.cpp Merge pull request #4619 from PastaPastaPasta/remove-includes 2021-12-17 20:21:12 +03:00
validationinterface.h merge bitcoin#15632: Remove ResendWalletTransactions from the Validation Interface 2021-12-12 21:27:51 +05:30
version.h instantsend: deterministic lock using the same msg hash as islock (#4381) 2021-10-05 20:42:34 +03:00
versionbits.cpp Merge #16587: doc: Improve versionbits.h documentation 2021-11-16 07:13:48 +05:30
versionbits.h Merge #16587: doc: Improve versionbits.h documentation 2021-11-16 07:13:48 +05:30
versionbitsinfo.cpp governance: Implement reduced governance fee (#4241) 2021-11-01 18:31:48 +03:00
versionbitsinfo.h merge bitcoin#13311: Don't edit Chainparams after initialization (#4362) 2021-09-03 01:36:11 +03:00
walletinitinterface.h Remove KeePass integration (#4628) 2021-12-22 12:53:11 +03:00
warnings.cpp Merge #19220: refactor: Replace RecursiveMutex with Mutex in warnings.cpp 2021-09-18 21:46:24 -04:00
warnings.h Merge #16659: refactoring: Remove unused includes 2021-12-12 16:44:54 -05:00