mirror of
https://github.com/dashpay/dash.git
synced 2024-12-26 04:22:55 +01:00
65226da849
68faa87881f5334b2528db4adc72ec19d94316a3 test: use f-strings in mining_*.py tests (fanquake) c2a5d560df2824df5731100c2584e8ad7a3d7bc2 test: use f-strings in interface_*.py tests (fanquake) 86d958262dff43002820d58ccb8958e2dbfb9d5b test: use f-strings in feature_proxy.py (fanquake) 31bdb33dcb8345df1bb94b28e811252a918d7dcb test: use f-strings in feature_segwit.py (fanquake) b166d54c3cbb0c028210cee977b3dcde5ac5474f test: use f-strings in feature_versionbits_warning.py (fanquake) cf6d66bf941d946600047d712c7cd15d7605322e test: use f-strings in feature_settings.py (fanquake) 6651d77f22862716f5bd7d0b31cfbd3937ab7b1d test: use f-strings in feature_pruning.py (fanquake) 961f5813ba65b6a601081912c4ece96c2679794d test: use f-strings in feature_notifications.py (fanquake) 1a546e6f6ca95772f0d7dbc2792477becbb8ea63 test: use f-strings in feature_minchainwork.py (fanquake) 6679eceacc915a8ea7cd7063f103ffc5eb9da884 test: use f-strings in feature_logging.py (fanquake) fb633933ab570e945d2a366f37eeff39f516c613 test: use f-strings in feature_loadblock.py (fanquake) e9ca8b254d4b9567831c0e113ce1c0a2b4795a95 test: use f-strings in feature_help.py (fanquake) ff7e3309995a8960ac371741b2b00c6da40f7490 test: use f-strings in feature_filelock.py (fanquake) d5a6adc5e478fa5c6e562377eea873dc38e66578 test: use f-strings in feature_fee_estimation.py (fanquake) a2de33cbdc79202bccddb4beadfde88266ac979f test: use f-strings in feature_dersig.py (fanquake) a2502cc63fd308be8af840962da9c53339433fa6 test: use f-strings in feature_dbcrash.py (fanquake) 3e2f84e7a96cb4b97b609ac853f78edd0ed43f82 test: use f-strings in feature_csv_activation.py (fanquake) e2f1fd8ee92fa421b6d293169044d6ddd5a9b8df test: use f-strings in feature_config_args.py (fanquake) 36d33d32b1b498b61f56d552f6e2c1d064f978c3 test: use f-strings in feature_cltv.py (fanquake) dca173cc044270b30782b1e3355e9dcb8c534295 test: use f-strings in feature_blocksdir.py (fanquake) 5453e8706278918ac51a725e81599cfa18c8cdbc test: use f-strings in feature_backwards_compatibility.py (fanquake) 6f3d5ad67ac8e7b50abae1a2949898d858e38106 test: use f-strings in feature_asmap.py (fanquake) Pull request description: Rather than using 3 different ways to build/format strings (sometimes all in the same test, i.e [`feature_config_args.py`](https://github.com/bitcoin/bitcoin/blob/master/test/functional/feature_config_args.py)), consolidate to using [f-strings (3.6+)](https://docs.python.org/3/reference/lexical_analysis.html#f-strings), which are generally more concise / readable, as well as more performant than existing methods. This deals with the `feature_*.py`, `interface_*.py` and `mining_*.py` tests. See also: [PEP 498](https://www.python.org/dev/peps/pep-0498/) ACKs for top commit: mjdietzx: reACK 68faa87881f5334b2528db4adc72ec19d94316a3 Zero-1729: crACK 68faa87881f5334b2528db4adc72ec19d94316a3 Tree-SHA512: d4e1a42e07d96d2c552387a46da1534223c4ce408703d7568ad2ef580797dd68d9695b8d19666b567af37f44de6e430e8be5db5d5404ba8fcecf9f5b026a6efb
121 lines
5.3 KiB
Python
Executable File
121 lines
5.3 KiB
Python
Executable File
#!/usr/bin/env python3
|
|
# Copyright (c) 2017-2020 The Bitcoin Core developers
|
|
# Distributed under the MIT software license, see the accompanying
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
"""Test logic for setting nMinimumChainWork on command line.
|
|
|
|
Nodes don't consider themselves out of "initial block download" until
|
|
their active chain has more work than nMinimumChainWork.
|
|
|
|
Nodes don't download blocks from a peer unless the peer's best known block
|
|
has more work than nMinimumChainWork.
|
|
|
|
While in initial block download, nodes won't relay blocks to their peers, so
|
|
test that this parameter functions as intended by verifying that block relay
|
|
only succeeds past a given node once its nMinimumChainWork has been exceeded.
|
|
"""
|
|
|
|
import time
|
|
|
|
from test_framework.p2p import P2PInterface, msg_getheaders
|
|
from test_framework.test_framework import BitcoinTestFramework
|
|
from test_framework.util import assert_equal
|
|
|
|
# 2 hashes required per regtest block (with no difficulty adjustment)
|
|
REGTEST_WORK_PER_BLOCK = 2
|
|
|
|
class MinimumChainWorkTest(BitcoinTestFramework):
|
|
def set_test_params(self):
|
|
self.setup_clean_chain = True
|
|
self.num_nodes = 3
|
|
|
|
self.extra_args = [[], ["-minimumchainwork=0x65"], ["-minimumchainwork=0x65"]]
|
|
self.node_min_work = [0, 101, 101]
|
|
|
|
def setup_network(self):
|
|
# Force CanDirectFetch to return false (otherwise nMinimumChainWork is ignored)
|
|
self.bump_mocktime(21 * 2.6 * 60)
|
|
# This test relies on the chain setup being:
|
|
# node0 <- node1 <- node2
|
|
# Before leaving IBD, nodes prefer to download blocks from outbound
|
|
# peers, so ensure that we're mining on an outbound peer and testing
|
|
# block relay to inbound peers.
|
|
self.setup_nodes()
|
|
for i in range(self.num_nodes-1):
|
|
self.connect_nodes(i+1, i)
|
|
|
|
# Set clock of node2 2 days ahead, to keep it in IBD during this test.
|
|
self.nodes[2].setmocktime(int(time.time()) + 48*60*60)
|
|
|
|
def run_test(self):
|
|
# Start building a chain on node0. node2 shouldn't be able to sync until node1's
|
|
# minchainwork is exceeded
|
|
starting_chain_work = REGTEST_WORK_PER_BLOCK # Genesis block's work
|
|
self.log.info(f"Testing relay across node 1 (minChainWork = {self.node_min_work[1]})")
|
|
|
|
starting_blockcount = self.nodes[2].getblockcount()
|
|
|
|
num_blocks_to_generate = int((self.node_min_work[1] - starting_chain_work) / REGTEST_WORK_PER_BLOCK)
|
|
self.log.info(f"Generating {num_blocks_to_generate} blocks on node0")
|
|
hashes = self.generatetoaddress(self.nodes[0], num_blocks_to_generate,
|
|
self.nodes[0].get_deterministic_priv_key().address, sync_fun=self.no_op)
|
|
|
|
self.log.info(f"Node0 current chain work: {self.nodes[0].getblockheader(hashes[-1])['chainwork']}")
|
|
|
|
# Sleep a few seconds and verify that node2 didn't get any new blocks
|
|
# or headers. We sleep, rather than sync_blocks(node0, node1) because
|
|
# it's reasonable either way for node1 to get the blocks, or not get
|
|
# them (since they're below node1's minchainwork).
|
|
time.sleep(3)
|
|
|
|
self.log.info("Verifying node 2 has no more blocks than before")
|
|
self.log.info(f"Blockcounts: {[n.getblockcount() for n in self.nodes]}")
|
|
# Node2 shouldn't have any new headers yet, because node1 should not
|
|
# have relayed anything.
|
|
assert_equal(len(self.nodes[2].getchaintips()), 1)
|
|
assert_equal(self.nodes[2].getchaintips()[0]['height'], 0)
|
|
|
|
assert self.nodes[1].getbestblockhash() != self.nodes[0].getbestblockhash()
|
|
assert_equal(self.nodes[2].getblockcount(), starting_blockcount)
|
|
|
|
self.log.info("Check that getheaders requests to node2 are ignored")
|
|
peer = self.nodes[2].add_p2p_connection(P2PInterface())
|
|
msg = msg_getheaders()
|
|
msg.locator.vHave = [int(self.nodes[2].getbestblockhash(), 16)]
|
|
msg.hashstop = 0
|
|
peer.send_and_ping(msg)
|
|
time.sleep(5)
|
|
assert ("headers" not in peer.last_message or len(peer.last_message["headers"].headers) == 0)
|
|
|
|
self.log.info("Generating one more block")
|
|
self.generate(self.nodes[0], 1)
|
|
|
|
self.log.info("Verifying nodes are all synced")
|
|
|
|
# Because nodes in regtest are all manual connections (eg using
|
|
# addnode), node1 should not have disconnected node0. If not for that,
|
|
# we'd expect node1 to have disconnected node0 for serving an
|
|
# insufficient work chain, in which case we'd need to reconnect them to
|
|
# continue the test.
|
|
|
|
self.log.info(f"Blockcounts: {[n.getblockcount() for n in self.nodes]}")
|
|
|
|
self.log.info("Test that getheaders requests to node2 are not ignored")
|
|
peer.send_and_ping(msg)
|
|
assert "headers" in peer.last_message
|
|
|
|
# Verify that node2 is in fact still in IBD (otherwise this test may
|
|
# not be exercising the logic we want!)
|
|
assert_equal(self.nodes[2].getblockchaininfo()['initialblockdownload'], True)
|
|
|
|
self.log.info("Test -minimumchainwork with a non-hex value")
|
|
self.stop_node(0)
|
|
self.nodes[0].assert_start_raises_init_error(
|
|
["-minimumchainwork=test"],
|
|
expected_msg='Error: Invalid non-hex (test) minimum chain work value specified',
|
|
)
|
|
|
|
|
|
if __name__ == '__main__':
|
|
MinimumChainWorkTest().main()
|