sikkienl/dash
1
0
Fork 0
mirror of https://github.com/dashpay/dash.git synced 2024-12-25 12:02:48 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity
8eda85a451
dash/src
History
PastaPastaPasta 8eda85a451
refactor: make all ToJson functions return a UniValue instead of return by reference; add nodiscard (#5592) 
## Issue being fixed or feature implemented
Return by reference is generally not ideal, and especially as there is
only one return path per function, all returns will be done via NRVO.
Additionally, call sites are simpler now.

## What was done?
Refactored to return by value


## How Has This Been Tested?
Building

## Breaking Changes
Should be none

## Checklist:
_Go over all the following points, and put an `x` in all the boxes that
apply._
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have added or updated relevant unit/integration/functional/e2e
tests
- [ ] I have made corresponding changes to the documentation
- [x] I have assigned this pull request to a milestone _(for repository
code-owners and collaborators only)_
2023-09-29 12:56:52 -05:00
..
bench merge bitcoin#20464: Treat CDataStream bytes as uint8_t 2023-09-24 09:50:50 -05:00
bls feat: mnlistdiff v20 CL sig quorums (#5377) 2023-07-10 11:23:09 -05:00
coinjoin refactor: decouple db hooks from CFlatDB-based C*Manager objects, migrate to *Store structs (#5555) 2023-09-24 09:50:21 -05:00
compat merge bitcoin#19020: Use C++11 member initialization in protocol 2023-09-24 09:50:50 -05:00
config
consensus fix: add missing includes and remove obsolete includes (#5562) 2023-09-07 09:07:02 -05:00
crc32c
crypto merge bitcoin#19521: Coinstats Index 2023-08-02 10:19:02 -05:00
dashbls build: stop tracking cmake dependency relic_conf.h.in 2023-06-28 23:44:03 +03:00
evo refactor: make all ToJson functions return a UniValue instead of return by reference; add nodiscard (#5592) 2023-09-29 12:56:52 -05:00
governance refactor: decouple db hooks from CFlatDB-based C*Manager objects, migrate to *Store structs (#5555) 2023-09-24 09:50:21 -05:00
immer build: fix gitian builds 2023-01-03 14:51:16 +03:00
index fix: add missing includes and remove obsolete includes (#5562) 2023-09-07 09:07:02 -05:00
interfaces refactor: subsume CoinJoin objects under CJContext, deglobalize coinJoin{ClientQueueManager,Server} (#5337) 2023-09-13 12:52:38 -05:00
leveldb
llmq refactor: make all ToJson functions return a UniValue instead of return by reference; add nodiscard (#5592) 2023-09-29 12:56:52 -05:00
logging Merge #18673: scripted-diff: Sort test includes 2023-08-29 22:00:59 -05:00
masternode refactor: decouple db hooks from CFlatDB-based C*Manager objects, migrate to *Store structs (#5555) 2023-09-24 09:50:21 -05:00
node refactor: subsume CoinJoin objects under CJContext, deglobalize coinJoin{ClientQueueManager,Server} (#5337) 2023-09-13 12:52:38 -05:00
policy Merge #20497: [Refactor] Add MAX_STANDARD_SCRIPTSIG_SIZE to policy 2023-07-26 09:37:53 +05:30
primitives Merge #18673: scripted-diff: Sort test includes 2023-08-29 22:00:59 -05:00
qt refactor: make all ToJson functions return a UniValue instead of return by reference; add nodiscard (#5592) 2023-09-29 12:56:52 -05:00
rpc refactor: make all ToJson functions return a UniValue instead of return by reference; add nodiscard (#5592) 2023-09-29 12:56:52 -05:00
script merge bitcoin#23413: Replace MakeSpan helper with Span deduction guide 2023-09-24 09:50:50 -05:00
secp256k1
support merge bitcoin#20464: Treat CDataStream bytes as uint8_t 2023-09-24 09:50:50 -05:00
test merge bitcoin#23413: Replace MakeSpan helper with Span deduction guide 2023-09-24 09:50:50 -05:00
univalue
util merge bitcoin#23451: Add std::byte helpers 2023-09-24 09:50:50 -05:00
wallet merge bitcoin#23413: Replace MakeSpan helper with Span deduction guide 2023-09-24 09:50:50 -05:00
zmq Merge #18673: scripted-diff: Sort test includes 2023-08-29 22:00:59 -05:00
.clang-format
addrdb.cpp merge bitcoin#22570: Ignore banlist.dat 2023-09-24 09:50:50 -05:00
addrdb.h merge bitcoin#22570: Ignore banlist.dat 2023-09-24 09:50:50 -05:00
addressindex.cpp refactor: consolidate P2PK{H} types to P2PK_OR_P2PKH 2023-09-25 22:57:42 +05:30
addressindex.h refactor: consolidate P2PK{H} types to P2PK_OR_P2PKH 2023-09-25 22:57:42 +05:30
addrman.cpp Merge #18673: scripted-diff: Sort test includes 2023-08-29 22:00:59 -05:00
addrman.h Merge bitcoin/bitcoin#19238: refactor: Make CAddrMan::cs non-recursive 2023-08-28 11:24:41 -05:00
amount.h
arith_uint256.cpp
arith_uint256.h
attributes.h
banman.cpp merge bitcoin#22570: Ignore banlist.dat 2023-09-24 09:50:50 -05:00
banman.h merge bitcoin#22570: Ignore banlist.dat 2023-09-24 09:50:50 -05:00
base58.cpp merge bitcoin#23413: Replace MakeSpan helper with Span deduction guide 2023-09-24 09:50:50 -05:00
base58.h Merge #19706: refactor: make EncodeBase58{Check} consume Spans 2023-04-19 01:12:28 +03:00
batchedlogger.cpp chore: run copyright_header.py update 2023-01-13 00:49:04 +03:00
batchedlogger.h chore: run copyright_header.py update 2023-01-13 00:49:04 +03:00
bech32.cpp
bech32.h
bip39_english.h
bip39.cpp feat(wallet): make mnemonic bits tweakable, default to 128 bit / 12 words (#5457) 2023-06-28 19:01:24 +03:00
bip39.h fix(wallet): truncate mnemonic passphrase instead of crashing 2023-06-12 10:56:10 +03:00
bitcoin-cli.cpp Merge #18673: scripted-diff: Sort test includes 2023-08-29 22:00:59 -05:00
bitcoin-tx.cpp fix: add missing includes and remove obsolete includes (#5562) 2023-09-07 09:07:02 -05:00
bitcoin-wallet.cpp Merge #18673: scripted-diff: Sort test includes 2023-08-29 22:00:59 -05:00
bitcoind.cpp fix: add missing includes and remove obsolete includes (#5562) 2023-09-07 09:07:02 -05:00
blockencodings.cpp Merge #15921: validation: Tidy up ValidationState interface 2023-04-17 10:42:25 -05:00
blockencodings.h Merge #18673: scripted-diff: Sort test includes 2023-08-29 22:00:59 -05:00
blockfilter.cpp merge bitcoin#23994: Consolidate all uses of the fast range mapping technique in util/fastrange.h 2023-09-04 20:50:27 -05:00
blockfilter.h
bloom.cpp merge bitcoin#23115: use Span instead of std::vector for insert and contains 2023-09-24 09:50:50 -05:00
bloom.h merge bitcoin#23115: use Span instead of std::vector for insert and contains 2023-09-24 09:50:50 -05:00
cachemap.h chore: run copyright_header.py update 2023-01-13 00:49:04 +03:00
cachemultimap.h chore: run copyright_header.py update 2023-01-13 00:49:04 +03:00
chain.cpp
chain.h Merge #18673: scripted-diff: Sort test includes 2023-08-29 22:00:59 -05:00
chainparams.cpp partial bitcoin#21560: Add Tor v3 hardcoded seeds 2023-09-24 09:50:50 -05:00
chainparams.h partial bitcoin#21560: Add Tor v3 hardcoded seeds 2023-09-24 09:50:50 -05:00
chainparamsbase.cpp Merge #16680: Preparations for more testchains 2023-04-25 23:41:20 -05:00
chainparamsbase.h merge bitcoin#19991: Use alternative port for incoming Tor connections 2023-04-17 08:30:49 +00:00
chainparamsseeds.h partial bitcoin#21560: Add Tor v3 hardcoded seeds 2023-09-24 09:50:50 -05:00
checkqueue.h Merge #18673: scripted-diff: Sort test includes 2023-08-29 22:00:59 -05:00
clientversion.cpp
clientversion.h merge bitcoin#21059: Drop boost/preprocessor dependencies 2023-09-04 20:50:27 -05:00
coins.cpp merge bitcoin#19935: Move SaltedHashers to separate file and add some new ones 2023-09-04 20:50:27 -05:00
coins.h merge bitcoin#19935: Move SaltedHashers to separate file and add some new ones 2023-09-04 20:50:27 -05:00
compat.h Merge #20221: net: compat.h related cleanup 2023-08-01 12:24:36 -05:00
compressor.cpp Merge bitcoin/bitcoin#18847: compressor: use a prevector in CompressScript serialization [ZAP1] 2023-04-14 23:34:13 -05:00
compressor.h merge bitcoin#23413: Replace MakeSpan helper with Span deduction guide 2023-09-24 09:50:50 -05:00
context.h trivial: consistently use context as the argument name for CoreContext 2023-07-28 00:18:27 -05:00
core_io.h
core_memusage.h
core_read.cpp Merge #18673: scripted-diff: Sort test includes 2023-08-29 22:00:59 -05:00
core_write.cpp refactor: make all ToJson functions return a UniValue instead of return by reference; add nodiscard (#5592) 2023-09-29 12:56:52 -05:00
ctpl_stl.h
cuckoocache.h merge bitcoin#23994: Consolidate all uses of the fast range mapping technique in util/fastrange.h 2023-09-04 20:50:27 -05:00
cxxtimer.hpp
dash-cli-res.rc
dash-tx-res.rc
dash-wallet-res.rc
dashd-res.rc
dbwrapper.cpp fix: add missing includes and remove obsolete includes (#5562) 2023-09-07 09:07:02 -05:00
dbwrapper.h merge bitcoin#20464: Treat CDataStream bytes as uint8_t 2023-09-24 09:50:50 -05:00
dsnotificationinterface.cpp refactor: subsume CoinJoin objects under CJContext, deglobalize coinJoin{ClientQueueManager,Server} (#5337) 2023-09-13 12:52:38 -05:00
dsnotificationinterface.h refactor: subsume CoinJoin objects under CJContext, deglobalize coinJoin{ClientQueueManager,Server} (#5337) 2023-09-13 12:52:38 -05:00
dummywallet.cpp refactor: subsume CoinJoin objects under CJContext, deglobalize coinJoin{ClientQueueManager,Server} (#5337) 2023-09-13 12:52:38 -05:00
flat-database.h merge bitcoin#19326: Simplify hash.h interface using Spans 2023-09-24 09:50:50 -05:00
flatfile.cpp Merge #14501: Fix possible data race when committing block files 2023-08-29 21:40:46 -05:00
flatfile.h Merge #18673: scripted-diff: Sort test includes 2023-08-29 22:00:59 -05:00
fs.cpp Merge #19299: refactor: Remove unused vars, Add missing includes 2023-01-22 00:27:52 -06:00
fs.h
hash.cpp merge bitcoin#23115: use Span instead of std::vector for insert and contains 2023-09-24 09:50:50 -05:00
hash.h merge bitcoin#19326: Simplify hash.h interface using Spans 2023-09-24 09:50:50 -05:00
hdchain.cpp merge bitcoin#23409: Take Span in SetSeed 2023-09-24 09:50:50 -05:00
hdchain.h feat(wallet): make mnemonic bits tweakable, default to 128 bit / 12 words (#5457) 2023-06-28 19:01:24 +03:00
httprpc.cpp Merge #18673: scripted-diff: Sort test includes 2023-08-29 22:00:59 -05:00
httprpc.h
httpserver.cpp Merge #18673: scripted-diff: Sort test includes 2023-08-29 22:00:59 -05:00
httpserver.h Merge #18673: scripted-diff: Sort test includes 2023-08-29 22:00:59 -05:00
i2p.cpp merge bitcoin#22112: Force port 0 in I2P 2023-07-24 20:45:49 +03:00
i2p.h merge bitcoin#21387: Refactor sock to add I2P fuzz and unit tests 2023-07-24 20:45:49 +03:00
indirectmap.h Merge #18673: scripted-diff: Sort test includes 2023-08-29 22:00:59 -05:00
init.cpp merge bitcoin#20966: save the banlist in a JSON format on disk 2023-09-24 09:50:50 -05:00
init.h Merge #18673: scripted-diff: Sort test includes 2023-08-29 22:00:59 -05:00
key_io.cpp Merge #15452: Replace CScriptID and CKeyID in CTxDestination with dedicated types 2023-02-10 23:34:57 +03:00
key_io.h
key.cpp merge bitcoin#23409: Take Span in SetSeed 2023-09-24 09:50:50 -05:00
key.h merge bitcoin#23409: Take Span in SetSeed 2023-09-24 09:50:50 -05:00
limitedmap.h chore: Drop unused unordered_limitedmap::insert_or_update() 2023-07-17 01:00:48 +03:00
logging.cpp fix: debug rpc should return a list of active debug categories, not all of them (#5585) 2023-09-28 07:47:45 -05:00
logging.h fix: debug rpc should return a list of active debug categories, not all of them (#5585) 2023-09-28 07:47:45 -05:00
Makefile.am refactor: remove more code duplication from (dis)connect operations 2023-09-25 20:28:56 +05:30
Makefile.bench.include Merge #18397: build: Fix libevent linking for bench_bitcoin binary 2023-05-31 12:01:04 -05:00
Makefile.crc32c.include
Makefile.leveldb.include
Makefile.qt_locale.include
Makefile.qt.include merge bitcoin#17513: Nuke some circular dependencies 2023-04-15 12:12:30 -05:00
Makefile.qttest.include partial bitcoin#19077: Add sqlite as an alternative wallet database and use it for new descriptor wallets 2023-02-07 10:53:33 -06:00
Makefile.test_fuzz.include merge bitcoin#20995: Avoid initializing version to less than MIN_PEER_PROTO_VERSION 2023-07-24 20:45:49 +03:00
Makefile.test_util.include merge bitcoin#27988: Use same timeout for all index sync 2023-08-02 10:19:02 -05:00
Makefile.test.include merge bitcoin#19055: Add MuHash3072 implementation 2023-08-29 21:55:45 -05:00
Makefile.univalue.include
mapport.cpp merge bitcoin#19064: Cleanup thread ctor calls 2023-09-04 20:50:27 -05:00
mapport.h
memusage.h Merge #18673: scripted-diff: Sort test includes 2023-08-29 22:00:59 -05:00
merkleblock.cpp merge bitcoin#19326: Simplify hash.h interface using Spans 2023-09-24 09:50:50 -05:00
merkleblock.h
messagesigner.cpp chore: run copyright_header.py update 2023-01-13 00:49:04 +03:00
messagesigner.h chore: run copyright_header.py update 2023-01-13 00:49:04 +03:00
miner.cpp refactor: rid-of magic constant by introducing MasternodePayments::PlatformShare 2023-09-05 11:25:28 -05:00
miner.h Merge #18673: scripted-diff: Sort test includes 2023-08-29 22:00:59 -05:00
net_permissions.cpp merge bitcoin#18991: Cache responses to GETADDR to prevent topology leaks 2023-06-05 10:11:03 -05:00
net_permissions.h Merge #18673: scripted-diff: Sort test includes 2023-08-29 22:00:59 -05:00
net_processing.cpp refactor: decouple db hooks from CFlatDB-based C*Manager objects, migrate to *Store structs (#5555) 2023-09-24 09:50:21 -05:00
net_processing.h refactor: subsume CoinJoin objects under CJContext, deglobalize coinJoin{ClientQueueManager,Server} (#5337) 2023-09-13 12:52:38 -05:00
net_types.h
net.cpp merge bitcoin#23413: Replace MakeSpan helper with Span deduction guide 2023-09-24 09:50:50 -05:00
net.h partial bitcoin#17428: Try to preserve outbound block-relay-only connections during restart 2023-09-24 09:50:50 -05:00
netaddress.cpp merge bitcoin#23413: Replace MakeSpan helper with Span deduction guide 2023-09-24 09:50:50 -05:00
netaddress.h merge bitcoin#23413: Replace MakeSpan helper with Span deduction guide 2023-09-24 09:50:50 -05:00
netbase.cpp merge bitcoin#21387: Refactor sock to add I2P fuzz and unit tests 2023-07-24 20:45:49 +03:00
netbase.h merge bitcoin#21387: Refactor sock to add I2P fuzz and unit tests 2023-07-24 20:45:49 +03:00
netfulfilledman.cpp refactor: decouple db hooks from CFlatDB-based C*Manager objects, migrate to *Store structs (#5555) 2023-09-24 09:50:21 -05:00
netfulfilledman.h refactor: decouple db hooks from CFlatDB-based C*Manager objects, migrate to *Store structs (#5555) 2023-09-24 09:50:21 -05:00
netmessagemaker.h
noui.cpp
noui.h
outputtype.cpp Merge #18673: scripted-diff: Sort test includes 2023-08-29 22:00:59 -05:00
outputtype.h Merge #18034: Get the OutputType for a descriptor 2023-05-24 12:43:57 -05:00
pow.cpp fix: respect fPowNoRetargeting for post-btc algos 2023-06-12 10:56:10 +03:00
pow.h
prevector.h Merge #18673: scripted-diff: Sort test includes 2023-08-29 22:00:59 -05:00
protocol.cpp merge bitcoin#19020: Use C++11 member initialization in protocol 2023-09-24 09:50:50 -05:00
protocol.h merge bitcoin#20516: Well-defined CAddress disk serialization, and addrv2 anchors.dat 2023-09-24 09:50:50 -05:00
psbt.cpp merge bitcoin#20464: Treat CDataStream bytes as uint8_t 2023-09-24 09:50:50 -05:00
psbt.h merge bitcoin#23413: Replace MakeSpan helper with Span deduction guide 2023-09-24 09:50:50 -05:00
pubkey.cpp
pubkey.h merge bitcoin#23413: Replace MakeSpan helper with Span deduction guide 2023-09-24 09:50:50 -05:00
random.cpp Merge #18673: scripted-diff: Sort test includes 2023-08-29 22:00:59 -05:00
random.h Merge #18673: scripted-diff: Sort test includes 2023-08-29 22:00:59 -05:00
randomenv.cpp Merge #18673: scripted-diff: Sort test includes 2023-08-29 22:00:59 -05:00
randomenv.h
rest.cpp merge bitcoin#21767: Prune g_chainman usage in auxiliary modules 2023-08-02 10:19:02 -05:00
reverse_iterator.h
saltedhasher.cpp chore: run copyright_header.py update 2023-01-13 00:49:04 +03:00
saltedhasher.h chore: run copyright_header.py update 2023-01-13 00:49:04 +03:00
scheduler.cpp Merge #18673: scripted-diff: Sort test includes 2023-08-29 22:00:59 -05:00
scheduler.h Merge bitcoin/bitcoin#24069: refactor: replace RecursiveMutex m_cs_callbacks_pending with Mutex (and rename) 2023-05-31 10:52:02 -05:00
serialize.h Merge #18673: scripted-diff: Sort test includes 2023-08-29 22:00:59 -05:00
shutdown.cpp merge bitcoin#21575: Create blockstorage module 2023-07-28 00:18:27 -05:00
shutdown.h merge bitcoin#21575: Create blockstorage module 2023-07-28 00:18:27 -05:00
span.h merge bitcoin#23413: Replace MakeSpan helper with Span deduction guide 2023-09-24 09:50:50 -05:00
spentindex.h refactor: make AddressType a strong enum, remove uint8_t for address_type 2023-09-25 22:57:42 +05:30
spork.cpp refactor: decouple db hooks from CFlatDB-based C*Manager objects, migrate to *Store structs (#5555) 2023-09-24 09:50:21 -05:00
spork.h refactor: decouple db hooks from CFlatDB-based C*Manager objects, migrate to *Store structs (#5555) 2023-09-24 09:50:21 -05:00
stacktraces.cpp ci: build TSan with clang 15 and add -Werror=thread-safety, fix-up stacktraces (#5375) 2023-05-26 13:49:29 -05:00
stacktraces.h
statsd_client.cpp
statsd_client.h chore: add missing copyrights via copyright_header.py insert 2023-01-13 00:49:04 +03:00
streams.h merge bitcoin#23451: Add std::byte helpers 2023-09-24 09:50:50 -05:00
sync.cpp Merge #21010: refactor: remove straggling boost::mutex usage 2023-07-25 10:45:09 -05:00
sync.h Merge #19337: sync: detect double lock from the same thread 2023-07-25 10:45:09 -05:00
threadinterrupt.cpp
threadinterrupt.h
threadsafety.h
timedata.cpp Merge #20141: Avoid the use of abs64 in timedata 2023-05-31 10:52:02 -05:00
timedata.h
timestampindex.h refactor: add missing headers to {address,timestamp}index 2023-09-25 22:57:41 +05:30
tinyformat.h Merge #20530: lint, refactor: Update cppcheck linter to c++17 and improve explicit usage 2023-08-01 12:24:36 -05:00
torcontrol.cpp merge bitcoin#19064: Cleanup thread ctor calls 2023-09-04 20:50:27 -05:00
torcontrol.h merge bitcoin#19288: Add fuzzing harness for TorController 2023-08-29 21:55:45 -05:00
txdb.cpp refactor: make AddressType a strong enum, remove uint8_t for address_type 2023-09-25 22:57:42 +05:30
txdb.h refactor: make AddressType a strong enum, remove uint8_t for address_type 2023-09-25 22:57:42 +05:30
txmempool.cpp refactor: make AddressType a strong enum, remove uint8_t for address_type 2023-09-25 22:57:42 +05:30
txmempool.h refactor: make AddressType a strong enum, remove uint8_t for address_type 2023-09-25 22:57:42 +05:30
ui_interface.cpp Merge #17891: scripted-diff: Replace CCriticalSection with RecursiveMutex 2023-05-24 12:43:57 -05:00
ui_interface.h Merge #17891: scripted-diff: Replace CCriticalSection with RecursiveMutex 2023-05-24 12:43:57 -05:00
uint256.cpp uint256: add definition for constant 'ZERO' 2023-04-15 12:12:30 -05:00
uint256.h uint256: add definition for constant 'ZERO' 2023-04-15 12:12:30 -05:00
undo.h Merge #18673: scripted-diff: Sort test includes 2023-08-29 22:00:59 -05:00
unordered_lru_cache.h fix: off-by-1 in unordered_lru_cache 2023-06-12 10:56:10 +03:00
validation.cpp refactor: make AddressType a strong enum, remove uint8_t for address_type 2023-09-25 22:57:42 +05:30
validation.h refactor: make AddressType a strong enum, remove uint8_t for address_type 2023-09-25 22:57:42 +05:30
validationinterface.cpp Merge #18551: Do not clear validationinterface entries being executed 2023-08-03 11:16:41 -05:00
validationinterface.h Merge #18524: refactor: drop boost::signals2 in validationinterface 2023-08-03 11:16:41 -05:00
version.h feat: mnlistdiff v20 CL sig quorums (#5377) 2023-07-10 11:23:09 -05:00
versionbits.cpp partial bitcoin#11389: Support having SegWit always active in regtest 2023-08-29 21:55:45 -05:00
versionbits.h merge bitcoin#21055: Prune remaining g_chainman usage in validation functions 2023-04-04 12:41:45 -05:00
versionbitsinfo.cpp feat: v20 evonodes payment adjustment (#5493) 2023-07-31 23:52:48 -05:00
versionbitsinfo.h refactor: cleanup CChainParams unused data and functions (#5474) 2023-07-04 12:25:36 -05:00
walletinitinterface.h refactor: subsume CoinJoin objects under CJContext, deglobalize coinJoin{ClientQueueManager,Server} (#5337) 2023-09-13 12:52:38 -05:00
warnings.cpp merge bitcoin#19905: Remove dead CheckForkWarningConditionsOnNewFork 2023-04-04 12:41:45 -05:00
warnings.h merge bitcoin#19905: Remove dead CheckForkWarningConditionsOnNewFork 2023-04-04 12:41:45 -05:00