mirror of
https://github.com/dashpay/dash.git
synced 2024-12-26 12:32:48 +01:00
12047d77d0
c82190cdb6 tests: Add Python dead code linter (vulture) (practicalswift) 590a57fdec tests: Remove unused testing code (practicalswift) Pull request description: Add Python dead code linter (`vulture`) to Travis. Rationale for allowing dead code only after explicit opt-in (via `--ignore-names`): * Less is more :-) * Unused code is by definition "untested" * Unused code can be an indication of bugs/logical errors. By making the contributor aware of newly introduced unused code it gives him/her an opportunity to investigate if the unused code they introduce is malignant or benign :-) * Unused code is hard to spot for humans and is thus often missed during manual review * [YAGNI](https://en.wikipedia.org/wiki/You_aren%27t_gonna_need_it) Based on #14312 to make linter job pass. Tree-SHA512: 4c581df7c34986e226e4ade479e0d3c549daf38f4a4dc4564b25564d63e773a1830ba55d1289c771b1fa325483e8855b82b56e61859fe8e4b7dfa54034b093b6
102 lines
4.3 KiB
Python
Executable File
102 lines
4.3 KiB
Python
Executable File
#!/usr/bin/env python3
|
|
# Copyright (c) 2020 The Bitcoin Core developers
|
|
# Distributed under the MIT software license, see the accompanying
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
"""Tests that a mempool transaction expires after a given timeout and that its
|
|
children are removed as well.
|
|
|
|
Both the default expiry timeout defined by DEFAULT_MEMPOOL_EXPIRY and a user
|
|
definable expiry timeout via the '-mempoolexpiry=<n>' command line argument
|
|
(<n> is the timeout in hours) are tested.
|
|
"""
|
|
|
|
from datetime import timedelta
|
|
|
|
from test_framework.test_framework import BitcoinTestFramework
|
|
from test_framework.util import (
|
|
assert_equal,
|
|
assert_raises_rpc_error,
|
|
find_vout_for_address,
|
|
)
|
|
|
|
DEFAULT_MEMPOOL_EXPIRY = 336 # hours
|
|
CUSTOM_MEMPOOL_EXPIRY = 10 # hours
|
|
|
|
|
|
class MempoolExpiryTest(BitcoinTestFramework):
|
|
def set_test_params(self):
|
|
self.num_nodes = 1
|
|
|
|
# TODO: enable when skip_if_no_wallet is backported
|
|
# def skip_test_if_missing_module(self):
|
|
# self.skip_if_no_wallet()
|
|
|
|
def test_transaction_expiry(self, timeout):
|
|
"""Tests that a transaction expires after the expiry timeout and its
|
|
children are removed as well."""
|
|
node = self.nodes[0]
|
|
|
|
# Send a parent transaction that will expire.
|
|
parent_address = node.getnewaddress()
|
|
parent_txid = node.sendtoaddress(parent_address, 1.0)
|
|
|
|
# Set the mocktime to the arrival time of the parent transaction.
|
|
entry_time = node.getmempoolentry(parent_txid)['time']
|
|
node.setmocktime(entry_time)
|
|
|
|
# Create child transaction spending the parent transaction
|
|
vout = find_vout_for_address(node, parent_txid, parent_address)
|
|
inputs = [{'txid': parent_txid, 'vout': vout}]
|
|
outputs = {node.getnewaddress(): 0.99}
|
|
child_raw = node.createrawtransaction(inputs, outputs)
|
|
child_signed = node.signrawtransactionwithwallet(child_raw)['hex']
|
|
|
|
# Let half of the timeout elapse and broadcast the child transaction.
|
|
half_expiry_time = entry_time + int(60 * 60 * timeout/2)
|
|
node.setmocktime(half_expiry_time)
|
|
child_txid = node.sendrawtransaction(child_signed)
|
|
self.log.info('Broadcast child transaction after {} hours.'.format(
|
|
timedelta(seconds=(half_expiry_time-entry_time))))
|
|
|
|
# Let most of the timeout elapse and check that the parent tx is still
|
|
# in the mempool.
|
|
nearly_expiry_time = entry_time + 60 * 60 * timeout - 5
|
|
node.setmocktime(nearly_expiry_time)
|
|
# Expiry of mempool transactions is only checked when a new transaction
|
|
# is added to the to the mempool.
|
|
node.sendtoaddress(node.getnewaddress(), 1.0)
|
|
self.log.info('Test parent tx not expired after {} hours.'.format(
|
|
timedelta(seconds=(nearly_expiry_time-entry_time))))
|
|
assert_equal(entry_time, node.getmempoolentry(parent_txid)['time'])
|
|
|
|
# Transaction should be evicted from the mempool after the expiry time
|
|
# has passed.
|
|
expiry_time = entry_time + 60 * 60 * timeout + 5
|
|
node.setmocktime(expiry_time)
|
|
# Expiry of mempool transactions is only checked when a new transaction
|
|
# is added to the to the mempool.
|
|
node.sendtoaddress(node.getnewaddress(), 1.0)
|
|
self.log.info('Test parent tx expiry after {} hours.'.format(
|
|
timedelta(seconds=(expiry_time-entry_time))))
|
|
assert_raises_rpc_error(-5, 'Transaction not in mempool',
|
|
node.getmempoolentry, parent_txid)
|
|
|
|
# The child transaction should be removed from the mempool as well.
|
|
self.log.info('Test child tx is evicted as well.')
|
|
assert_raises_rpc_error(-5, 'Transaction not in mempool',
|
|
node.getmempoolentry, child_txid)
|
|
|
|
def run_test(self):
|
|
self.log.info('Test default mempool expiry timeout of %d hours.' %
|
|
DEFAULT_MEMPOOL_EXPIRY)
|
|
self.test_transaction_expiry(DEFAULT_MEMPOOL_EXPIRY)
|
|
|
|
self.log.info('Test custom mempool expiry timeout of %d hours.' %
|
|
CUSTOM_MEMPOOL_EXPIRY)
|
|
self.restart_node(0, ['-mempoolexpiry=%d' % CUSTOM_MEMPOOL_EXPIRY])
|
|
self.test_transaction_expiry(CUSTOM_MEMPOOL_EXPIRY)
|
|
|
|
|
|
if __name__ == '__main__':
|
|
MempoolExpiryTest().main()
|