mirror of
https://github.com/dashpay/dash.git
synced 2024-12-26 20:42:59 +01:00
42d4f9a9b9
BACKPORT NOTE:
the field `banscore` is used by functional test p2p_quorum_data.py and can't be removed now
454a4088a87eac5878070b26d13d5574da891877 [doc] Add release notes for removed getpeerinfo fields. (Amiti Uttarwar)
b1a936d4ae7dd9030b0720ef05579a90ce2894f1 [rpc] Remove deprecated "whitelisted" field from getpeerinfo (Amiti Uttarwar)
094c3beaa47c909070607e94f2544ed1472ddb17 [rpc] Remove deprecated "banscore" field from getpeerinfo (Amiti Uttarwar)
537053336fbc1b633e7c99286c3e3492eaca1e9d [rpc] Remove deprecated "addnode" field from getpeerinfo (Amiti Uttarwar)
Pull request description:
This PR removes support for 3 fields on the `getpeerinfo` RPC that were deprecated in v0.21- `addnode`, `banscore` & `whitelisted`.
ACKs for top commit:
sipa:
utACK 454a4088a87eac5878070b26d13d5574da891877
jnewbery:
ACK 454a4088a87eac5878070b26d13d5574da891877.
Tree-SHA512: ccc0e90c0763eeb8529cf0c46162dbaca3f7773981b3b52d9925166ea7421aed086795d56b320e16c9340f68862388785f52a9b78314865070917b33180d7cd6
93 lines
4.3 KiB
Python
Executable File
93 lines
4.3 KiB
Python
Executable File
#!/usr/bin/env python3
|
|
# Copyright (c) 2024 The Dash Core developers
|
|
# Distributed under the MIT software license, see the accompanying
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
"""Test that commands submitted by the platform user are filtered."""
|
|
|
|
from test_framework.test_framework import BitcoinTestFramework
|
|
from test_framework.util import str_to_b64str, assert_equal
|
|
|
|
import http.client
|
|
import json
|
|
import os
|
|
import urllib.parse
|
|
|
|
|
|
class HTTPBasicsTest(BitcoinTestFramework):
|
|
def set_test_params(self):
|
|
self.num_nodes = 1
|
|
self.supports_cli = False
|
|
|
|
def setup_nodes(self):
|
|
self.add_nodes(self.num_nodes)
|
|
self.start_nodes()
|
|
|
|
def setup_chain(self):
|
|
super().setup_chain()
|
|
# Append rpcauth to dash.conf before initialization
|
|
rpcauthplatform = "rpcauth=platform-user:dd88fd676186f48553775d6fb5a2d344$bc1f7898698ead19c6ec7ff47055622dd7101478f1ff6444103d3dc03cd77c13"
|
|
# rpcuser : platform-user
|
|
# rpcpassword : password123
|
|
rpcauthoperator = "rpcauth=operator:e9b45dd0b61a7be72155535435365a3a$8fb7470bc6f74d8ceaf9a23f49b06127723bd563b3ed5d9cea776ef01803d191"
|
|
# rpcuser : operator
|
|
# rpcpassword : otherpassword
|
|
|
|
masternodeblskey="masternodeblsprivkey=58af6e39bb4d86b22bda1a02b134c2f5b71caffa1377540b02f7f1ad122f59e0"
|
|
|
|
with open(os.path.join(self.options.tmpdir+"/node0", "dash.conf"), 'a', encoding='utf8') as f:
|
|
f.write(masternodeblskey+"\n")
|
|
f.write(rpcauthplatform+"\n")
|
|
f.write(rpcauthoperator+"\n")
|
|
|
|
def run_test(self):
|
|
url = urllib.parse.urlparse(self.nodes[0].url)
|
|
|
|
def send_command(method, params, auth, expected_status, should_not_match=False):
|
|
conn = http.client.HTTPConnection(url.hostname, url.port)
|
|
conn.connect()
|
|
body = {"method": method}
|
|
if len(params):
|
|
body["params"] = params
|
|
conn.request('POST', '/', json.dumps(body), {"Authorization": "Basic " + str_to_b64str(auth)})
|
|
resp = conn.getresponse()
|
|
if should_not_match:
|
|
assert resp.status != expected_status
|
|
else:
|
|
assert_equal(resp.status, expected_status)
|
|
conn.close()
|
|
|
|
rpcuser_authpair_platform = "platform-user:password123"
|
|
rpcuser_authpair_operator = "operator:otherpassword"
|
|
rpcuser_authpair_wrong = "platform-user:rpcpasswordwrong"
|
|
|
|
external_log_str = "HTTP: Calling handler for external user"
|
|
always_expected_log_str = "ThreadRPCServer method="
|
|
|
|
self.log.info('Try using a incorrect password for platform-user...')
|
|
send_command("getbestblockhash", [], rpcuser_authpair_wrong, 401)
|
|
|
|
self.log.info("Check that there's no external queue by default")
|
|
with self.nodes[0].assert_debug_log(expected_msgs=[always_expected_log_str], unexpected_msgs = [external_log_str]):
|
|
send_command("getbestblockhash", [], rpcuser_authpair_platform, 200)
|
|
with self.nodes[0].assert_debug_log(expected_msgs=[always_expected_log_str], unexpected_msgs = [external_log_str]):
|
|
send_command("getbestblockhash", [], rpcuser_authpair_operator, 200)
|
|
|
|
self.log.info("Restart node with -rpcexternaluser")
|
|
self.restart_node(0, extra_args=["-rpcexternaluser=platform-user"])
|
|
|
|
with self.nodes[0].assert_debug_log(expected_msgs=[always_expected_log_str, external_log_str]):
|
|
send_command("getbestblockhash", [], rpcuser_authpair_platform, 200)
|
|
with self.nodes[0].assert_debug_log(expected_msgs=[always_expected_log_str], unexpected_msgs = [external_log_str]):
|
|
send_command("getbestblockhash", [], rpcuser_authpair_operator, 200)
|
|
|
|
self.log.info("Restart node with multiple external users")
|
|
self.restart_node(0, extra_args=["-rpcexternaluser=platform-user,operator"])
|
|
with self.nodes[0].assert_debug_log(expected_msgs=[always_expected_log_str, external_log_str]):
|
|
send_command("getbestblockhash", [], rpcuser_authpair_platform, 200)
|
|
with self.nodes[0].assert_debug_log(expected_msgs=[always_expected_log_str, external_log_str]):
|
|
send_command("getbestblockhash", [], rpcuser_authpair_operator, 200)
|
|
|
|
|
|
if __name__ == '__main__':
|
|
HTTPBasicsTest().main()
|