Dash - Reinventing Cryptocurrency
Go to file
Alexander Block 91b4a38398 Backport bitcoin#11773: [tests] Change feature_block.py to use BitcoinTestFramework (#3277)
* [tests] Change feature_block.py to use BitcoinTestFramework

* [tests] Fix flake8 warnings in feature_block.py

* [tests] Tidy up feature_block.py

- move all helper methods to the end
- remove block, create_tx and create_and_sign_tx shortcuts
- remove --runbarelyexpensive option, since it defaults to True and it's
unlikely that anyone ever runs the test with this option set to false.

* [tests] Add logging to feature_block.py

* [tests] Improve assert message when wait_until() fails

* Merge #13048: [tests] Fix feature_block flakiness

c1d742025c [tests] Fix feature_block flakiness (John Newbery)

Pull request description:

  feature_block.py occasionally fails on Travis. I believe this is due to
  a a race condition when reconnecting to bitcoind after a subtest that
  expects disconnection. If the test runs ahead and sends the INV for the
  subsequent test before we've received the initial sync getheaders, then
  we may end up sending two headers messages - one as a response to the
  initial sync getheaders and one in response to the INV getheaders. If
  both of those headers fail validation with a DoS score of 50 or higher,
  then we'll unexpectedly be disconnected.

  There is only one validation failure that has a DoS score bewteen 50 and
  100, which is high-hash. That's why the test is failing immediately
  after the "Reject a block with invalid work" subtest.

  Fix is to wait for the initial getheaders from the peer before we
  start populating our blockstore. That way we won't have any invalid
  headers to respond to it with.

Tree-SHA512: dc17d795fcfaf0f8c0bf1e9732b5e11fbc8febbfafba4c231b7c13a5404a2c297dcd703a7a75bc7f353c893e12efc87f424f2201abd47ba5268af32d4d2e841f

* Temporarely rename MAX_BLOCK_SIZE -> MAX_BLOCK_BASE_SIZE

We'll undo this after the next commit. This avoids merge many conflicts and
makes reviewing easier.

* Rename MAX_BLOCK_BASE_SIZE back to MAX_BLOCK_SIZE

* Use DoS score of 100 for bad-blk-sigops

This was accidently changed to 10 while backporting bitcoin#7287 and causes
test failures in p2p-fullblocktest.py

* Use allowOptimisticSend=true when sending reject messages

This fixes test failures in p2p-fullblocktest.py which expects reject
messages to be sent/received before connections get closed.

* Fix p2p-fullblocktest.py

- CBlock and friends are still in test_framework.mininode
- "-whitelist" causes connections to not be dropped, which in turn causes
  sync_blocks with reconnect=True to fail
- "bad-cb-amount" does not cause a ban in Dash, so reconnect must be False
- Dash already bans when a header is received which is a child of an invalid
  header, causing block requests to never happen

* Backport missing changes from bitcoin#13003

bitcoin#13003 was backported out of order which causes missed changes.

* Bump p2p-fullblocktest timeouts

* Increase RPC timeout in p2p-fullblocktest.py

Co-authored-by: John Newbery <jonnynewbs@gmail.com>
Co-authored-by: MarcoFalke <falke.marco@gmail.com>
2020-01-11 04:31:25 +03:00
.github Add link to bugcrowd in issue template (#2716) 2019-02-19 13:05:59 +03:00
.tx Merge remote-tracking branch 'bitcoin/0.12' into HEAD 2016-02-06 16:48:04 +03:00
build-aux/m4 Merge #10803: Explicitly search for bdb5.3. 2019-07-24 11:59:09 -05:00
ci Merge #14630: test_runner: Remove travis specific code 2020-01-07 23:12:29 +01:00
contrib Merge #10781: Python cleanups 2020-01-02 22:01:29 -06:00
depends Merge #12607: depends: Remove ccache 2019-11-04 13:20:45 +01:00
doc Merge #11050: Avoid treating null RPC arguments different from missing arguments 2020-01-02 21:59:48 -06:00
docker Automatically build and push docker image to docker.io/dashpay/dashd-develop (#1809) 2018-01-10 12:17:43 +03:00
share Merge #10781: Python cleanups 2020-01-02 22:01:29 -06:00
src Backport bitcoin#11773: [tests] Change feature_block.py to use BitcoinTestFramework (#3277) 2020-01-11 04:31:25 +03:00
test Backport bitcoin#11773: [tests] Change feature_block.py to use BitcoinTestFramework (#3277) 2020-01-11 04:31:25 +03:00
.gitattributes
.gitignore bitcoin -> dash 2019-08-24 11:11:25 -05:00
.gitlab-ci.yml Fix pull request detection in .gitlab-ci.yml (#3256) 2019-12-31 13:02:03 +03:00
.travis.yml Add support for Gitlab CI (#3149) 2019-10-16 11:48:46 +02:00
autogen.sh Merge #8784: Copyright headers for build scripts 2018-01-12 08:02:45 +01:00
CMakeLists.txt Enable stacktrace support in gitian builds (#3006) 2019-07-02 07:16:11 +03:00
configure.ac Merge #11164: Fix boost headers included as user instead of system headers 2020-01-01 22:31:14 -06:00
CONTRIBUTING.md Merge #11236: Add note on translations to CONTRIBUTING.md 2020-01-01 22:31:14 -06:00
COPYING Merge #11318: Put back inadvertently removed copyright notices 2019-09-25 10:33:21 +02:00
INSTALL.md Dashify INSTALL.md and build-unix.md 2018-01-12 16:12:54 +01:00
Jenkinsfile Perform Jenkins builds in /dash-src all the time to fix caching issues (#2242) 2018-08-29 13:03:18 +03:00
Jenkinsfile.gitian Let ccache compress the cache by itself instead of compressing ccache.tar (#2456) 2018-11-19 07:31:13 +01:00
libdashconsensus.pc.in Merge #7192: Unify product name to as few places as possible 2017-12-11 08:30:26 +01:00
Makefile.am Merge #11530: Add share/rpcuser to dist. source code archive 2019-09-30 08:33:16 +02:00
README.md Bump version to 0.16 on develop (#3239) 2019-12-13 18:52:52 +01:00

Dash Core staging tree 0.16

master: Build Status develop: Build Status

https://www.dash.org

What is Dash?

Dash is an experimental digital currency that enables instant, private payments to anyone, anywhere in the world. Dash uses peer-to-peer technology to operate with no central authority: managing transactions and issuing money are carried out collectively by the network. Dash Core is the name of the open source software which enables the use of this currency.

For more information, as well as an immediately useable, binary version of the Dash Core software, see https://www.dash.org/get-dash/.

License

Dash Core is released under the terms of the MIT license. See COPYING for more information or see https://opensource.org/licenses/MIT.

Development Process

The master branch is meant to be stable. Development is normally done in separate branches. Tags are created to indicate new official, stable release versions of Dash Core.

The contribution workflow is described in CONTRIBUTING.md.

Testing

Testing and code review is the bottleneck for development; we get more pull requests than we can review and test on short notice. Please be patient and help out by testing other people's pull requests, and remember this is a security-critical project where any mistake might cost people lots of money.

Automated Testing

Developers are strongly encouraged to write unit tests for new code, and to submit new unit tests for old code. Unit tests can be compiled and run (assuming they weren't disabled in configure) with: make check. Further details on running and extending unit tests can be found in /src/test/README.md.

There are also regression and integration tests, written in Python, that are run automatically on the build server. These tests can be run (if the test dependencies are installed) with: test/functional/test_runner.py

The Travis CI system makes sure that every pull request is built for Windows, Linux, and OS X, and that unit/sanity tests are run automatically.

Manual Quality Assurance (QA) Testing

Changes should be tested by somebody other than the developer who wrote the code. This is especially important for large or high-risk changes. It is useful to add a test plan to the pull request description if testing the changes is not straightforward.

Translations

Changes to translations as well as new translations can be submitted to Dash Core's Transifex page.

Translations are periodically pulled from Transifex and merged into the git repository. See the translation process for details on how this works.

Important: We do not accept translation changes as GitHub pull requests because the next pull from Transifex would automatically overwrite them again.

Translators should also follow the forum.