mirror of
https://github.com/dashpay/dash.git
synced 2024-12-26 04:22:55 +01:00
17acd6b472
643aad17fa
Enable additional flake8 rules (practicalswift)f020aca297
Minor Python cleanups to make flake8 pass with the new rules enabled (practicalswift) Pull request description: Enabled rules: ``` * E242: tab after ',' * E266: too many leading '#' for block comment * E401: multiple imports on one line * E402: module level import not at top of file * E701: multiple statements on one line (colon) * E901: SyntaxError: invalid syntax * E902: TokenError: EOF in multi-line string * F821: undefined name 'Foo' * W293: blank line contains whitespace * W606: 'async' and 'await' are reserved keywords starting with Python 3.7 ``` Note to reviewers: * In general we don't allow whitespace cleanups to existing code, but in order to allow for enabling Travis checking for these rules a few smaller whitespace cleanups had to made as part of this PR. * Use [this `?w=1` link](https://github.com/bitcoin/bitcoin/pull/12987/files?w=1) to show a diff without whitespace changes. Before this commit: ``` $ flake8 -qq --statistics --ignore=B,C,E,F,I,N,W --select=E112,E113,E115,E116,E125,E131,E133,E223,E224,E242,E266,E271,E272,E273,E274,E275,E304,E306,E401,E402,E502,E701,E702,E703,E714,E721,E741,E742,E743,F401,E901,E902,F402,F404,F406,F407,F601,F602,F621,F622,F631,F701,F702,F703,F704,F705,F706,F707,F811,F812,F821,F822,F823,F831,F841,W292,W293,W504,W601,W602,W603,W604,W605,W606 . 5 E266 too many leading '#' for block comment 4 E401 multiple imports on one line 6 E402 module level import not at top of file 5 E701 multiple statements on one line (colon) 1 F812 list comprehension redefines 'n' from line 159 4 F821 undefined name 'ConnectionRefusedError' 28 W293 blank line contains whitespace ``` After this commit: ``` $ flake8 -qq --statistics --ignore=B,C,E,F,I,N,W --select=E112,E113,E115,E116,E125,E131,E133,E223,E224,E242,E266,E271,E272,E273,E274,E275,E304,E306,E401,E402,E502,E701,E702,E703,E714,E721,E741,E742,E743,F401,E901,E902,F402,F404,F406,F407,F601,F602,F621,F622,F631,F701,F702,F703,F704,F705,F706,F707,F811,F812,F821,F822,F823,F831,F841,W292,W293,W504,W601,W602,W603,W604,W605,W606 . $ ``` Tree-SHA512: fc7d5e752298a50d4248afc620ee2c173135b4ca008e48e02913ac968e5a24a5fd5396926047ec62f1d580d537434ccae01f249bb2f3338fa59dc630bf97ca7a Signed-off-by: pasta <pasta@dashboost.org>
145 lines
6.5 KiB
Python
Executable File
145 lines
6.5 KiB
Python
Executable File
#!/usr/bin/env python3
|
|
# Copyright (c) 2014-2016 The Bitcoin Core developers
|
|
# Distributed under the MIT software license, see the accompanying
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
"""Test the wallet accounts properly when there is a double-spend conflict."""
|
|
|
|
from test_framework.test_framework import BitcoinTestFramework
|
|
from test_framework.util import *
|
|
|
|
class TxnMallTest(BitcoinTestFramework):
|
|
def set_test_params(self):
|
|
self.num_nodes = 4
|
|
|
|
def add_options(self, parser):
|
|
parser.add_option("--mineblock", dest="mine_block", default=False, action="store_true",
|
|
help="Test double-spend of 1-confirmed transaction")
|
|
|
|
def setup_network(self):
|
|
# Start with split network:
|
|
super().setup_network()
|
|
disconnect_nodes(self.nodes[1], 2)
|
|
disconnect_nodes(self.nodes[2], 1)
|
|
|
|
def run_test(self):
|
|
# All nodes should start with 12,500 DASH:
|
|
starting_balance = 12500
|
|
for i in range(4):
|
|
assert_equal(self.nodes[i].getbalance(), starting_balance)
|
|
self.nodes[i].getnewaddress("") # bug workaround, coins generated assigned to first getnewaddress!
|
|
|
|
# Assign coins to foo and bar accounts:
|
|
node0_address_foo = self.nodes[0].getnewaddress("foo")
|
|
fund_foo_txid = self.nodes[0].sendfrom("", node0_address_foo, 12190)
|
|
fund_foo_tx = self.nodes[0].gettransaction(fund_foo_txid)
|
|
|
|
node0_address_bar = self.nodes[0].getnewaddress("bar")
|
|
fund_bar_txid = self.nodes[0].sendfrom("", node0_address_bar, 290)
|
|
fund_bar_tx = self.nodes[0].gettransaction(fund_bar_txid)
|
|
|
|
assert_equal(self.nodes[0].getbalance(""),
|
|
starting_balance - 12190 - 290 + fund_foo_tx["fee"] + fund_bar_tx["fee"])
|
|
|
|
# Coins are sent to node1_address
|
|
node1_address = self.nodes[1].getnewaddress("from0")
|
|
|
|
# First: use raw transaction API to send 12400 DASH to node1_address,
|
|
# but don't broadcast:
|
|
doublespend_fee = Decimal('-.02')
|
|
rawtx_input_0 = {}
|
|
rawtx_input_0["txid"] = fund_foo_txid
|
|
rawtx_input_0["vout"] = find_output(self.nodes[0], fund_foo_txid, 12190)
|
|
rawtx_input_1 = {}
|
|
rawtx_input_1["txid"] = fund_bar_txid
|
|
rawtx_input_1["vout"] = find_output(self.nodes[0], fund_bar_txid, 290)
|
|
inputs = [rawtx_input_0, rawtx_input_1]
|
|
change_address = self.nodes[0].getnewaddress()
|
|
outputs = {}
|
|
outputs[node1_address] = 12400
|
|
outputs[change_address] = 12480 - 12400 + doublespend_fee
|
|
rawtx = self.nodes[0].createrawtransaction(inputs, outputs)
|
|
doublespend = self.nodes[0].signrawtransaction(rawtx)
|
|
assert_equal(doublespend["complete"], True)
|
|
|
|
# Create two spends using 1 500 DASH coin each
|
|
txid1 = self.nodes[0].sendfrom("foo", node1_address, 400, 0)
|
|
txid2 = self.nodes[0].sendfrom("bar", node1_address, 200, 0)
|
|
|
|
# Have node0 mine a block:
|
|
if (self.options.mine_block):
|
|
self.nodes[0].generate(1)
|
|
self.sync_blocks(self.nodes[0:2])
|
|
|
|
tx1 = self.nodes[0].gettransaction(txid1)
|
|
tx2 = self.nodes[0].gettransaction(txid2)
|
|
|
|
# Node0's balance should be starting balance, plus 500DASH for another
|
|
# matured block, minus 400, minus 200, and minus transaction fees:
|
|
expected = starting_balance + fund_foo_tx["fee"] + fund_bar_tx["fee"]
|
|
if self.options.mine_block:
|
|
expected += 500
|
|
expected += tx1["amount"] + tx1["fee"]
|
|
expected += tx2["amount"] + tx2["fee"]
|
|
assert_equal(self.nodes[0].getbalance(), expected)
|
|
|
|
# foo and bar accounts should be debited:
|
|
assert_equal(self.nodes[0].getbalance("foo", 0), 12190+tx1["amount"]+tx1["fee"])
|
|
assert_equal(self.nodes[0].getbalance("bar", 0), 290+tx2["amount"]+tx2["fee"])
|
|
|
|
if self.options.mine_block:
|
|
assert_equal(tx1["confirmations"], 1)
|
|
assert_equal(tx2["confirmations"], 1)
|
|
# Node1's "from0" balance should be both transaction amounts:
|
|
assert_equal(self.nodes[1].getbalance("from0"), -(tx1["amount"]+tx2["amount"]))
|
|
else:
|
|
assert_equal(tx1["confirmations"], 0)
|
|
assert_equal(tx2["confirmations"], 0)
|
|
|
|
# Now give doublespend and its parents to miner:
|
|
self.nodes[2].sendrawtransaction(fund_foo_tx["hex"])
|
|
self.nodes[2].sendrawtransaction(fund_bar_tx["hex"])
|
|
doublespend_txid = self.nodes[2].sendrawtransaction(doublespend["hex"])
|
|
# ... mine a block...
|
|
self.nodes[2].generate(1)
|
|
|
|
# Reconnect the split network, and sync chain:
|
|
connect_nodes(self.nodes[1], 2)
|
|
self.nodes[2].generate(1) # Mine another block to make sure we sync
|
|
self.sync_blocks()
|
|
assert_equal(self.nodes[0].gettransaction(doublespend_txid)["confirmations"], 2)
|
|
|
|
# Re-fetch transaction info:
|
|
tx1 = self.nodes[0].gettransaction(txid1)
|
|
tx2 = self.nodes[0].gettransaction(txid2)
|
|
|
|
# Both transactions should be conflicted
|
|
assert_equal(tx1["confirmations"], -2)
|
|
assert_equal(tx2["confirmations"], -2)
|
|
|
|
# Node0's total balance should be starting balance, plus 1000DASH for
|
|
# two more matured blocks, minus 12400 for the double-spend, plus fees (which are
|
|
# negative):
|
|
expected = starting_balance + 1000 - 12400 + fund_foo_tx["fee"] + fund_bar_tx["fee"] + doublespend_fee
|
|
assert_equal(self.nodes[0].getbalance(), expected)
|
|
assert_equal(self.nodes[0].getbalance("*"), expected)
|
|
|
|
# Final "" balance is starting_balance - amount moved to accounts - doublespend + subsidies +
|
|
# fees (which are negative)
|
|
assert_equal(self.nodes[0].getbalance("foo"), 12190)
|
|
assert_equal(self.nodes[0].getbalance("bar"), 290)
|
|
assert_equal(self.nodes[0].getbalance(""), starting_balance
|
|
-12190
|
|
- 290
|
|
-12400
|
|
+ 1000
|
|
+ fund_foo_tx["fee"]
|
|
+ fund_bar_tx["fee"]
|
|
+ doublespend_fee)
|
|
|
|
# Node1's "from0" account balance should be just the doublespend:
|
|
assert_equal(self.nodes[1].getbalance("from0"), 12400)
|
|
|
|
if __name__ == '__main__':
|
|
TxnMallTest().main()
|
|
|