mirror of
https://github.com/dashpay/dash.git
synced 2024-12-28 21:42:47 +01:00
a2f107424b
d60234885bAdd test for signrawtransaction (Andrew Chow)eefff65a4bscripted-diff: change signrawtransaction to signrawtransactionwithwallet in tests (Andrew Chow)1e79c055cdSplit signrawtransaction into wallet and non-wallet (Andrew Chow) Pull request description: This PR is part of #10570. It also builds on top of #10571. This PR splits `signrawtransaction` into two commands, `signrawtransactionwithkey` and `signrawtransactionwithwallet`. `signrawtransactionwithkey` requires private keys to be passed in and does not use the wallet for any signing. `signrawtransactionwithwallet` uses the wallet to sign a raw transaction and does not have any parameters to take private keys. The `signrawtransaction` RPC has been marked as deprecated and will call the appropriate RPC command based upon the parameters given. A test was added to check this behavior is still consistent with the original behavior. All tests that used `signrawtransaction` have been updated to use one of the two new RPCs. Most uses were changed to `signrawtransactionwithwallet`. These were changed via a scripted diff. Tree-SHA512: d0adf5b4cd7077639c504ec07bee262a3b94658d34db0a5c86a263b6393f7aa62f45129eafe29a7c861aa58440dd19348ee0c8b685e8a62d6f4adae8ec8f8cb3
65 lines
3.1 KiB
Python
Executable File
65 lines
3.1 KiB
Python
Executable File
#!/usr/bin/env python3
|
|
# Copyright (c) 2014-2016 The Bitcoin Core developers
|
|
# Distributed under the MIT software license, see the accompanying
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
"""Test mempool limiting together/eviction with the wallet."""
|
|
|
|
from test_framework.test_framework import BitcoinTestFramework
|
|
from test_framework.util import *
|
|
|
|
class MempoolLimitTest(BitcoinTestFramework):
|
|
def set_test_params(self):
|
|
self.setup_clean_chain = True
|
|
self.num_nodes = 1
|
|
self.extra_args = [["-maxmempool=5", "-spendzeroconfchange=0"]]
|
|
|
|
def run_test(self):
|
|
txouts = gen_return_txouts()
|
|
relayfee = self.nodes[0].getnetworkinfo()['relayfee']
|
|
|
|
self.log.info('Check that mempoolminfee is minrelytxfee')
|
|
assert_equal(self.nodes[0].getmempoolinfo()['minrelaytxfee'], Decimal('0.00001000'))
|
|
assert_equal(self.nodes[0].getmempoolinfo()['mempoolminfee'], Decimal('0.00001000'))
|
|
|
|
txids = []
|
|
utxos = create_confirmed_utxos(relayfee, self.nodes[0], 491)
|
|
|
|
self.log.info('Create a mempool tx that will be evicted')
|
|
us0 = utxos.pop()
|
|
inputs = [{ "txid" : us0["txid"], "vout" : us0["vout"]}]
|
|
outputs = {self.nodes[0].getnewaddress() : 0.0001}
|
|
tx = self.nodes[0].createrawtransaction(inputs, outputs)
|
|
self.nodes[0].settxfee(relayfee) # specifically fund this tx with low fee
|
|
txF = self.nodes[0].fundrawtransaction(tx)
|
|
self.nodes[0].settxfee(0) # return to automatic fee selection
|
|
txFS = self.nodes[0].signrawtransactionwithwallet(txF['hex'])
|
|
txid = self.nodes[0].sendrawtransaction(txFS['hex'])
|
|
|
|
relayfee = self.nodes[0].getnetworkinfo()['relayfee']
|
|
base_fee = relayfee*100
|
|
for i in range (3):
|
|
txids.append([])
|
|
txids[i] = create_lots_of_big_transactions(self.nodes[0], txouts, utxos[30*i:30*i+30], 30, (i+1)*base_fee)
|
|
|
|
self.log.info('The tx should be evicted by now')
|
|
assert(txid not in self.nodes[0].getrawmempool())
|
|
txdata = self.nodes[0].gettransaction(txid)
|
|
assert(txdata['confirmations'] == 0) #confirmation should still be 0
|
|
|
|
self.log.info('Check that mempoolminfee is larger than minrelytxfee')
|
|
assert_equal(self.nodes[0].getmempoolinfo()['minrelaytxfee'], Decimal('0.00001000'))
|
|
assert_greater_than(self.nodes[0].getmempoolinfo()['mempoolminfee'], Decimal('0.00001000'))
|
|
|
|
self.log.info('Create a mempool tx that will not pass mempoolminfee')
|
|
us0 = utxos.pop()
|
|
inputs = [{ "txid" : us0["txid"], "vout" : us0["vout"]}]
|
|
outputs = {self.nodes[0].getnewaddress() : 0.0001}
|
|
tx = self.nodes[0].createrawtransaction(inputs, outputs)
|
|
# specifically fund this tx with a fee < mempoolminfee, >= than minrelaytxfee
|
|
txF = self.nodes[0].fundrawtransaction(tx, {'feeRate': relayfee})
|
|
txFS = self.nodes[0].signrawtransactionwithwallet(txF['hex'])
|
|
assert_raises_rpc_error(-26, "mempool min fee not met", self.nodes[0].sendrawtransaction, txFS['hex'])
|
|
|
|
if __name__ == '__main__':
|
|
MempoolLimitTest().main()
|