dash/src/wallet
fanquake ab36852267 Merge #16286: refactoring: wallet: Fix GCC 7.4.0 warning
d8bd97d5ee766a75dec016203bd4d4aafcc24c4f Fix GCC 7.4.0 warning (Hennadii Stepanov)

Pull request description:

  Having #13756 and #16239 merged cause GCC warning:
  ```
  $ gcc --version
  gcc (Ubuntu 7.4.0-1ubuntu1~18.04.1) 7.4.0
  ...
  $ make -j 4 > /dev/null
  wallet/wallet.cpp: In member function ‘CWallet::Balance CWallet::GetBalance(int, bool) const’:
  wallet/wallet.cpp:2269:45: warning: enumeral and non-enumeral type in conditional expression [-Wextra]
       isminefilter reuse_filter = avoid_reuse ? 0 : ISMINE_USED;
                                   ~~~~~~~~~~~~^~~~~~~~~~~~~~~~~
  ```

  Fixed with this PR.

ACKs for top commit:
  practicalswift:
    utACK d8bd97d5ee766a75dec016203bd4d4aafcc24c4f
  promag:
    ACK d8bd97d.
  kallewoof:
    utACK d8bd97d5ee766a75dec016203bd4d4aafcc24c4f
  meshcollider:
    Trivial utACK d8bd97d5ee

Tree-SHA512: 2fb315ac82f290c8b9f4e48d1b4526b9babe0717c68593c7bc55cd6c289e64b6322aba72984f39291a9254b57d3f6ba8dbfe03799f510c0c1dc108b21b286732
2023-12-06 11:40:14 -06:00
..
test Merge #15710: wallet: Catch ios_base::failure specifically 2023-12-03 20:32:22 -06:00
bdb.cpp merge bitcoin#20464: Treat CDataStream bytes as uint8_t 2023-09-24 09:50:50 -05:00
bdb.h fix: add missing includes and remove obsolete includes (#5562) 2023-09-07 09:07:02 -05:00
coincontrol.cpp Merge #15906: [wallet] Move min_depth and max_depth to coin control 2023-04-04 12:45:27 -05:00
coincontrol.h Merge #15906: [wallet] Move min_depth and max_depth to coin control 2023-04-04 12:45:27 -05:00
coinselection.cpp Merge #17458: Refactor OutputGroup effective value calculations and filtering to occur within the struct 2023-12-03 20:32:22 -06:00
coinselection.h Merge #17458: Refactor OutputGroup effective value calculations and filtering to occur within the struct 2023-12-03 20:32:22 -06:00
context.cpp merge bitcoin#19096: Remove g_rpc_chain global 2022-05-18 20:50:50 +05:30
context.h merge bitcoin#18923: Never schedule MaybeCompactWalletDB when -flushwallet is off 2022-07-03 00:14:47 +05:30
crypter.cpp Bitcoin backport #16227 refactoring CWallet (#4903) 2022-07-12 22:46:31 -05:00
crypter.h Bitcoin backport #16227 refactoring CWallet (#4903) 2022-07-12 22:46:31 -05:00
db.cpp Merge #17891: scripted-diff: Replace CCriticalSection with RecursiveMutex 2023-05-24 12:43:57 -05:00
db.h Merge #18673: scripted-diff: Sort test includes 2023-08-29 22:00:59 -05:00
fees.cpp Merge #11882: Disable default fallbackfee on mainnet 2022-01-30 18:30:28 -05:00
fees.h merge bitcoin#15288: Remove wallet -> node global function calls 2021-11-14 15:32:37 +05:30
init.cpp refactor: subsume CoinJoin objects under CJContext, deglobalize coinJoin{ClientQueueManager,Server} (#5337) 2023-09-13 12:52:38 -05:00
interfaces.cpp refactor: subsume CoinJoin objects under CJContext, deglobalize coinJoin{ClientQueueManager,Server} (#5337) 2023-09-13 12:52:38 -05:00
ismine.h Merge #17350: doc: Add developer documentation to isminetype 2023-08-28 11:24:41 -05:00
load.cpp refactor: subsume CoinJoin objects under CJContext, deglobalize coinJoin{ClientQueueManager,Server} (#5337) 2023-09-13 12:52:38 -05:00
load.h revert: revert bitcoin#15454 (Remove the automatic creation and loading of the default wallet) 2022-12-04 18:02:40 -06:00
rpcdump.cpp merge bitcoin#23413: Replace MakeSpan helper with Span deduction guide 2023-09-24 09:50:50 -05:00
rpcwallet.cpp Merge #18814: rpc: Relock wallet only if most recent callback 2023-12-05 12:47:47 -06:00
rpcwallet.h Merge #18673: scripted-diff: Sort test includes 2023-08-29 22:00:59 -05:00
salvage.cpp Merge #17261: Make ScriptPubKeyMan an actual interface and the wallet to have multiple 2023-03-19 11:08:31 -05:00
salvage.h merge bitcoin#19457: Cleanup wallettool salvage and walletdb extraneous declarations 2022-05-13 18:04:32 +05:30
scriptpubkeyman.cpp merge bitcoin#23409: Take Span in SetSeed 2023-09-24 09:50:50 -05:00
scriptpubkeyman.h fix: add missing includes and remove obsolete includes (#5562) 2023-09-07 09:07:02 -05:00
sqlite.cpp fix: 5072 follow-ups (#5197) 2023-02-12 20:12:53 -06:00
sqlite.h (Partial) Merge #20125: rpc, wallet: Expose database format in getwalletinfo 2023-07-26 15:40:19 +05:30
wallet.cpp Merge #16286: refactoring: wallet: Fix GCC 7.4.0 warning 2023-12-06 11:40:14 -06:00
wallet.h Merge #18814: rpc: Relock wallet only if most recent callback 2023-12-05 12:47:47 -06:00
walletdb.cpp Merge #15710: wallet: Catch ios_base::failure specifically 2023-12-03 20:32:22 -06:00
walletdb.h Merge #18673: scripted-diff: Sort test includes 2023-08-29 22:00:59 -05:00
wallettool.cpp Merge #18673: scripted-diff: Sort test includes 2023-08-29 22:00:59 -05:00
wallettool.h merge bitcoin#19619: Remove wallet.dat path handling from wallet.cpp, rpcwallet.cpp 2022-10-17 08:03:10 +05:30
walletutil.cpp merge bitcoin#20275: List all wallets in non-SQLite and non-BDB builds 2023-02-07 10:53:33 -06:00
walletutil.h merge bitcoin#20275: List all wallets in non-SQLite and non-BDB builds 2023-02-07 10:53:33 -06:00