mirror of
https://github.com/dashpay/dash.git
synced 2024-12-27 04:52:59 +01:00
c3602372cc
* Don't rely on UTXO set in CheckCanLock The UTXO set only works for TXs in the mempool and won't work when we try to retroactively lock unlocked TXs from blocks. This is safe as ProcessTx is only called when a TX was accepted into the mempool or connected in a block, which means that all input checks were good. * Rename RetryLockMempoolTxs to RetryLockTxs and let it retry connected TXs * Instead of manually calling ProcessTx, let SyncTransaction handle all cases SyncTransaction is called from AcceptToMemoryPool and when transactions got connected in a block. So this is the time we want to run TXs through ProcessTx. This also enables retroactive signing of TXs that were unknown before a new block appeared. * Test retroactive signing and safe TXs in LLMQ ChainLocks tests * Also test for retroactive signing of chained TXs * Honor lockedParentTx when looking for TXs to retry signing * Stop scanning for TXs to retry after a depth of 6 * Generate 6 block to avoid retroactive signing overloading Travis * Avoid retroactive signing * Don't rely on NewPoWValidBlock and use SyncTransaction to build blockTxs NewPoWValidBlock is not guaranteed to be called when blocks come in fast. When a block is accepted in AcceptBlock, NewPoWValidBlock is only called when the new block is a successor of the currently active tip. This is not the case when after the first block a second block is accepted immediately as the first block is not connected yet. This might be a bug actually in the handling of NewPoWValidBlock, so we might need to check/fix this later, but currently I prefer to not touch that part. Instead, we now use SyncTransaction to gather TXs for blockTxs. This works because SyncTransaction is called for all transactions in a freshly connected block in one go. The call also happens before UpdatedBlockTip is called, so it's fine with the existing logic. * Use tx.IsCoinBase() instead of checking index 0 Also check for empty vin.
100 lines
3.7 KiB
Python
Executable File
100 lines
3.7 KiB
Python
Executable File
#!/usr/bin/env python3
|
|
# Copyright (c) 2018 The Dash Core developers
|
|
# Distributed under the MIT software license, see the accompanying
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
|
|
from test_framework.mininode import *
|
|
from test_framework.test_framework import DashTestFramework
|
|
from test_framework.util import *
|
|
from time import *
|
|
|
|
'''
|
|
p2p-autoinstantsend.py
|
|
|
|
Test automatic InstantSend locks functionality.
|
|
|
|
Checks that simple transactions automatically become InstantSend locked,
|
|
complex transactions don't become IS-locked and this functionality is
|
|
activated only if SPORK_16_INSTANTSEND_AUTOLOCKS is active.
|
|
|
|
Also checks that this functionality doesn't influence regular InstantSend
|
|
transactions with high fee.
|
|
'''
|
|
|
|
class AutoInstantSendTest(DashTestFramework):
|
|
def __init__(self):
|
|
super().__init__(8, 5, [], fast_dip3_enforcement=True)
|
|
# set sender, receiver, isolated nodes
|
|
self.receiver_idx = 1
|
|
self.sender_idx = 2
|
|
|
|
def run_test(self):
|
|
# make sure masternodes are synced
|
|
sync_masternodes(self.nodes)
|
|
|
|
self.nodes[0].spork("SPORK_17_QUORUM_DKG_ENABLED", 0)
|
|
self.wait_for_sporks_same()
|
|
self.mine_quorum()
|
|
|
|
self.log.info("Test old InstantSend")
|
|
self.test_auto();
|
|
|
|
# Generate 6 block to avoid retroactive signing overloading Travis
|
|
self.nodes[0].generate(6)
|
|
sync_blocks(self.nodes)
|
|
|
|
self.nodes[0].spork("SPORK_20_INSTANTSEND_LLMQ_BASED", 0)
|
|
self.wait_for_sporks_same()
|
|
|
|
self.log.info("Test new InstantSend")
|
|
self.test_auto(True);
|
|
|
|
def test_auto(self, new_is = False):
|
|
sender = self.nodes[self.sender_idx]
|
|
receiver = self.nodes[self.receiver_idx]
|
|
# feed the sender with some balance, make sure there are enough inputs
|
|
recipients = {}
|
|
for i in range(0, 30):
|
|
recipients[sender.getnewaddress()] = 1
|
|
# use a single transaction to not overload Travis with InstantSend
|
|
self.nodes[0].sendmany("", recipients)
|
|
|
|
# make sender funds mature for InstantSend
|
|
for i in range(0, 2):
|
|
set_mocktime(get_mocktime() + 1)
|
|
set_node_times(self.nodes, get_mocktime())
|
|
self.nodes[0].generate(1)
|
|
self.sync_all()
|
|
|
|
assert(not self.get_autois_spork_state(self.nodes[0]))
|
|
|
|
assert(self.send_regular_instantsend(sender, receiver, not new_is))
|
|
assert(self.send_simple_tx(sender, receiver) if new_is else not self.send_simple_tx(sender, receiver))
|
|
assert(self.send_complex_tx(sender, receiver) if new_is else not self.send_complex_tx(sender, receiver))
|
|
|
|
self.activate_autois_bip9(self.nodes[0])
|
|
self.set_autois_spork_state(self.nodes[0], True)
|
|
|
|
assert(self.get_autois_bip9_status(self.nodes[0]) == 'active')
|
|
assert(self.get_autois_spork_state(self.nodes[0]))
|
|
|
|
assert(self.send_regular_instantsend(sender, receiver, not new_is))
|
|
assert(self.send_simple_tx(sender, receiver))
|
|
assert(self.send_complex_tx(sender, receiver) if new_is else not self.send_complex_tx(sender, receiver))
|
|
|
|
self.set_autois_spork_state(self.nodes[0], False)
|
|
assert(not self.get_autois_spork_state(self.nodes[0]))
|
|
|
|
assert(self.send_regular_instantsend(sender, receiver, not new_is))
|
|
assert(self.send_simple_tx(sender, receiver) if new_is else not self.send_simple_tx(sender, receiver))
|
|
assert(self.send_complex_tx(sender, receiver) if new_is else not self.send_complex_tx(sender, receiver))
|
|
|
|
# mine all mempool txes
|
|
set_mocktime(get_mocktime() + 1)
|
|
set_node_times(self.nodes, get_mocktime())
|
|
self.nodes[0].generate(1)
|
|
self.sync_all()
|
|
|
|
if __name__ == '__main__':
|
|
AutoInstantSendTest().main()
|