mirror of
https://github.com/dashpay/dash.git
synced 2024-12-27 21:12:48 +01:00
c7a5be4d6b
fa1436c42 [qa] util: Remove unused sync_chain (MarcoFalke)
Pull request description:
The util function `sync_blocks` already checks for equal chains, so we can remove the unused `sync_chain`.
Also cleaned up the errors that are printed in case of timeout:
```
AssertionError: Block sync timed out:
'72a3a3e9dcfd0a09204c3447af0f481d19641eeadbe6a91b8e680ed614bc7712'
'5032af4ae22ae7a21afdc9d9f516877309c4dd8ef2ecadb9354be7088439b4a6'
'5032af4ae22ae7a21afdc9d9f516877309c4dd8ef2ecadb9354be7088439b4a6'
```
and
```
AssertionError: Mempool sync timed out:
{'c2af943d9b321c36e0f5a153a9d3d8b11bdd46ceb28e38f5fd2c722e3edb3563'}
set()
set()
```
Tree-SHA512: cb4ad30e3e3773072f59afa2c81cfa27bd8f389a93f02acb919990298627fcfbaa53a3d3944d827cc8a5d009871e42a47ea09e9bb93e85c22e3af6a24a574e5d
114 lines
4.9 KiB
Python
Executable File
114 lines
4.9 KiB
Python
Executable File
#!/usr/bin/env python3
|
|
# Copyright (c) 2015 The Bitcoin Core developers
|
|
# Distributed under the MIT software license, see the accompanying
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
"""Test the preciousblock RPC."""
|
|
|
|
from test_framework.test_framework import BitcoinTestFramework
|
|
from test_framework.util import (
|
|
assert_equal,
|
|
connect_nodes_bi,
|
|
sync_blocks,
|
|
)
|
|
|
|
def unidirectional_node_sync_via_rpc(node_src, node_dest):
|
|
blocks_to_copy = []
|
|
blockhash = node_src.getbestblockhash()
|
|
while True:
|
|
try:
|
|
assert(len(node_dest.getblock(blockhash, False)) > 0)
|
|
break
|
|
except:
|
|
blocks_to_copy.append(blockhash)
|
|
blockhash = node_src.getblockheader(blockhash, True)['previousblockhash']
|
|
blocks_to_copy.reverse()
|
|
for blockhash in blocks_to_copy:
|
|
blockdata = node_src.getblock(blockhash, False)
|
|
assert(node_dest.submitblock(blockdata) in (None, 'inconclusive'))
|
|
|
|
def node_sync_via_rpc(nodes):
|
|
for node_src in nodes:
|
|
for node_dest in nodes:
|
|
if node_src is node_dest:
|
|
continue
|
|
unidirectional_node_sync_via_rpc(node_src, node_dest)
|
|
|
|
class PreciousTest(BitcoinTestFramework):
|
|
def set_test_params(self):
|
|
self.setup_clean_chain = True
|
|
self.num_nodes = 3
|
|
|
|
def setup_network(self):
|
|
self.setup_nodes()
|
|
|
|
def run_test(self):
|
|
self.log.info("Ensure submitblock can in principle reorg to a competing chain")
|
|
self.nodes[0].generate(1)
|
|
assert_equal(self.nodes[0].getblockcount(), 1)
|
|
hashZ = self.nodes[1].generate(2)[-1]
|
|
assert_equal(self.nodes[1].getblockcount(), 2)
|
|
node_sync_via_rpc(self.nodes[0:3])
|
|
assert_equal(self.nodes[0].getbestblockhash(), hashZ)
|
|
|
|
self.log.info("Mine blocks A-B-C on Node 0")
|
|
hashC = self.nodes[0].generate(3)[-1]
|
|
assert_equal(self.nodes[0].getblockcount(), 5)
|
|
self.log.info("Mine competing blocks E-F-G on Node 1")
|
|
hashG = self.nodes[1].generate(3)[-1]
|
|
assert_equal(self.nodes[1].getblockcount(), 5)
|
|
assert(hashC != hashG)
|
|
self.log.info("Connect nodes and check no reorg occurs")
|
|
# Submit competing blocks via RPC so any reorg should occur before we proceed (no way to wait on inaction for p2p sync)
|
|
node_sync_via_rpc(self.nodes[0:2])
|
|
connect_nodes_bi(self.nodes,0,1)
|
|
assert_equal(self.nodes[0].getbestblockhash(), hashC)
|
|
assert_equal(self.nodes[1].getbestblockhash(), hashG)
|
|
self.log.info("Make Node0 prefer block G")
|
|
self.nodes[0].preciousblock(hashG)
|
|
assert_equal(self.nodes[0].getbestblockhash(), hashG)
|
|
self.log.info("Make Node0 prefer block C again")
|
|
self.nodes[0].preciousblock(hashC)
|
|
assert_equal(self.nodes[0].getbestblockhash(), hashC)
|
|
self.log.info("Make Node1 prefer block C")
|
|
self.nodes[1].preciousblock(hashC)
|
|
sync_blocks(self.nodes[0:2]) # wait because node 1 may not have downloaded hashC
|
|
assert_equal(self.nodes[1].getbestblockhash(), hashC)
|
|
self.log.info("Make Node1 prefer block G again")
|
|
self.nodes[1].preciousblock(hashG)
|
|
assert_equal(self.nodes[1].getbestblockhash(), hashG)
|
|
self.log.info("Make Node0 prefer block G again")
|
|
self.nodes[0].preciousblock(hashG)
|
|
assert_equal(self.nodes[0].getbestblockhash(), hashG)
|
|
self.log.info("Make Node1 prefer block C again")
|
|
self.nodes[1].preciousblock(hashC)
|
|
assert_equal(self.nodes[1].getbestblockhash(), hashC)
|
|
self.log.info("Mine another block (E-F-G-)H on Node 0 and reorg Node 1")
|
|
self.nodes[0].generate(1)
|
|
assert_equal(self.nodes[0].getblockcount(), 6)
|
|
self.sync_blocks(self.nodes[0:2])
|
|
hashH = self.nodes[0].getbestblockhash()
|
|
assert_equal(self.nodes[1].getbestblockhash(), hashH)
|
|
self.log.info("Node1 should not be able to prefer block C anymore")
|
|
self.nodes[1].preciousblock(hashC)
|
|
assert_equal(self.nodes[1].getbestblockhash(), hashH)
|
|
self.log.info("Mine competing blocks I-J-K-L on Node 2")
|
|
self.nodes[2].generate(4)
|
|
assert_equal(self.nodes[2].getblockcount(), 6)
|
|
hashL = self.nodes[2].getbestblockhash()
|
|
self.log.info("Connect nodes and check no reorg occurs")
|
|
node_sync_via_rpc(self.nodes[1:3])
|
|
connect_nodes_bi(self.nodes,1,2)
|
|
connect_nodes_bi(self.nodes,0,2)
|
|
assert_equal(self.nodes[0].getbestblockhash(), hashH)
|
|
assert_equal(self.nodes[1].getbestblockhash(), hashH)
|
|
assert_equal(self.nodes[2].getbestblockhash(), hashL)
|
|
self.log.info("Make Node1 prefer block L")
|
|
self.nodes[1].preciousblock(hashL)
|
|
assert_equal(self.nodes[1].getbestblockhash(), hashL)
|
|
self.log.info("Make Node2 prefer block H")
|
|
self.nodes[2].preciousblock(hashH)
|
|
assert_equal(self.nodes[2].getbestblockhash(), hashH)
|
|
|
|
if __name__ == '__main__':
|
|
PreciousTest().main()
|