mirror of
https://github.com/dashpay/dash.git
synced 2024-12-30 22:35:51 +01:00
3148450032
67f4e9c522 Include core_io.h from core_read.cpp (practicalswift)
eca9767673 Make reasoning about dependencies easier by not including unused dependencies (practicalswift)
Pull request description:
Make reasoning about dependencies easier by not including unused dependencies.
Please note that the removed headers are _not_ "transitively included" by other still included headers. Thus the removals are real.
As an added bonus this change means less work for the preprocessor/compiler. At least 51 393 lines of code no longer needs to be processed:
```
$ git diff -u HEAD~1 | grep -E '^\-#include ' | cut -f2 -d"<" | cut -f1 -d">" | \
sed 's%^%src/%g' | xargs cat | wc -l
51393
```
Note that 51 393 is the lower bound: the real number is likely much higher when taking into account transitively included headers :-)
ACKs for commit 67f4e9:
Tree-SHA512: 0c8868aac59813f099ce53d5307eed7962dd6f2ff3546768ef9e5c4508b87f8210f1a22c7e826c3c06bebbf28bdbfcf1628ed354c2d0fdb9a31a42cefb8fdf13
Co-authored-by: MarcoFalke <falke.marco@gmail.com>
78 lines
2.6 KiB
C++
78 lines
2.6 KiB
C++
// Copyright (c) 2009-2010 Satoshi Nakamoto
|
|
// Copyright (c) 2009-2016 The Bitcoin Core developers
|
|
// Distributed under the MIT software license, see the accompanying
|
|
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
|
|
#include <sync.h>
|
|
#include <util/system.h>
|
|
#include <warnings.h>
|
|
#include <hash.h>
|
|
|
|
static Mutex g_warnings_mutex;
|
|
static std::string strMiscWarning GUARDED_BY(g_warnings_mutex);
|
|
static bool fLargeWorkForkFound GUARDED_BY(g_warnings_mutex) = false;
|
|
static bool fLargeWorkInvalidChainFound GUARDED_BY(g_warnings_mutex) = false;
|
|
|
|
void SetMiscWarning(const std::string& strWarning)
|
|
{
|
|
LOCK(g_warnings_mutex);
|
|
strMiscWarning = strWarning;
|
|
}
|
|
|
|
void SetfLargeWorkForkFound(bool flag)
|
|
{
|
|
LOCK(g_warnings_mutex);
|
|
fLargeWorkForkFound = flag;
|
|
}
|
|
|
|
bool GetfLargeWorkForkFound()
|
|
{
|
|
LOCK(g_warnings_mutex);
|
|
return fLargeWorkForkFound;
|
|
}
|
|
|
|
void SetfLargeWorkInvalidChainFound(bool flag)
|
|
{
|
|
LOCK(g_warnings_mutex);
|
|
fLargeWorkInvalidChainFound = flag;
|
|
}
|
|
|
|
std::string GetWarnings(const std::string& strFor)
|
|
{
|
|
std::string strStatusBar;
|
|
std::string strGUI;
|
|
const std::string uiAlertSeparator = "<hr />";
|
|
|
|
LOCK(g_warnings_mutex);
|
|
|
|
if (!CLIENT_VERSION_IS_RELEASE) {
|
|
strStatusBar = "This is a pre-release test build - use at your own risk - do not use for mining or merchant applications";
|
|
strGUI = _("This is a pre-release test build - use at your own risk - do not use for mining or merchant applications");
|
|
}
|
|
|
|
// Misc warnings like out of disk space and clock is wrong
|
|
if (strMiscWarning != "")
|
|
{
|
|
strStatusBar = strMiscWarning;
|
|
strGUI += (strGUI.empty() ? "" : uiAlertSeparator) + strMiscWarning;
|
|
}
|
|
|
|
if (fLargeWorkForkFound)
|
|
{
|
|
strStatusBar = "Warning: The network does not appear to fully agree! Some miners appear to be experiencing issues.";
|
|
strGUI += (strGUI.empty() ? "" : uiAlertSeparator) + _("Warning: The network does not appear to fully agree! Some miners appear to be experiencing issues.");
|
|
}
|
|
else if (fLargeWorkInvalidChainFound)
|
|
{
|
|
strStatusBar = "Warning: We do not appear to fully agree with our peers! You may need to upgrade, or other nodes may need to upgrade.";
|
|
strGUI += (strGUI.empty() ? "" : uiAlertSeparator) + _("Warning: We do not appear to fully agree with our peers! You may need to upgrade, or other nodes may need to upgrade.");
|
|
}
|
|
|
|
if (strFor == "gui")
|
|
return strGUI;
|
|
else if (strFor == "statusbar")
|
|
return strStatusBar;
|
|
assert(!"GetWarnings(): invalid parameter");
|
|
return "error";
|
|
}
|