mirror of
https://github.com/dashpay/dash.git
synced 2024-12-25 12:02:48 +01:00
b6c8d852e3
a512925e19a70d7f6b80ac530a169f45ffaafa1c [doc] Release notes (Amiti Uttarwar) 50f94b34a33c954f6e207f509c93d33267a5c3e2 [rpc] Deprecate getpeerinfo addnode field (Amiti Uttarwar) df091b9b509f0b10e4315c0bfa2da0cc0c31c22f [refactor] Rename test file to allow any getpeerinfo deprecations. (Amiti Uttarwar) 395acfa83a5436790c1a722a5609ac9d48df235f [rpc] Add connection type to getpeerinfo RPC, update tests (Amiti Uttarwar) 49c10a9ca40967d28ae16dfea9cccc6f3a6624a1 [log] Add connection type to log statement (Amiti Uttarwar) Pull request description: After #19316, we can more directly expose information about the connection type on the `getpeerinfo` RPC. Doing so also makes the existing addnode field redundant, so this PR begins the process of deprecating this field. This PR also includes one commit that improves a log message, as both use a shared function to return the connection type as a string. Suggested by sdaftuar- https://github.com/bitcoin/bitcoin/pull/19316#discussion_r468001604 & https://github.com/bitcoin/bitcoin/pull/19316#discussion_r468018093 ACKs for top commit: jnewbery: Code review ACK a512925e19a70d7f6b80ac530a169f45ffaafa1c. sipa: utACK a512925e19a70d7f6b80ac530a169f45ffaafa1c guggero: Tested and code review ACK a512925e. MarcoFalke: cr ACK a512925e19a70d7f6b80ac530a169f45ffaafa1c 🌇 promag: Code review ACK a512925e19a70d7f6b80ac530a169f45ffaafa1c. Tree-SHA512: 601a7a38aee235ee59aca690784f886dc2ae4e418b2e6422c4b58cd597376c00f74910f66920b08a08a0bec28bf8022e71a1435785ff6ba8a188954261aba78e
39 lines
1.5 KiB
Python
Executable File
39 lines
1.5 KiB
Python
Executable File
#!/usr/bin/env python3
|
|
# Copyright (c) 2020 The Bitcoin Core developers
|
|
# Distributed under the MIT software license, see the accompanying
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
"""Test deprecation of getpeerinfo RPC fields."""
|
|
|
|
from test_framework.test_framework import BitcoinTestFramework
|
|
|
|
|
|
class GetpeerinfoDeprecationTest(BitcoinTestFramework):
|
|
def set_test_params(self):
|
|
self.num_nodes = 2
|
|
self.extra_args = [[], ["-deprecatedrpc=banscore"]]
|
|
|
|
def run_test(self):
|
|
self.test_banscore_deprecation()
|
|
self.test_addnode_deprecation()
|
|
|
|
def test_banscore_deprecation(self):
|
|
self.log.info("Test getpeerinfo by default no longer returns a banscore field")
|
|
assert "banscore" not in self.nodes[0].getpeerinfo()[0].keys()
|
|
|
|
self.log.info("Test getpeerinfo returns banscore with -deprecatedrpc=banscore")
|
|
assert "banscore" in self.nodes[1].getpeerinfo()[0].keys()
|
|
|
|
def test_addnode_deprecation(self):
|
|
self.restart_node(1, ["-deprecatedrpc=getpeerinfo_addnode"])
|
|
self.connect_nodes(0, 1)
|
|
|
|
self.log.info("Test getpeerinfo by default no longer returns an addnode field")
|
|
assert "addnode" not in self.nodes[0].getpeerinfo()[0].keys()
|
|
|
|
self.log.info("Test getpeerinfo returns addnode with -deprecatedrpc=addnode")
|
|
assert "addnode" in self.nodes[1].getpeerinfo()[0].keys()
|
|
|
|
|
|
if __name__ == "__main__":
|
|
GetpeerinfoDeprecationTest().main()
|