mirror of
https://github.com/dashpay/dash.git
synced 2024-12-26 12:32:48 +01:00
9f4f52ae4e
68400d8b96 tests: Use explicit imports (practicalswift) Pull request description: Enable automatic detection of undefined names in Python tests scripts. Remove wildcard imports. Wildcard imports make it unclear which names are present in the namespace, confusing both readers and many automated tools. An additional benefit of not using wildcard imports in tests scripts is that readers of a test script then can infer the rough testing scope just by looking at the imports. Before this commit: ``` $ contrib/devtools/lint-python.sh | head -10 ./test/functional/feature_rbf.py:8:1: F403 'from test_framework.util import *' used; unable to detect undefined names ./test/functional/feature_rbf.py:9:1: F403 'from test_framework.script import *' used; unable to detect undefined names ./test/functional/feature_rbf.py:10:1: F403 'from test_framework.mininode import *' used; unable to detect undefined names ./test/functional/feature_rbf.py:15:12: F405 bytes_to_hex_str may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util ./test/functional/feature_rbf.py:17:58: F405 CScript may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util ./test/functional/feature_rbf.py:25:13: F405 COIN may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util ./test/functional/feature_rbf.py:26:31: F405 satoshi_round may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util ./test/functional/feature_rbf.py:26:60: F405 COIN may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util ./test/functional/feature_rbf.py:30:41: F405 satoshi_round may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util ./test/functional/feature_rbf.py:30:68: F405 COIN may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util $ ``` After this commit: ``` $ contrib/devtools/lint-python.sh | head -10 $ ``` Tree-SHA512: 3f826d39cffb6438388e5efcb20a9622ff8238247e882d68f7b38609877421b2a8e10e9229575f8eb6a8fa42dec4256986692e92922c86171f750a0e887438d9
67 lines
3.2 KiB
Python
Executable File
67 lines
3.2 KiB
Python
Executable File
#!/usr/bin/env python3
|
|
# Copyright (c) 2014-2016 The Bitcoin Core developers
|
|
# Distributed under the MIT software license, see the accompanying
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
"""Test mempool limiting together/eviction with the wallet."""
|
|
|
|
from decimal import Decimal
|
|
|
|
from test_framework.test_framework import BitcoinTestFramework
|
|
from test_framework.util import assert_equal, assert_greater_than, assert_raises_rpc_error, create_confirmed_utxos, create_lots_of_big_transactions, gen_return_txouts
|
|
|
|
class MempoolLimitTest(BitcoinTestFramework):
|
|
def set_test_params(self):
|
|
self.setup_clean_chain = True
|
|
self.num_nodes = 1
|
|
self.extra_args = [["-maxmempool=5", "-spendzeroconfchange=0"]]
|
|
|
|
def run_test(self):
|
|
txouts = gen_return_txouts()
|
|
relayfee = self.nodes[0].getnetworkinfo()['relayfee']
|
|
|
|
self.log.info('Check that mempoolminfee is minrelytxfee')
|
|
assert_equal(self.nodes[0].getmempoolinfo()['minrelaytxfee'], Decimal('0.00001000'))
|
|
assert_equal(self.nodes[0].getmempoolinfo()['mempoolminfee'], Decimal('0.00001000'))
|
|
|
|
txids = []
|
|
utxos = create_confirmed_utxos(relayfee, self.nodes[0], 491)
|
|
|
|
self.log.info('Create a mempool tx that will be evicted')
|
|
us0 = utxos.pop()
|
|
inputs = [{ "txid" : us0["txid"], "vout" : us0["vout"]}]
|
|
outputs = {self.nodes[0].getnewaddress() : 0.0001}
|
|
tx = self.nodes[0].createrawtransaction(inputs, outputs)
|
|
self.nodes[0].settxfee(relayfee) # specifically fund this tx with low fee
|
|
txF = self.nodes[0].fundrawtransaction(tx)
|
|
self.nodes[0].settxfee(0) # return to automatic fee selection
|
|
txFS = self.nodes[0].signrawtransactionwithwallet(txF['hex'])
|
|
txid = self.nodes[0].sendrawtransaction(txFS['hex'])
|
|
|
|
relayfee = self.nodes[0].getnetworkinfo()['relayfee']
|
|
base_fee = relayfee*100
|
|
for i in range (3):
|
|
txids.append([])
|
|
txids[i] = create_lots_of_big_transactions(self.nodes[0], txouts, utxos[30*i:30*i+30], 30, (i+1)*base_fee)
|
|
|
|
self.log.info('The tx should be evicted by now')
|
|
assert(txid not in self.nodes[0].getrawmempool())
|
|
txdata = self.nodes[0].gettransaction(txid)
|
|
assert(txdata['confirmations'] == 0) #confirmation should still be 0
|
|
|
|
self.log.info('Check that mempoolminfee is larger than minrelytxfee')
|
|
assert_equal(self.nodes[0].getmempoolinfo()['minrelaytxfee'], Decimal('0.00001000'))
|
|
assert_greater_than(self.nodes[0].getmempoolinfo()['mempoolminfee'], Decimal('0.00001000'))
|
|
|
|
self.log.info('Create a mempool tx that will not pass mempoolminfee')
|
|
us0 = utxos.pop()
|
|
inputs = [{ "txid" : us0["txid"], "vout" : us0["vout"]}]
|
|
outputs = {self.nodes[0].getnewaddress() : 0.0001}
|
|
tx = self.nodes[0].createrawtransaction(inputs, outputs)
|
|
# specifically fund this tx with a fee < mempoolminfee, >= than minrelaytxfee
|
|
txF = self.nodes[0].fundrawtransaction(tx, {'feeRate': relayfee})
|
|
txFS = self.nodes[0].signrawtransactionwithwallet(txF['hex'])
|
|
assert_raises_rpc_error(-26, "mempool min fee not met", self.nodes[0].sendrawtransaction, txFS['hex'])
|
|
|
|
if __name__ == '__main__':
|
|
MempoolLimitTest().main()
|