mirror of
https://github.com/dashpay/dash.git
synced 2024-12-26 12:32:48 +01:00
9f4f52ae4e
68400d8b96 tests: Use explicit imports (practicalswift) Pull request description: Enable automatic detection of undefined names in Python tests scripts. Remove wildcard imports. Wildcard imports make it unclear which names are present in the namespace, confusing both readers and many automated tools. An additional benefit of not using wildcard imports in tests scripts is that readers of a test script then can infer the rough testing scope just by looking at the imports. Before this commit: ``` $ contrib/devtools/lint-python.sh | head -10 ./test/functional/feature_rbf.py:8:1: F403 'from test_framework.util import *' used; unable to detect undefined names ./test/functional/feature_rbf.py:9:1: F403 'from test_framework.script import *' used; unable to detect undefined names ./test/functional/feature_rbf.py:10:1: F403 'from test_framework.mininode import *' used; unable to detect undefined names ./test/functional/feature_rbf.py:15:12: F405 bytes_to_hex_str may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util ./test/functional/feature_rbf.py:17:58: F405 CScript may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util ./test/functional/feature_rbf.py:25:13: F405 COIN may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util ./test/functional/feature_rbf.py:26:31: F405 satoshi_round may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util ./test/functional/feature_rbf.py:26:60: F405 COIN may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util ./test/functional/feature_rbf.py:30:41: F405 satoshi_round may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util ./test/functional/feature_rbf.py:30:68: F405 COIN may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util $ ``` After this commit: ``` $ contrib/devtools/lint-python.sh | head -10 $ ``` Tree-SHA512: 3f826d39cffb6438388e5efcb20a9622ff8238247e882d68f7b38609877421b2a8e10e9229575f8eb6a8fa42dec4256986692e92922c86171f750a0e887438d9
77 lines
3.2 KiB
Python
Executable File
77 lines
3.2 KiB
Python
Executable File
#!/usr/bin/env python3
|
|
# Copyright (c) 2014-2016 The Bitcoin Core developers
|
|
# Distributed under the MIT software license, see the accompanying
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
"""Test longpolling with getblocktemplate."""
|
|
|
|
from decimal import Decimal
|
|
|
|
from test_framework.test_framework import BitcoinTestFramework
|
|
from test_framework.util import get_rpc_proxy, random_transaction, wait_until
|
|
|
|
import threading
|
|
|
|
class LongpollThread(threading.Thread):
|
|
def __init__(self, node):
|
|
threading.Thread.__init__(self)
|
|
# query current longpollid
|
|
templat = node.getblocktemplate()
|
|
self.longpollid = templat['longpollid']
|
|
# create a new connection to the node, we can't use the same
|
|
# connection from two threads
|
|
self.node = get_rpc_proxy(node.url, 1, timeout=600, coveragedir=node.coverage_dir)
|
|
|
|
def run(self):
|
|
self.node.getblocktemplate({'longpollid':self.longpollid})
|
|
|
|
class GetBlockTemplateLPTest(BitcoinTestFramework):
|
|
def set_test_params(self):
|
|
self.num_nodes = 2
|
|
|
|
def run_test(self):
|
|
self.log.info("Warning: this test will take about 70 seconds in the best case. Be patient.")
|
|
self.nodes[0].generate(10)
|
|
templat = self.nodes[0].getblocktemplate()
|
|
longpollid = templat['longpollid']
|
|
# longpollid should not change between successive invocations if nothing else happens
|
|
templat2 = self.nodes[0].getblocktemplate()
|
|
assert(templat2['longpollid'] == longpollid)
|
|
|
|
# Test 1: test that the longpolling wait if we do nothing
|
|
thr = LongpollThread(self.nodes[0])
|
|
thr.start()
|
|
# check that thread still lives
|
|
thr.join(5) # wait 5 seconds or until thread exits
|
|
assert(thr.is_alive())
|
|
|
|
# Test 2: test that longpoll will terminate if another node generates a block
|
|
self.nodes[1].generate(1) # generate a block on another node
|
|
# check that thread will exit now that new transaction entered mempool
|
|
thr.join(5) # wait 5 seconds or until thread exits
|
|
assert(not thr.is_alive())
|
|
|
|
# Test 3: test that longpoll will terminate if we generate a block ourselves
|
|
thr = LongpollThread(self.nodes[0])
|
|
thr.start()
|
|
self.nodes[0].generate(1) # generate a block on another node
|
|
thr.join(5) # wait 5 seconds or until thread exits
|
|
assert(not thr.is_alive())
|
|
|
|
# Test 4: test that introducing a new transaction into the mempool will terminate the longpoll
|
|
thr = LongpollThread(self.nodes[0])
|
|
thr.start()
|
|
# generate a random transaction and submit it
|
|
min_relay_fee = self.nodes[0].getnetworkinfo()["relayfee"]
|
|
# min_relay_fee is fee per 1000 bytes, which should be more than enough.
|
|
(txid, txhex, fee) = random_transaction(self.nodes, Decimal("1.1"), min_relay_fee, Decimal("0.001"), 20)
|
|
# after one minute, every 10 seconds the mempool is probed, so in 80 seconds it should have returned
|
|
|
|
def check():
|
|
self.bump_mocktime(1)
|
|
return not thr.is_alive()
|
|
wait_until(check, timeout=60 + 20, sleep=1)
|
|
|
|
if __name__ == '__main__':
|
|
GetBlockTemplateLPTest().main()
|
|
|