mirror of
https://github.com/dashpay/dash.git
synced 2024-12-27 04:52:59 +01:00
4a3e3af6e7
fa0074e2d82928016a43ca408717154a1c70a4db scripted-diff: Bump copyright headers (MarcoFalke) Pull request description: Needs to be done because no one has removed the years yet ACKs for top commit: practicalswift: ACK fa0074e2d82928016a43ca408717154a1c70a4db Tree-SHA512: 210e92acd7d400b556cf8259c3ec9967797420cfd19f0c2a4fa54cb2b3d32ad9ae27e771269201e7d554c0f4cd73a8b1c1a42c9f65d8685ca4d52e5134b071a3
35 lines
1.1 KiB
Bash
Executable File
35 lines
1.1 KiB
Bash
Executable File
#!/usr/bin/env bash
|
|
#
|
|
# Copyright (c) 2018-2020 The Bitcoin Core developers
|
|
# Distributed under the MIT software license, see the accompanying
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
#
|
|
# Check for assertions with obvious side effects.
|
|
|
|
export LC_ALL=C
|
|
|
|
EXIT_CODE=0
|
|
|
|
# PRE31-C (SEI CERT C Coding Standard):
|
|
# "Assertions should not contain assignments, increment, or decrement operators."
|
|
OUTPUT=$(git grep -E '[^_]assert\(.*(\+\+|\-\-|[^=!<>]=[^=!<>]).*\);' -- "*.cpp" "*.h")
|
|
if [[ ${OUTPUT} != "" ]]; then
|
|
echo "Assertions should not have side effects:"
|
|
echo
|
|
echo "${OUTPUT}"
|
|
EXIT_CODE=1
|
|
fi
|
|
|
|
# Macro CHECK_NONFATAL(condition) should be used instead of assert for RPC code, where it
|
|
# is undesirable to crash the whole program. See: src/util/check.h
|
|
# src/rpc/server.cpp is excluded from this check since it's mostly meta-code.
|
|
OUTPUT=$(git grep -nE '\<(A|a)ssert *\(.*\);' -- "src/rpc/" "src/wallet/rpc*" ":(exclude)src/rpc/server.cpp")
|
|
if [[ ${OUTPUT} != "" ]]; then
|
|
echo "CHECK_NONFATAL(condition) should be used instead of assert for RPC code."
|
|
echo
|
|
echo "${OUTPUT}"
|
|
EXIT_CODE=1
|
|
fi
|
|
|
|
exit ${EXIT_CODE}
|