mirror of
https://github.com/dashpay/dash.git
synced 2024-12-25 20:12:57 +01:00
a0c8c9f0a5
## Issue being fixed or feature implemented fix: possible assert call if nHeight in CDeterministicMNListDiff is higher than Tip Example of new log: ``` 2023-09-28T17:35:50Z GetProjectedMNPayeesAtChainTip WARNING pindex is nullptr due to height=914160 chain height=914159 ``` instead assert call: ``` ... #6 0x00007ffff7a33b86 in __assert_fail (assertion=0x55555783afd2 "pindex", file=0x5555577f2ed8 "llmq/utils.cpp", line=730, function=0x5555577f2448 "bool llmq::utils::IsMNRewardReallocationActive(const CBlockIndex*)") at ./assert/assert.c:101 #7 0x0000555555ab7daf in llmq::utils::IsMNRewardReallocationActive (pindex=<optimized out>) at llmq/utils.cpp:730 #8 0x00005555559458ad in CDeterministicMNList::GetProjectedMNPayees (this=this@entry=0x7fffffffc690, pindex=0x0, nCount=<optimized out>, nCount@entry=2147483647) at evo/deterministicmns.cpp:231 #9 0x000055555594614f in CDeterministicMNList::GetProjectedMNPayeesAtChainTip (this=this@entry=0x7fffffffc690, nCount=nCount@entry=2147483647) at evo/deterministicmns.cpp:216 #10 0x00005555558c9f51 in MasternodeList::updateDIP3List (this=this@entry=0x55555908cfd0) at qt/masternodelist.cpp:194 #11 0x00005555558ca9a0 in MasternodeList::updateDIP3ListScheduled (this=0x55555908cfd0) at qt/masternodelist.cpp:157 #12 0x000055555684a60f in void doActivate<false>(QObject*, int, void**) () #13 0x00005555568525b1 in QTimer::timerEvent(QTimerEvent*) () #14 0x0000555556844ce5 in QObject::event(QEvent*) () #15 0x0000555556ac3252 in QApplicationPrivate::notify_helper(QObject*, QEvent*) () #16 0x000055555681e6b8 in QCoreApplication::sendEvent(QObject*, QEvent*) () #17 0x000055555686de2a in QTimerInfoList::activateTimers() () #18 0x000055555686be84 in QEventDispatcherUNIX::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) () #19 0x00005555569bf8a2 in QXcbUnixEventDispatcher::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) () #20 0x000055555681caf6 in QEventLoop::exec(QFlags<QEventLoop::ProcessEventsFlag>) () #21 0x0000555556825f8a in QCoreApplication::exec() () ... ``` ## What was done? ClientModel returns now a pair: MNList and CBlockIndex; so, we always know the which one has been used even if current chain is switched. ## How Has This Been Tested? Run on my localhost from `c034ff0c2606142ba3e8894bc74f693b87374e5c` - aborted with backtrace like above. With both of commit - no assert more. ## Breaking Changes N/A ## Checklist: - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [ ] I have made corresponding changes to the documentation - [x] I have assigned this pull request to a milestone --------- Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>
140 lines
5.4 KiB
C++
140 lines
5.4 KiB
C++
// Copyright (c) 2010 Satoshi Nakamoto
|
|
// Copyright (c) 2012-2020 The Bitcoin Core developers
|
|
// Distributed under the MIT software license, see the accompanying
|
|
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
|
|
#ifndef BITCOIN_UI_INTERFACE_H
|
|
#define BITCOIN_UI_INTERFACE_H
|
|
|
|
#include <functional>
|
|
#include <memory>
|
|
#include <string>
|
|
|
|
class CBlockIndex;
|
|
struct bilingual_str;
|
|
|
|
class CDeterministicMNList;
|
|
|
|
namespace boost {
|
|
namespace signals2 {
|
|
class connection;
|
|
}
|
|
} // namespace boost
|
|
|
|
/** General change type (added, updated, removed). */
|
|
enum ChangeType
|
|
{
|
|
CT_NEW,
|
|
CT_UPDATED,
|
|
CT_DELETED
|
|
};
|
|
|
|
/** Signals for UI communication. */
|
|
class CClientUIInterface
|
|
{
|
|
public:
|
|
/** Flags for CClientUIInterface::ThreadSafeMessageBox */
|
|
enum MessageBoxFlags
|
|
{
|
|
ICON_INFORMATION = 0,
|
|
ICON_WARNING = (1U << 0),
|
|
ICON_ERROR = (1U << 1),
|
|
/**
|
|
* Mask of all available icons in CClientUIInterface::MessageBoxFlags
|
|
* This needs to be updated, when icons are changed there!
|
|
*/
|
|
ICON_MASK = (ICON_INFORMATION | ICON_WARNING | ICON_ERROR),
|
|
|
|
/** These values are taken from qmessagebox.h "enum StandardButton" to be directly usable */
|
|
BTN_OK = 0x00000400U, // QMessageBox::Ok
|
|
BTN_YES = 0x00004000U, // QMessageBox::Yes
|
|
BTN_NO = 0x00010000U, // QMessageBox::No
|
|
BTN_ABORT = 0x00040000U, // QMessageBox::Abort
|
|
BTN_RETRY = 0x00080000U, // QMessageBox::Retry
|
|
BTN_IGNORE = 0x00100000U, // QMessageBox::Ignore
|
|
BTN_CLOSE = 0x00200000U, // QMessageBox::Close
|
|
BTN_CANCEL = 0x00400000U, // QMessageBox::Cancel
|
|
BTN_DISCARD = 0x00800000U, // QMessageBox::Discard
|
|
BTN_HELP = 0x01000000U, // QMessageBox::Help
|
|
BTN_APPLY = 0x02000000U, // QMessageBox::Apply
|
|
BTN_RESET = 0x04000000U, // QMessageBox::Reset
|
|
/**
|
|
* Mask of all available buttons in CClientUIInterface::MessageBoxFlags
|
|
* This needs to be updated, when buttons are changed there!
|
|
*/
|
|
BTN_MASK = (BTN_OK | BTN_YES | BTN_NO | BTN_ABORT | BTN_RETRY | BTN_IGNORE |
|
|
BTN_CLOSE | BTN_CANCEL | BTN_DISCARD | BTN_HELP | BTN_APPLY | BTN_RESET),
|
|
|
|
/** Force blocking, modal message box dialog (not just OS notification) */
|
|
MODAL = 0x10000000U,
|
|
|
|
/** Do not print contents of message to debug log */
|
|
SECURE = 0x40000000U,
|
|
|
|
/** Predefined combinations for certain default usage cases */
|
|
MSG_INFORMATION = ICON_INFORMATION,
|
|
MSG_WARNING = (ICON_WARNING | BTN_OK | MODAL),
|
|
MSG_ERROR = (ICON_ERROR | BTN_OK | MODAL)
|
|
};
|
|
|
|
#define ADD_SIGNALS_DECL_WRAPPER(signal_name, rtype, args...) \
|
|
rtype signal_name(args); \
|
|
using signal_name##Sig = rtype(args); \
|
|
boost::signals2::connection signal_name##_connect(std::function<signal_name##Sig> fn);
|
|
|
|
/** Show message box. */
|
|
ADD_SIGNALS_DECL_WRAPPER(ThreadSafeMessageBox, bool, const bilingual_str& message, const std::string& caption, unsigned int style);
|
|
|
|
/** If possible, ask the user a question. If not, falls back to ThreadSafeMessageBox(noninteractive_message, caption, style) and returns false. */
|
|
ADD_SIGNALS_DECL_WRAPPER(ThreadSafeQuestion, bool, const bilingual_str& message, const std::string& noninteractive_message, const std::string& caption, unsigned int style);
|
|
|
|
/** Progress message during initialization. */
|
|
ADD_SIGNALS_DECL_WRAPPER(InitMessage, void, const std::string& message);
|
|
|
|
/** Number of network connections changed. */
|
|
ADD_SIGNALS_DECL_WRAPPER(NotifyNumConnectionsChanged, void, int newNumConnections);
|
|
|
|
/** Network activity state changed. */
|
|
ADD_SIGNALS_DECL_WRAPPER(NotifyNetworkActiveChanged, void, bool networkActive);
|
|
|
|
/**
|
|
* Status bar alerts changed.
|
|
*/
|
|
ADD_SIGNALS_DECL_WRAPPER(NotifyAlertChanged, void, );
|
|
|
|
/**
|
|
* Show progress e.g. for verifychain.
|
|
* resume_possible indicates shutting down now will result in the current progress action resuming upon restart.
|
|
*/
|
|
ADD_SIGNALS_DECL_WRAPPER(ShowProgress, void, const std::string& title, int nProgress, bool resume_possible);
|
|
|
|
/** New block has been accepted */
|
|
ADD_SIGNALS_DECL_WRAPPER(NotifyBlockTip, void, bool, const CBlockIndex*);
|
|
|
|
/** New chainlock block has been accepted */
|
|
ADD_SIGNALS_DECL_WRAPPER(NotifyChainLock, void, const std::string& bestChainLockHash, int bestChainLockHeight);
|
|
|
|
/** Best header has changed */
|
|
ADD_SIGNALS_DECL_WRAPPER(NotifyHeaderTip, void, bool, const CBlockIndex*);
|
|
|
|
/** Masternode list has changed */
|
|
ADD_SIGNALS_DECL_WRAPPER(NotifyMasternodeListChanged, void, const CDeterministicMNList&, const CBlockIndex*);
|
|
|
|
/** Additional data sync progress changed */
|
|
ADD_SIGNALS_DECL_WRAPPER(NotifyAdditionalDataSyncProgressChanged, void, double nSyncProgress);
|
|
|
|
/** Banlist did change. */
|
|
ADD_SIGNALS_DECL_WRAPPER(BannedListChanged, void, void);
|
|
};
|
|
|
|
/** Show warning message **/
|
|
void InitWarning(const bilingual_str& str);
|
|
|
|
/** Show error message **/
|
|
bool InitError(const bilingual_str& str);
|
|
inline bool AbortError(const bilingual_str& str) { return InitError(str); }
|
|
|
|
extern CClientUIInterface uiInterface;
|
|
|
|
#endif // BITCOIN_UI_INTERFACE_H
|