mirror of
https://github.com/dashpay/dash.git
synced 2024-12-25 20:12:57 +01:00
106ca023a0
a3abeec33a6ae903e514c7a7b6f587b7c17288a0 policy/fees: remove a floating-point division by zero (Antoine Poinsot)
c36869bbf6a38626833b4aea53be024c48ede475 policy/fees: unify some duplicated for loops (Antoine Poinsot)
569d92a4d2924a1f6d50775980b591552f6372e7 policy/fees: small readability improvements (Antoine Poinsot)
5b8cb35621891b681f9b49a9de5f6d8da4ccdecc policy/fee: remove requireGreater parameter in EstimateMedianVal() (Antoine Poinsot)
dba8196b447b6a85be66890db70928100e867d8b policy/fees: correct decay explanation comments (Antoine Poinsot)
Pull request description:
This (*does not* change behaviour and) cleans up a bit of unused code in `CBlockPolicyEstimator` and friends, and slightly improves readability of the rest (comment correction etc.). The last commit is a small reformatting one which I could not resist but am happy to remove at will.
ACKs for top commit:
jnewbery:
utACK a3abeec33a6ae903e514c7a7b6f587b7c17288a0
MarcoFalke:
ACK a3abeec33a6ae903e514c7a7b6f587b7c17288a0 💹
ariard:
Code Review ACK a3abeec.
Tree-SHA512: b7620bcd23a2ffa8f7ed859467868fc0f6488279e3ee634f6d408872cb866ad086a037e8ace76599a05b7e9c07768adf5016b0ae782d153196b9c030db4c34a5
87 lines
4.0 KiB
Plaintext
87 lines
4.0 KiB
Plaintext
# -fsanitize=undefined suppressions
|
|
# =================================
|
|
float-divide-by-zero:validation.cpp
|
|
float-divide-by-zero:wallet/wallet.cpp
|
|
|
|
# -fsanitize=integer suppressions
|
|
# ===============================
|
|
# Unsigned integer overflow occurs when the result of an unsigned integer
|
|
# computation cannot be represented in its type. Unlike signed integer overflow,
|
|
# this is not undefined behavior, but it is often unintentional. The list below
|
|
# contains files in which we expect unsigned integer overflows to occur. The
|
|
# list is used to suppress -fsanitize=integer warnings when running our CI UBSan
|
|
# job.
|
|
unsigned-integer-overflow:*/include/c++/*/bits/basic_string.tcc
|
|
unsigned-integer-overflow:arith_uint256.h
|
|
unsigned-integer-overflow:basic_string.h
|
|
unsigned-integer-overflow:bench/bench.h
|
|
unsigned-integer-overflow:bitcoin-tx.cpp
|
|
unsigned-integer-overflow:bloom.cpp
|
|
unsigned-integer-overflow:chain.cpp
|
|
unsigned-integer-overflow:chain.h
|
|
unsigned-integer-overflow:coded_stream.h
|
|
unsigned-integer-overflow:core_write.cpp
|
|
unsigned-integer-overflow:crypto/chacha20.cpp
|
|
unsigned-integer-overflow:crypto/ctaes/ctaes.c
|
|
unsigned-integer-overflow:crypto/ripemd160.cpp
|
|
unsigned-integer-overflow:crypto/sha1.cpp
|
|
unsigned-integer-overflow:crypto/sha256.cpp
|
|
unsigned-integer-overflow:crypto/sha512.cpp
|
|
unsigned-integer-overflow:hash.cpp
|
|
unsigned-integer-overflow:leveldb/db/log_reader.cc
|
|
unsigned-integer-overflow:leveldb/util/bloom.cc
|
|
unsigned-integer-overflow:leveldb/util/crc32c.h
|
|
unsigned-integer-overflow:leveldb/util/hash.cc
|
|
unsigned-integer-overflow:policy/fees.cpp
|
|
unsigned-integer-overflow:prevector.h
|
|
unsigned-integer-overflow:script/interpreter.cpp
|
|
unsigned-integer-overflow:stl_bvector.h
|
|
unsigned-integer-overflow:txmempool.cpp
|
|
unsigned-integer-overflow:util/strencodings.cpp
|
|
unsigned-integer-overflow:validation.cpp
|
|
# std::variant warning fixed in https://github.com/gcc-mirror/gcc/commit/074436cf8cdd2a9ce75cadd36deb8301f00e55b9
|
|
implicit-unsigned-integer-truncation:std::__detail::__variant::_Variant_storage
|
|
vptr:bls/bls.h
|
|
|
|
implicit-integer-sign-change:*/include/c++/*/bits/*.h
|
|
implicit-integer-sign-change:*/new_allocator.h
|
|
implicit-integer-sign-change:/usr/include/boost/date_time/format_date_parser.hpp
|
|
implicit-integer-sign-change:arith_uint256.cpp
|
|
implicit-integer-sign-change:bech32.cpp
|
|
implicit-integer-sign-change:bloom.cpp
|
|
implicit-integer-sign-change:chain.*
|
|
implicit-integer-sign-change:coins.h
|
|
implicit-integer-sign-change:compat/stdin.cpp
|
|
implicit-integer-sign-change:compressor.h
|
|
implicit-integer-sign-change:crypto/*
|
|
implicit-integer-sign-change:key.cpp
|
|
implicit-integer-sign-change:noui.cpp
|
|
implicit-integer-sign-change:prevector.h
|
|
implicit-integer-sign-change:protocol.cpp
|
|
implicit-integer-sign-change:script/bitcoinconsensus.cpp
|
|
implicit-integer-sign-change:script/interpreter.cpp
|
|
implicit-integer-sign-change:serialize.h
|
|
implicit-integer-sign-change:test/arith_uint256_tests.cpp
|
|
implicit-integer-sign-change:test/coins_tests.cpp
|
|
implicit-integer-sign-change:test/pow_tests.cpp
|
|
implicit-integer-sign-change:test/prevector_tests.cpp
|
|
implicit-integer-sign-change:test/sighash_tests.cpp
|
|
implicit-integer-sign-change:test/streams_tests.cpp
|
|
implicit-integer-sign-change:test/transaction_tests.cpp
|
|
implicit-integer-sign-change:txmempool.cpp
|
|
implicit-integer-sign-change:util/strencodings.*
|
|
implicit-integer-sign-change:validation.cpp
|
|
implicit-integer-sign-change:zmq/zmqpublishnotifier.cpp
|
|
implicit-signed-integer-truncation,implicit-integer-sign-change:chain.h
|
|
implicit-signed-integer-truncation,implicit-integer-sign-change:test/skiplist_tests.cpp
|
|
implicit-signed-integer-truncation:chain.h
|
|
implicit-signed-integer-truncation:crypto/*
|
|
implicit-signed-integer-truncation:cuckoocache.h
|
|
implicit-signed-integer-truncation:leveldb/*
|
|
implicit-signed-integer-truncation:streams.h
|
|
implicit-signed-integer-truncation:test/arith_uint256_tests.cpp
|
|
implicit-signed-integer-truncation:test/skiplist_tests.cpp
|
|
implicit-signed-integer-truncation:torcontrol.cpp
|
|
implicit-unsigned-integer-truncation:crypto/*
|
|
implicit-unsigned-integer-truncation:leveldb/*
|