mirror of
https://github.com/dashpay/dash.git
synced 2024-12-28 13:32:47 +01:00
a9ce72a8bb
fa9b60c842 Remove unused TransactionError constants (MarcoFalke) Pull request description: Fixup to #14978, which introduced a bunch of unused enum values, such as `UNKNOWN_ERROR`, `ERROR_COUNT` and `TRANSACTION_ERR_LAST`. None of those have a meaning in the context of an `enum class`, where the compiler can infer if all cases have been covered in a switch-case. Also, move the global `::maxTxFee` back to the rpc caller, so it can be set on a per call basis (in the future). Tree-SHA512: 7f1e2d795f1c1278ecd54ddab2b92c2a862f3c637b482d1d008208925befa1c9dd4b3c4bb1bfcbc5ca4b66a41004aaf01ea96ea95236f944250b8a6cf99ff173
102 lines
3.7 KiB
C++
102 lines
3.7 KiB
C++
// Copyright (c) 2010 Satoshi Nakamoto
|
|
// Copyright (c) 2009-2018 The Bitcoin Core developers
|
|
// Distributed under the MIT software license, see the accompanying
|
|
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
|
|
#include <consensus/validation.h>
|
|
#include <net.h>
|
|
#include <txmempool.h>
|
|
#include <validation.h>
|
|
#include <validationinterface.h>
|
|
#include <node/transaction.h>
|
|
#include <util/validation.h>
|
|
|
|
#include <future>
|
|
|
|
std::string TransactionErrorString(const TransactionError err)
|
|
{
|
|
switch (err) {
|
|
case TransactionError::OK:
|
|
return "No error";
|
|
case TransactionError::MISSING_INPUTS:
|
|
return "Missing inputs";
|
|
case TransactionError::ALREADY_IN_CHAIN:
|
|
return "Transaction already in block chain";
|
|
case TransactionError::P2P_DISABLED:
|
|
return "Peer-to-peer functionality missing or disabled";
|
|
case TransactionError::MEMPOOL_REJECTED:
|
|
return "Transaction rejected by AcceptToMemoryPool";
|
|
case TransactionError::MEMPOOL_ERROR:
|
|
return "AcceptToMemoryPool failed";
|
|
case TransactionError::INVALID_PSBT:
|
|
return "PSBT is not sane";
|
|
case TransactionError::PSBT_MISMATCH:
|
|
return "PSBTs not compatible (different transactions)";
|
|
case TransactionError::SIGHASH_MISMATCH:
|
|
return "Specified sighash value does not match existing value";
|
|
// no default case, so the compiler can warn about missing cases
|
|
}
|
|
assert(false);
|
|
}
|
|
|
|
TransactionError BroadcastTransaction(const CTransactionRef tx, uint256& hashTx, std::string& err_string, const CAmount& highfee, const bool bypass_limits)
|
|
{
|
|
std::promise<void> promise;
|
|
hashTx = tx->GetHash();
|
|
|
|
{ // cs_main scope
|
|
LOCK(cs_main);
|
|
CCoinsViewCache &view = *pcoinsTip;
|
|
bool fHaveChain = false;
|
|
for (size_t o = 0; !fHaveChain && o < tx->vout.size(); o++) {
|
|
const Coin& existingCoin = view.AccessCoin(COutPoint(hashTx, o));
|
|
fHaveChain = !existingCoin.IsSpent();
|
|
}
|
|
bool fHaveMempool = mempool.exists(hashTx);
|
|
if (!fHaveMempool && !fHaveChain) {
|
|
// push to local node and sync with wallets
|
|
CValidationState state;
|
|
bool fMissingInputs;
|
|
if (!AcceptToMemoryPool(mempool, state, std::move(tx), &fMissingInputs,
|
|
bypass_limits, highfee)) {
|
|
if (state.IsInvalid()) {
|
|
err_string = FormatStateMessage(state);
|
|
return TransactionError::MEMPOOL_REJECTED;
|
|
} else {
|
|
if (fMissingInputs) {
|
|
return TransactionError::MISSING_INPUTS;
|
|
}
|
|
err_string = FormatStateMessage(state);
|
|
return TransactionError::MEMPOOL_ERROR;
|
|
}
|
|
} else {
|
|
// If wallet is enabled, ensure that the wallet has been made aware
|
|
// of the new transaction prior to returning. This prevents a race
|
|
// where a user might call sendrawtransaction with a transaction
|
|
// to/from their wallet, immediately call some wallet RPC, and get
|
|
// a stale result because callbacks have not yet been processed.
|
|
CallFunctionInValidationInterfaceQueue([&promise] {
|
|
promise.set_value();
|
|
});
|
|
}
|
|
} else if (fHaveChain) {
|
|
return TransactionError::ALREADY_IN_CHAIN;
|
|
} else {
|
|
// Make sure we don't block forever if re-sending
|
|
// a transaction already in mempool.
|
|
promise.set_value();
|
|
}
|
|
|
|
} // cs_main
|
|
|
|
promise.get_future().wait();
|
|
|
|
if (!g_connman) {
|
|
return TransactionError::P2P_DISABLED;
|
|
}
|
|
|
|
g_connman->RelayTransaction(*tx);
|
|
|
|
return TransactionError::OK;
|
|
}
|