dash/src/consensus
MarcoFalke a9f50ea944 Merge #19069: refactor: replace pointers by references within tx_verify.{h,cpp}
b00266fe0cf05fe6044f471105ce2bfed4349626 refactor: replace pointers by references within tx_verify.{h,cpp} (Sebastian Falbesoner)

Pull request description:

  This PR gets rid of another unnecessary use of raw pointers, similar to PR #19053 (see also issue #19062 where useful commands for finding potential candidates are listed) but in the tx verification module.

  For the functions `CalculateSequenceLocks()` and `SequenceLocks()`, the  `prevHeights` vector parameter type is changed to be passed as a reference. Note that there were no checks for null pointers -- if one would pass `nullptr` to one of the functions, the following line would immediately lead to a crash:
  dcacea096e/src/consensus/tx_verify.cpp (L32)

ACKs for top commit:
  Empact:
    Code Review ACK b00266fe0c

Tree-SHA512: 0eb71591467905434082029128bdca4df94988c372af40dca325654f6c002c72a00c73776cb5e72d6de2b2f218649211a5dbf19300a2e01f1841d6034e0f01e0
2023-01-01 20:16:57 -06:00
..
consensus.h Refactor the hardening of DIP 1 (#3874) 2020-12-15 15:54:51 -06:00
merkle.cpp Merge #16129: refactor: Remove unused includes (#4623) 2022-01-03 13:10:02 -06:00
merkle.h Merge #16659: refactoring: Remove unused includes 2021-12-12 16:44:54 -05:00
params.h feat!: v19 BIP9 fork (#5070) 2022-11-22 11:34:21 -06:00
tx_check.cpp merge bitcoin#15141: Rewrite DoS interface between validation and net_processing 2022-06-21 19:11:26 +05:30
tx_check.h merge bitcoin#15638: Pull wallet code out of libbitcoin_server (#4560) 2021-11-16 10:19:47 -05:00
tx_verify.cpp Merge #19069: refactor: replace pointers by references within tx_verify.{h,cpp} 2023-01-01 20:16:57 -06:00
tx_verify.h Merge #19069: refactor: replace pointers by references within tx_verify.{h,cpp} 2023-01-01 20:16:57 -06:00
validation.h merge bitcoin#15141: Rewrite DoS interface between validation and net_processing 2022-06-21 19:11:26 +05:30