mirror of
https://github.com/dashpay/dash.git
synced 2024-12-27 04:52:59 +01:00
c0c5d05419
41d55d30579358c805036201664ad6a1c1d48681 doc: getpeerinfo banscore deprecation release note (Jon Atack) dd54e3796e633cfdf6954af306afd26eadc25116 test: getpeerinfo banscore deprecation test (Jon Atack) 8c7647b3fbbab03ea84071cf3cd2d0d2bf8be255 rpc: deprecate banscore field in rpc getpeerinfo (Jon Atack) Pull request description: Per https://github.com/bitcoin/bitcoin/pull/19219#discussion_r443074487 and https://github.com/bitcoin/bitcoin/pull/19219#issuecomment-652699592, this PR deprecates returning the `banscore` field in the `getpeerinfo` RPC, updates the help, adds a test, and updates the release notes. Related to #19464. ACKs for top commit: fanquake: ACK 41d55d30579358c805036201664ad6a1c1d48681 Tree-SHA512: 8eca08332581e2fe191a2aafff6ba89ce39413f0491ed0de8b86577739f0ec430b1a8fbff2914b0f3138a229563dfcc1981c0cf5b7dd6061b5c48680a28423bc
25 lines
932 B
Python
Executable File
25 lines
932 B
Python
Executable File
#!/usr/bin/env python3
|
|
# Copyright (c) 2020 The Bitcoin Core developers
|
|
# Distributed under the MIT software license, see the accompanying
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
"""Test deprecation of getpeerinfo RPC banscore field."""
|
|
|
|
from test_framework.test_framework import BitcoinTestFramework
|
|
|
|
|
|
class GetpeerinfoBanscoreDeprecationTest(BitcoinTestFramework):
|
|
def set_test_params(self):
|
|
self.num_nodes = 2
|
|
self.extra_args = [[], ["-deprecatedrpc=banscore"]]
|
|
|
|
def run_test(self):
|
|
self.log.info("Test getpeerinfo by default no longer returns a banscore field")
|
|
assert "banscore" not in self.nodes[0].getpeerinfo()[0].keys()
|
|
|
|
self.log.info("Test getpeerinfo returns banscore with -deprecatedrpc=banscore")
|
|
assert "banscore" in self.nodes[1].getpeerinfo()[0].keys()
|
|
|
|
|
|
if __name__ == "__main__":
|
|
GetpeerinfoBanscoreDeprecationTest().main()
|