ac40ed7800
In my ever-growing list of test failures, I was seeing this one intermittently. ``` Running 2nd level testscript pruning.py... Initializing test directory /tmp/testY5ypCv Warning! This test requires 4GB of disk space and takes over 30 mins (up to 2 hours) Mining a big blockchain of 995 blocks Check that we haven't started pruning yet because we're below PruneAfterHeight Success Though we're already using more than 550MB, current usage: 587 Mining 25 more blocks should cause the first block file to be pruned Assertion failed: blk00000.dat not pruned when it should be File "/home/error/bitcoinxt-0.11D/qa/rpc-tests/test_framework/test_framework.py", line 118, in main self.run_test() File "/home/error/bitcoinxt-0.11D/qa/rpc-tests/pruning.py", line 272, in run_test self.test_height_min() File "/home/error/bitcoinxt-0.11D/qa/rpc-tests/pruning.py", line 94, in test_height_min raise AssertionError("blk00000.dat not pruned when it should be") Stopping nodes Failed ``` After digging into the test, I found that the code is waiting 10 seconds for blk00000.dat to be deleted, and then throwing this failure if it still exists after 10 seconds. I increased this amount, had the script print the actual time taken, and ran the test a few more times. The time taken ranged between 8 to 12 seconds. So, I feel that this timeout is too short. After changing the timeout to 30 seconds, the test passes consistently. (cherry picked from commit 3469911c89a48dd2fefe4d1c2a0c176256e14ee0) |
||
---|---|---|
.. | ||
test_framework | ||
.gitignore | ||
abandonconflict.py | ||
bip9-softforks.py | ||
bip65-cltv-p2p.py | ||
bip65-cltv.py | ||
bip68-112-113-p2p.py | ||
bip68-sequence.py | ||
bipdersig-p2p.py | ||
bipdersig.py | ||
blockchain.py | ||
decodescript.py | ||
disablewallet.py | ||
forknotify.py | ||
fundrawtransaction.py | ||
getblocktemplate_longpoll.py | ||
getblocktemplate_proposals.py | ||
getchaintips.py | ||
httpbasics.py | ||
importprunedfunds.py | ||
invalidateblock.py | ||
invalidblockrequest.py | ||
invalidtxrequest.py | ||
keypool.py | ||
listtransactions.py | ||
maxblocksinflight.py | ||
maxuploadtarget.py | ||
mempool_limit.py | ||
mempool_packages.py | ||
mempool_reorg.py | ||
mempool_resurrect_test.py | ||
mempool_spendcoinbase.py | ||
merkle_blocks.py | ||
multi_rpc.py | ||
nodehandling.py | ||
p2p-acceptblock.py | ||
p2p-feefilter.py | ||
p2p-fullblocktest.py | ||
p2p-versionbits-warning.py | ||
prioritise_transaction.py | ||
proxy_test.py | ||
pruning.py | ||
rawtransactions.py | ||
README.md | ||
receivedby.py | ||
reindex.py | ||
replace-by-fee.py | ||
rest.py | ||
rpcbind_test.py | ||
sendheaders.py | ||
signmessages.py | ||
signrawtransactions.py | ||
smartfees.py | ||
txn_clone.py | ||
txn_doublespend.py | ||
wallet.py | ||
walletbackup.py | ||
zapwallettxes.py | ||
zmq_test.py |
Regression tests
test_framework/authproxy.py
Taken from the python-bitcoinrpc repository.
test_framework/test_framework.py
Base class for new regression tests.
test_framework/util.py
Generally useful functions.
test_framework/mininode.py
Basic code to support p2p connectivity to a bitcoind.
test_framework/comptool.py
Framework for comparison-tool style, p2p tests.
test_framework/script.py
Utilities for manipulating transaction scripts (originally from python-bitcoinlib)
test_framework/blockstore.py
Implements disk-backed block and tx storage.
test_framework/key.py
Wrapper around OpenSSL EC_Key (originally from python-bitcoinlib)
test_framework/bignum.py
Helpers for script.py
test_framework/blocktools.py
Helper functions for creating blocks and transactions.
P2P test design notes
Mininode
-
mininode.py
contains all the definitions for objects that pass over the network (CBlock
,CTransaction
, etc, along with the network-level wrappers for them,msg_block
,msg_tx
, etc). -
P2P tests have two threads. One thread handles all network communication with the bitcoind(s) being tested (using python's asyncore package); the other implements the test logic.
-
NodeConn
is the class used to connect to a bitcoind. If you implement a callback class that derives fromNodeConnCB
and pass that to theNodeConn
object, your code will receive the appropriate callbacks when events of interest arrive. -
You can pass the same handler to multiple
NodeConn
's if you like, or pass different ones to each -- whatever makes the most sense for your test. -
Call
NetworkThread.start()
after allNodeConn
objects are created to start the networking thread. (Continue with the test logic in your existing thread.) -
RPC calls are available in p2p tests.
-
Can be used to write free-form tests, where specific p2p-protocol behavior is tested. Examples:
p2p-accept-block.py
,maxblocksinflight.py
.
Comptool
-
Testing framework for writing tests that compare the block/tx acceptance behavior of a bitcoind against 1 or more other bitcoind instances, or against known outcomes, or both.
-
Set the
num_nodes
variable (defined inComparisonTestFramework
) to start up 1 or more nodes. If using 1 node, then--testbinary
can be used as a command line option to change the bitcoind binary used by the test. If using 2 or more nodes, then--refbinary
can be optionally used to change the bitcoind that will be used on nodes 2 and up. -
Implement a (generator) function called
get_tests()
which yieldsTestInstance
s. EachTestInstance
consists of:- a list of
[object, outcome, hash]
entriesobject
is aCBlock
,CTransaction
, orCBlockHeader
.CBlock
's andCTransaction
's are tested for acceptance.CBlockHeader
s can be used so that the test runner can deliver complete headers-chains when requested from the bitcoind, to allow writing tests where blocks can be delivered out of order but still processed by headers-first bitcoind's.outcome
isTrue
,False
, orNone
. IfTrue
orFalse
, the tip is compared with the expected tip -- either the block passed in, or the hash specified as the optional 3rd entry. IfNone
is specified, then the test will compare all the bitcoind's being tested to see if they all agree on what the best tip is.hash
is the block hash of the tip to compare against. Optional to specify; if left out then the hash of the block passed in will be used as the expected tip. This allows for specifying an expected tip while testing the handling of either invalid blocks or blocks delivered out of order, which complete a longer chain.
sync_every_block
:True/False
. IfFalse
, then all blocks are inv'ed together, and the test runner waits until the node receives the last one, and tests only the last block for tip acceptance using the outcome and specified tip. IfTrue
, then each block is tested in sequence and synced (this is slower when processing many blocks).sync_every_transaction
:True/False
. Analogous tosync_every_block
, except if the outcome on the last tx is "None", then the contents of the entire mempool are compared across all bitcoind connections. IfTrue
orFalse
, then only the last tx's acceptance is tested against the given outcome.
- a list of
-
For examples of tests written in this framework, see
invalidblockrequest.py
andp2p-fullblocktest.py
.