mirror of
https://github.com/dashpay/dash.git
synced 2024-12-25 20:12:57 +01:00
4101fea620
fa6e6a3f03a38f8b431bf694268ed344d1815b3b doc: Remove confusing assert linter (MarcoFalke) Pull request description: The `assert()` documentation and linter are redundant and confusing: * The source code already refuses to compile with `assert()` disabled. * They violate the assumptions about `Assert()`, which *requires* side effects. * The existing linter doesn't enforce the guideline, only checking for `++` and `--` side effects. Fix all issues by removing the docs and the linter. See also https://github.com/bitcoin/bitcoin/pull/26684#discussion_r1287370102 Going forward everyone is free to use whatever code in this regard they think is the easiest to read. Also, everyone is still free to share style-nits, if they think it is a good use of their time and of the pull request author. Finally, the author is still free to dismiss or ignore this style-nit, or any other style-nit. ACKs for top commit: hebasto: ACK fa6e6a3f03a38f8b431bf694268ed344d1815b3b, I have reviewed the code and it looks OK. theStack: ACK fa6e6a3f03a38f8b431bf694268ed344d1815b3b Tree-SHA512: 686738d71e1316cc95e5d3f71869b55a02bfb137c795cc0875057f4410e564bc8eff03c985a2087b007fb08fc84551c7da1e8b30c7a9c3f2b14e5e44a5970236
43 lines
1.2 KiB
Python
Executable File
43 lines
1.2 KiB
Python
Executable File
#!/usr/bin/env python3
|
|
#
|
|
# Copyright (c) 2018-2022 The Bitcoin Core developers
|
|
# Distributed under the MIT software license, see the accompanying
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
#
|
|
# Check for assertions with obvious side effects.
|
|
|
|
import sys
|
|
import subprocess
|
|
|
|
|
|
def git_grep(params: [], error_msg: ""):
|
|
try:
|
|
output = subprocess.check_output(["git", "grep", *params], universal_newlines=True, encoding="utf8")
|
|
print(error_msg)
|
|
print(output)
|
|
return 1
|
|
except subprocess.CalledProcessError as ex1:
|
|
if ex1.returncode > 1:
|
|
raise ex1
|
|
return 0
|
|
|
|
|
|
def main():
|
|
# Aborting the whole process is undesirable for RPC code. So nonfatal
|
|
# checks should be used over assert. See: src/util/check.h
|
|
# src/rpc/server.cpp is excluded from this check since it's mostly meta-code.
|
|
exit_code = git_grep([
|
|
"-nE",
|
|
r"\<(A|a)ss(ume|ert) *\(.*\);",
|
|
"--",
|
|
"src/rpc/",
|
|
"src/wallet/rpc*",
|
|
":(exclude)src/rpc/server.cpp",
|
|
], "CHECK_NONFATAL(condition) or NONFATAL_UNREACHABLE should be used instead of assert for RPC code.")
|
|
|
|
sys.exit(exit_code)
|
|
|
|
|
|
if __name__ == "__main__":
|
|
main()
|