mirror of
https://github.com/dashpay/dash.git
synced 2024-12-30 22:35:51 +01:00
ae01429338
a4765bd77f9bc5c4d5c866ee6940807522741941 gui: Ensure tx send error highlight is visible (bpay) Pull request description: Rebased and squashed #14956. > If sending to multiple recipients and one of the recipient fields is malformed, the highlighted field may not be visible due to being scrolled out of view. This results in a confusing lack of error feedback. > Avoid this problem by ensuring the first field containing an error is scrolled into view when Send is clicked. You can see the behavior here: https://imgur.com/a/QZG5TQc How to test: Add a few recipients and give any of them an invalid address or amount. Scroll the invalid recipient out of view and hit Send. With this change, the GUI will scroll to show the invalid recipient, with master it will not, "hiding" the error. ACKs for top commit: jonatack: Tested ACK a4765bd77f9bc5c4d5c866ee6940807522741941 on Linux Debian with Qt 5.11.3. Change is that I had added an inadvertent typo in my make bash alias; fixed. hebasto: ACK a4765bd77f9bc5c4d5c866ee6940807522741941, tested on Debian 9.9 with system Qt 5.7.1. Tree-SHA512: a5653ca44d6d540214bdb424b0b75a06a5872cff41b0cd8cffd9cef99ebf04a17a3652e561139ac75315b39c3347e5f7ae304fa35e14b48bdae4768a416df9b0 |
||
|---|---|---|
| .. | ||
| forms | ||
| locale | ||
| res | ||
| test | ||
| addressbookpage.cpp | ||
| addressbookpage.h | ||
| addresstablemodel.cpp | ||
| addresstablemodel.h | ||
| appearancewidget.cpp | ||
| appearancewidget.h | ||
| askpassphrasedialog.cpp | ||
| askpassphrasedialog.h | ||
| bantablemodel.cpp | ||
| bantablemodel.h | ||
| bitcoinaddressvalidator.cpp | ||
| bitcoinaddressvalidator.h | ||
| bitcoinamountfield.cpp | ||
| bitcoinamountfield.h | ||
| bitcoingui.cpp | ||
| bitcoingui.h | ||
| bitcoinunits.cpp | ||
| bitcoinunits.h | ||
| callback.h | ||
| clientmodel.cpp | ||
| clientmodel.h | ||
| coincontroldialog.cpp | ||
| coincontroldialog.h | ||
| coincontroltreewidget.cpp | ||
| coincontroltreewidget.h | ||
| csvmodelwriter.cpp | ||
| csvmodelwriter.h | ||
| dash_locale.qrc | ||
| dash.cpp | ||
| dash.qrc | ||
| dashstrings.cpp | ||
| editaddressdialog.cpp | ||
| editaddressdialog.h | ||
| guiconstants.h | ||
| guiutil.cpp | ||
| guiutil.h | ||
| intro.cpp | ||
| intro.h | ||
| macdockiconhandler.h | ||
| macdockiconhandler.mm | ||
| macnotificationhandler.h | ||
| macnotificationhandler.mm | ||
| macos_appnap.h | ||
| macos_appnap.mm | ||
| masternodelist.cpp | ||
| masternodelist.h | ||
| modaloverlay.cpp | ||
| modaloverlay.h | ||
| networkstyle.cpp | ||
| networkstyle.h | ||
| notificator.cpp | ||
| notificator.h | ||
| openuridialog.cpp | ||
| openuridialog.h | ||
| optionsdialog.cpp | ||
| optionsdialog.h | ||
| optionsmodel.cpp | ||
| optionsmodel.h | ||
| overviewpage.cpp | ||
| overviewpage.h | ||
| paymentrequest.proto | ||
| paymentrequestplus.cpp | ||
| paymentrequestplus.h | ||
| paymentserver.cpp | ||
| paymentserver.h | ||
| peertablemodel.cpp | ||
| peertablemodel.h | ||
| qrdialog.cpp | ||
| qrdialog.h | ||
| qvalidatedlineedit.cpp | ||
| qvalidatedlineedit.h | ||
| qvaluecombobox.cpp | ||
| qvaluecombobox.h | ||
| README.md | ||
| receivecoinsdialog.cpp | ||
| receivecoinsdialog.h | ||
| receiverequestdialog.cpp | ||
| receiverequestdialog.h | ||
| recentrequeststablemodel.cpp | ||
| recentrequeststablemodel.h | ||
| rpcconsole.cpp | ||
| rpcconsole.h | ||
| sendcoinsdialog.cpp | ||
| sendcoinsdialog.h | ||
| sendcoinsentry.cpp | ||
| sendcoinsentry.h | ||
| signverifymessagedialog.cpp | ||
| signverifymessagedialog.h | ||
| splashscreen.cpp | ||
| splashscreen.h | ||
| trafficgraphdata.cpp | ||
| trafficgraphdata.h | ||
| trafficgraphwidget.cpp | ||
| trafficgraphwidget.h | ||
| transactiondesc.cpp | ||
| transactiondesc.h | ||
| transactiondescdialog.cpp | ||
| transactiondescdialog.h | ||
| transactionfilterproxy.cpp | ||
| transactionfilterproxy.h | ||
| transactionrecord.cpp | ||
| transactionrecord.h | ||
| transactiontablemodel.cpp | ||
| transactiontablemodel.h | ||
| transactionview.cpp | ||
| transactionview.h | ||
| utilitydialog.cpp | ||
| utilitydialog.h | ||
| walletframe.cpp | ||
| walletframe.h | ||
| walletmodel.cpp | ||
| walletmodel.h | ||
| walletmodeltransaction.cpp | ||
| walletmodeltransaction.h | ||
| walletview.cpp | ||
| walletview.h | ||
| winshutdownmonitor.cpp | ||
| winshutdownmonitor.h | ||
This directory contains the DashQT graphical user interface (GUI). It uses the cross-platform framework Qt.
The current precise version for Qt 5 is specified in qt.mk. Qt 4 is not supported.
Compile and run
See build instructions (macOS, Windows, Unix, etc).
To run:
./src/qt/dash-qt
Files and directories
forms
Contains Designer UI files. They are created with Qt Creator, but can be edited using any text editor.
locale
Contains translations. They are periodically updated. The process is described here.
res
Resources such as the icon.
test
Tests.
bitcoingui.(h/cpp)
Represents the main window of the Dash UI.
*model.(h/cpp)
The model. When it has a corresponding controller, it generally inherits from QAbstractTableModel. Models that are used by controllers as helpers inherit from other Qt classes like QValidator.
ClientModel is used by the main application bitcoingui and several models like peertablemodel.
*page.(h/cpp)
A controller. :NAMEpage.cpp generally includes :NAMEmodel.h and forms/:NAME.page.ui with a similar :NAME.
*dialog.(h/cpp)
Various dialogs, e.g. to open a URL. Inherit from QDialog.
paymentserver.(h/cpp)
Used to process BIP21 and BIP70 (see https://github.com/bitcoin/bitcoin/pull/11622) payment URI / requests. Also handles URI based application switching (e.g. when following a dash:... link from a browser).
walletview.(h/cpp)
Represents the view to a single wallet.
Other .h/cpp files
- UI elements like BitcoinAmountField, which inherit from QWidget.
bitcoinstrings.cpp: automatically generatedbitcoinunits.(h/cpp): BTC / mBTC / etc handlingcallback.hguiconstants.h: UI colors, app name, etcguiutil.h: several helper functionsmacdockiconhandler.(h/cpp)macdockiconhandler.(h/cpp): display notifications in macOS
Contribute
See CONTRIBUTING.md for general guidelines. Specifically for Qt:
- don't change
local/dash_en.ts; this happens automatically
Using Qt Creator as IDE
You can use Qt Creator as an IDE. This is especially useful if you want to change the UI layout.
Download and install the community edition of Qt Creator. Uncheck everything except Qt Creator during the installation process.
Instructions for macOS:
- Make sure you installed everything through Homebrew mentioned in the macOS build instructions
- Use
./configurewith the--enable-debugflag - In Qt Creator do "New Project" -> Import Project -> Import Existing Project
- Enter "dash-qt" as project name, enter src/qt as location
- Leave the file selection as it is
- Confirm the "summary page"
- In the "Projects" tab select "Manage Kits..."
- Select the default "Desktop" kit and select "Clang (x86 64bit in /usr/bin)" as compiler
- Select LLDB as debugger (you might need to set the path to your installation)
- Start debugging with Qt Creator (you might need to the executable to "dash-qt" under "Run", which is where you can also add command line arguments)