dash/src/script
MarcoFalke 9ada13f974
Merge #19508: Work around memory-aliasing in descriptor ParsePubkey
fa2ae0ac8d43086430a29c73940ad6b1cd129e96 span: Add Span::empty() and use it in script/descriptor (MarcoFalke)
fa8a99258947a9ee3749fa472180542920cd471c Work around memory-aliasing in descriptor ParsePubkey (MarcoFalke)

Pull request description:

  While this is not undefined behaviour, the memory aliasing trick is confusing when reading the code. Having `a.size()==0` and then access `a[0]` works in this particular case, but should probably be avoided to harden the code for the future.

ACKs for top commit:
  theStack:
    re-ACK fa2ae0ac8d
  elichai:
    ACK fa2ae0ac8d43086430a29c73940ad6b1cd129e96
  jonatack:
    ACK fa2ae0ac8d43086430a29c73940ad6b1cd129e96

Tree-SHA512: 0ec7b09eef45504973a195923cdf1aa8522117c8e2f69b453e5ce9aa8a7e327c71138518022c32d05133dc99cb861101ed0f60fa891814ee3e9dab3a6fa61a84
2023-01-23 12:22:31 -06:00
..
bitcoinconsensus.cpp revert dash#1432: Rename consensus source library and API 2022-08-09 14:16:28 +05:30
bitcoinconsensus.h trivial: revert dashification of header guards 2022-08-09 14:16:29 +05:30
descriptor.cpp Merge #19508: Work around memory-aliasing in descriptor ParsePubkey 2023-01-23 12:22:31 -06:00
descriptor.h Merge #17945: doc: Fix doxygen errors 2022-10-17 15:41:14 -05:00
interpreter.cpp merge bitcoin#20016: 1 is a constant 2022-07-02 23:47:42 +05:30
interpreter.h partial bitcoin#19953: Keep spent outputs in PrecomputedTransactionData 2022-03-24 09:27:25 +05:30
keyorigin.h Bitcoin backport #16227 refactoring CWallet (#4903) 2022-07-12 22:46:31 -05:00
script_error.cpp Merge #18412: script: fix SCRIPT_ERR_SIG_PUSHONLY error string 2021-07-13 21:19:48 -05:00
script_error.h Merge #11423: [Policy] Several transaction standardness rules 2021-06-05 22:13:01 +03:00
script.cpp 16659 continuation 2021-12-17 12:02:16 -05:00
script.h Merge #18612: script: Remove undocumented and unused operator+ 2022-09-16 19:22:13 +05:30
sigcache.cpp merge bitcoin#20581: Don't make "in" parameters look like "out"/"in-out" parameters: pass by ref to const instead of ref to non-const 2022-10-17 08:03:12 +05:30
sigcache.h Backport 11651 (#3358) 2020-03-20 01:46:56 +03:00
sign.cpp Merge #19114 TxoutType C++11 scoped enum class 2023-01-19 23:37:39 -06:00
sign.h partial bitcoin#18115: Pass in transactions and messages for signing instead of exporting the private keys 2022-10-17 07:57:14 +05:30
signingprovider.cpp Merge #17260: Split some CWallet functions into new LegacyScriptPubKeyMan (#4938) 2022-08-08 11:05:21 -05:00
signingprovider.h Merge #17260: Split some CWallet functions into new LegacyScriptPubKeyMan (#4938) 2022-08-08 11:05:21 -05:00
standard.cpp Merge #19114 TxoutType C++11 scoped enum class 2023-01-19 23:37:39 -06:00
standard.h Merge #19114 TxoutType C++11 scoped enum class 2023-01-19 23:37:39 -06:00