9fc7ffaac9
5bad7921d0b33b62c0a59a478c2e8c869fc5e3b5 [test] PSBT RPC: check that bip32_derivs are present by default (Sjors Provoost)
29a21c90610aed88b796a7a5900e42e9048b990e [rpc] set default bip32derivs to true for psbt methods (Sjors Provoost)
Pull request description:
In https://github.com/bitcoin/bitcoin/pull/13557#pullrequestreview-135905054 I recommended not including bip32 deriviation by default in PSBTs:
> _Bit of a privacy issue_: let's say person A and B are about to spend from a multisig address, sending everything to person A. Person A gives their address to person B, their wallet wallet creates a PSBT, but doesn't sign it. Wallet A then calls `walletprocesspsbt` which signs it and _spontaneously adds the master_fingerprint and bip32 path_. Same issue with `walletcreatefundedpsbt`.
>
> Adding `bip32_derivs` should probably be opt-in.
In practice I find this default quite annoying because I forget it and end up with a confused hardware wallet.
More importantly, in the multisig example I provided, it's actually essential for the other side to know the derivation details (in addition to an xpub). This allows them to check that change is going to an address you can still co-sign for (because the spending policy is unchanged except for an index).
ACKs for top commit:
instagibbs:
utACK
|
||
---|---|---|
.. | ||
gitian-building | ||
man | ||
release-notes | ||
.gitignore | ||
assets-attribution.md | ||
benchmarking.md | ||
bips.md | ||
bitcoin_logo_doxygen.png | ||
build-cross.md | ||
build-generic.md | ||
build-netbsd.md | ||
build-osx.md | ||
build-unix.md | ||
build-windows.md | ||
dash-conf.md | ||
descriptors.md | ||
developer-notes.md | ||
dnsseed-policy.md | ||
Doxyfile.in | ||
files.md | ||
fuzzing.md | ||
gitian-building.md | ||
init.md | ||
instantsend.md | ||
JSON-RPC-interface.md | ||
masternode-budget.md | ||
productivity.md | ||
psbt.md | ||
README_doxygen.md | ||
README_windows.txt | ||
README.md | ||
reduce-memory.md | ||
reduce-traffic.md | ||
release-notes-5017.md | ||
release-notes-15454.md | ||
release-notes-17264.md | ||
release-notes.md | ||
release-process.md | ||
REST-interface.md | ||
shared-libraries.md | ||
tor.md | ||
translation_process.md | ||
translation_strings_policy.md | ||
travis-ci.md | ||
zmq.md |
Dash Core
This is the official reference wallet for Dash digital currency and comprises the backbone of the Dash peer-to-peer network. You can download Dash Core or build it yourself using the guides below.
Running
The following are some helpful notes on how to run Dash Core on your native platform.
Unix
Unpack the files into a directory and run:
bin/dash-qt
(GUI) orbin/dashd
(headless)
Windows
Unpack the files into a directory, and then run dash-qt.exe.
macOS
Drag Dash Core to your applications folder, and then run Dash Core.
Need Help?
- See the Dash documentation for help and more information.
- Ask for help on Dash Discord
- Ask for help on the Dash Forum
Building
The following are developer notes on how to build Dash Core on your native platform. They are not complete guides, but include notes on the necessary libraries, compile flags, etc.
- macOS Build Notes
- Unix Build Notes
- Windows Build Notes
- OpenBSD Build Notes
- NetBSD Build Notes
- Gitian Building Guide
Development
The Dash Core repo's root README contains relevant information on the development process and automated testing.
- Developer Notes
- Productivity Notes
- Release Notes
- Release Process
- Source Code Documentation TODO
- Translation Process
- Translation Strings Policy
- Travis CI
- JSON-RPC Interface
- Unauthenticated REST Interface
- Shared Libraries
- BIPS
- Dnsseed Policy
- Benchmarking
Resources
- See the Dash Developer Documentation for technical specifications and implementation details.
- Discuss on the Dash Forum, in the Development & Technical Discussion board.
- Discuss on Dash Discord
- Discuss on Dash Developers Discord
Miscellaneous
- Assets Attribution
- dash.conf Configuration File
- Files
- Fuzz-testing
- Reduce Memory
- Reduce Traffic
- Tor Support
- Init Scripts (systemd/upstart/openrc)
- ZMQ
- PSBT support
License
Distributed under the MIT software license.