db4c8cf41e
a47df13471e3168e2e02023fb20cdf2414141b36 [qa] Test disconnect block failure -> shutdown (Suhas Daftuar) 4433ed0f730cfd60eeba3694ff3c283ce2c0c8ee [validation] Crash if disconnecting a block fails (Suhas Daftuar) Pull request description: If we're unable to disconnect a block during normal operation, then that is a failure of our local system (such as disk failure) or the chain that we are on (eg CVE-2018-17144), but cannot be due to failure of the (more work) chain that we're trying to validate. We should abort rather than stay on a less work chain. Fixes #14341. ACKs for top commit: practicalswift: utACK a47df13471e3168e2e02023fb20cdf2414141b36 TheBlueMatt: utACK a47df13471e3168e2e02023fb20cdf2414141b36. Didn't bother to review the test in detail, it looked fine. Debated whether invalidateblock should ever crash the node, but *not* crashing in the case of hitting a pruned block (which is the only change here) is clearly better, even if there are other cases I'd argue we should crash in. ryanofsky: utACK a47df13471e3168e2e02023fb20cdf2414141b36. Only change since last review is new comment. promag: ACK a47df1347, it takes awhile to quit (RPC connection timeouts) but that's unrelated - hope to fix that soon. fanquake: ACK a47df13471e3168e2e02023fb20cdf2414141b36 Tree-SHA512: 4dec8cef6e7dbbe513c138fc5821a7ceab855e603ece3c16185b51a3830ab7ebbc844a28827bf64e75326f45325991dcb672f13bd7baede53304f27289c4af8d |
||
---|---|---|
.. | ||
data | ||
test_framework | ||
.gitignore | ||
combine_logs.py | ||
combined_log_template.html | ||
create_cache.py | ||
example_test.py | ||
feature_abortnode.py | ||
feature_addressindex.py | ||
feature_asmap.py | ||
feature_assumevalid.py | ||
feature_bip68_sequence.py | ||
feature_block_reward_reallocation.py | ||
feature_block.py | ||
feature_blocksdir.py | ||
feature_cltv.py | ||
feature_config_args.py | ||
feature_csv_activation.py | ||
feature_dbcrash.py | ||
feature_dersig.py | ||
feature_dip3_deterministicmns.py | ||
feature_dip4_coinbasemerkleroots.py | ||
feature_dip0020_activation.py | ||
feature_fee_estimation.py | ||
feature_governance_objects.py | ||
feature_help.py | ||
feature_includeconf.py | ||
feature_llmq_chainlocks.py | ||
feature_llmq_connections.py | ||
feature_llmq_data_recovery.py | ||
feature_llmq_dkgerrors.py | ||
feature_llmq_is_cl_conflicts.py | ||
feature_llmq_is_retroactive.py | ||
feature_llmq_signing.py | ||
feature_llmq_simplepose.py | ||
feature_logging.py | ||
feature_maxuploadtarget.py | ||
feature_minchainwork.py | ||
feature_multikeysporks.py | ||
feature_new_quorum_type_activation.py | ||
feature_notifications.py | ||
feature_nulldummy.py | ||
feature_proxy.py | ||
feature_pruning.py | ||
feature_reindex.py | ||
feature_shutdown.py | ||
feature_spentindex.py | ||
feature_sporks.py | ||
feature_timestampindex.py | ||
feature_txindex.py | ||
feature_uacomment.py | ||
feature_versionbits_warning.py | ||
interface_bitcoin_cli.py | ||
interface_http.py | ||
interface_rest.py | ||
interface_zmq_dash.py | ||
interface_zmq.py | ||
mempool_accept.py | ||
mempool_limit.py | ||
mempool_packages.py | ||
mempool_persist.py | ||
mempool_reorg.py | ||
mempool_resurrect.py | ||
mempool_spend_coinbase.py | ||
mining_basic.py | ||
mining_getblocktemplate_longpoll.py | ||
mining_prioritisetransaction.py | ||
p2p_addrv2_relay.py | ||
p2p_compactblocks.py | ||
p2p_connect_to_devnet.py | ||
p2p_disconnect_ban.py | ||
p2p_fingerprint.py | ||
p2p_instantsend.py | ||
p2p_invalid_block.py | ||
p2p_invalid_locator.py | ||
p2p_invalid_tx.py | ||
p2p_leak.py | ||
p2p_mempool.py | ||
p2p_node_network_limited.py | ||
p2p_quorum_data.py | ||
p2p_sendheaders.py | ||
p2p_timeouts.py | ||
p2p_unrequested_blocks.py | ||
README.md | ||
rpc_bind.py | ||
rpc_blockchain.py | ||
rpc_coinjoin.py | ||
rpc_decodescript.py | ||
rpc_deprecated.py | ||
rpc_fundrawtransaction_hd.py | ||
rpc_fundrawtransaction.py | ||
rpc_getblockstats.py | ||
rpc_getchaintips.py | ||
rpc_help.py | ||
rpc_invalidateblock.py | ||
rpc_masternode.py | ||
rpc_mnauth.py | ||
rpc_named_arguments.py | ||
rpc_net.py | ||
rpc_platform_filter.py | ||
rpc_preciousblock.py | ||
rpc_rawtransaction.py | ||
rpc_signmessage.py | ||
rpc_signrawtransaction.py | ||
rpc_txoutproof.py | ||
rpc_uptime.py | ||
rpc_users.py | ||
rpc_verifychainlock.py | ||
rpc_verifyislock.py | ||
rpc_zmq.py | ||
test_runner.py | ||
wallet_abandonconflict.py | ||
wallet_backup.py | ||
wallet_basic.py | ||
wallet_disable.py | ||
wallet_disableprivatekeys.py | ||
wallet_dump.py | ||
wallet_encryption.py | ||
wallet_groups.py | ||
wallet_hd.py | ||
wallet_import_rescan.py | ||
wallet_importmulti.py | ||
wallet_importprunedfunds.py | ||
wallet_keypool_hd.py | ||
wallet_keypool_topup.py | ||
wallet_keypool.py | ||
wallet_labels.py | ||
wallet_listreceivedby.py | ||
wallet_listsinceblock.py | ||
wallet_listtransactions.py | ||
wallet_multiwallet.py | ||
wallet_resendwallettransactions.py | ||
wallet_txn_clone.py | ||
wallet_txn_doublespend.py | ||
wallet_upgradetohd.py | ||
wallet_zapwallettxes.py |
Functional tests
Writing Functional Tests
Example test
The example_test.py is a heavily commented example of a test case that uses both the RPC and P2P interfaces. If you are writing your first test, copy that file and modify to fit your needs.
Coverage
Running test_runner.py
with the --coverage
argument tracks which RPCs are
called by the tests and prints a report of uncovered RPCs in the summary. This
can be used (along with the --extended
argument) to find out which RPCs we
don't have test cases for.
Style guidelines
- Where possible, try to adhere to PEP-8 guidelines
- Use a python linter like flake8 before submitting PRs to catch common style nits (eg trailing whitespace, unused imports, etc)
- The oldest supported Python version is specified in doc/dependencies.md. Consider using pyenv, which checks .python-version, to prevent accidentally introducing modern syntax from an unsupported Python version. The Travis linter also checks this, but possibly not in all cases.
- See the python lint script that checks for violations that could lead to bugs and issues in the test code.
- Avoid wildcard imports
- Use a module-level docstring to describe what the test is testing, and how it is testing it.
- When subclassing the BitcoinTestFramwork, place overrides for the
set_test_params()
,add_options()
andsetup_xxxx()
methods at the top of the subclass, then locally-defined helper methods, then therun_test()
method. - Use
'{}'.format(x)
for string formatting, not'%s' % x
.
Naming guidelines
- Name the test
<area>_test.py
, where area can be one of the following:feature
for tests for full features that aren't wallet/mining/mempool, egfeature_rbf.py
interface
for tests for other interfaces (REST, ZMQ, etc), eginterface_rest.py
mempool
for tests for mempool behaviour, egmempool_reorg.py
mining
for tests for mining features, egmining_prioritisetransaction.py
p2p
for tests that explicitly test the p2p interface, egp2p_disconnect_ban.py
rpc
for tests for individual RPC methods or features, egrpc_listtransactions.py
wallet
for tests for wallet features, egwallet_keypool.py
- use an underscore to separate words
- exception: for tests for specific RPCs or command line options which don't include underscores, name the test after the exact RPC or argument name, eg
rpc_decodescript.py
, notrpc_decode_script.py
- exception: for tests for specific RPCs or command line options which don't include underscores, name the test after the exact RPC or argument name, eg
- Don't use the redundant word
test
in the name, eginterface_zmq.py
, notinterface_zmq_test.py
General test-writing advice
- Set
self.num_nodes
to the minimum number of nodes necessary for the test. Having additional unrequired nodes adds to the execution time of the test as well as memory/CPU/disk requirements (which is important when running tests in parallel or on Travis). - Avoid stop-starting the nodes multiple times during the test if possible. A stop-start takes several seconds, so doing it several times blows up the runtime of the test.
- Set the
self.setup_clean_chain
variable inset_test_params()
to control whether or not to use the cached data directories. The cached data directories contain a 200-block pre-mined blockchain and wallets for four nodes. Each node has 25 mature blocks (25x500=12500 DASH) in its wallet. - When calling RPCs with lots of arguments, consider using named keyword arguments instead of positional arguments to make the intent of the call clear to readers.
RPC and P2P definitions
Test writers may find it helpful to refer to the definitions for the RPC and P2P messages. These can be found in the following source files:
/src/rpc/*
for RPCs/src/wallet/rpc*
for wallet RPCsProcessMessage()
in/src/net_processing.cpp
for parsing P2P messages
Using the P2P interface
-
mininode.py
contains all the definitions for objects that pass over the network (CBlock
,CTransaction
, etc, along with the network-level wrappers for them,msg_block
,msg_tx
, etc). -
P2P tests have two threads. One thread handles all network communication with the dashd(s) being tested in a callback-based event loop; the other implements the test logic.
-
P2PConnection
is the class used to connect to a dashd.P2PInterface
contains the higher level logic for processing P2P payloads and connecting to the Bitcoin Core node application logic. For custom behaviour, subclass the P2PInterface object and override the callback methods. -
Can be used to write tests where specific P2P protocol behavior is tested. Examples tests are
p2p_unrequested_blocks.py
,p2p_compactblocks.py
.
test-framework modules
test_framework/authproxy.py
Taken from the python-bitcoinrpc repository.
test_framework/test_framework.py
Base class for functional tests.
test_framework/util.py
Generally useful functions.
test_framework/mininode.py
Basic code to support P2P connectivity to a dashd.
test_framework/script.py
Utilities for manipulating transaction scripts (originally from python-bitcoinlib)
test_framework/key.py
Wrapper around OpenSSL EC_Key (originally from python-bitcoinlib)
test_framework/bignum.py
Helpers for script.py
test_framework/blocktools.py
Helper functions for creating blocks and transactions.