dash/test/functional/test_framework
Wladimir J. van der Laan 2c7b29bac5
Merge #11466: Specify custom wallet directory with -walletdir param
c1e5d40 Make debugging test crash easier (MeshCollider)
8263f6a Create walletdir if datadir doesn't exist and fix tests (MeshCollider)
9587a9c Default walletdir is wallets/ if it exists (MeshCollider)
d987889 Add release notes for -walletdir and wallets/ dir (MeshCollider)
80c5cbc Add test for -walletdir (MeshCollider)
0530ba0 Add -walletdir parameter to specify custom wallet dir (MeshCollider)

Pull request description:

  Closes #11348

  Adds a `-walletdir` parameter which specifies a directory to use for wallets, allowing them to be stored separately from the 'main' data directory. Creates a new `wallets/` directory in datadir if this is the first time running, and defaults to using it if it exists.

  Includes tests and release notes. Things which might need to be considered more:
  - there is no 'lock' on the wallets directory, which might be needed?
  - because this uses a new wallets/ directory by default, downgrading to an earlier version won't see the wallets in that directory (not a big deal though, users can just copy them up to the main dir)
  - jnewbery suggested putting each wallet in its own directory, which is a good idea, but out of scope for this PR IMO. EDIT: this is being done in https://github.com/bitcoin/bitcoin/pull/11687
  - doc/files.md needs updating (will do soon)

  I also considered including  a cleanup by removing caching of data directory paths and instead just initialise them once on startup (c.f. #3073), but decided it wasn't super relevant here will just complicate review.

Tree-SHA512: c8ac04bfe9a810c32055f2c8b8fa0d535e56125ceb8d96f12447dd3538bf3e5ee992b60b1cd2173bf5f3fa023a9feab12c9963593bf27ed419df929bb413398d
2020-02-08 23:33:25 -06:00
..
__init__.py Merge bitcoin#9956: Reorganise qa directory (#2912) 2019-05-19 23:20:34 +03:00
authproxy.py Merge #11277: Fix uninitialized URI in batch RPC requests 2019-09-30 08:33:16 +02:00
bignum.py Merge #10781: Python cleanups 2020-01-02 22:01:29 -06:00
blocktools.py Merge bitcoin#9956: Reorganise qa directory (#2912) 2019-05-19 23:20:34 +03:00
coverage.py Merge #11277: Fix uninitialized URI in batch RPC requests 2019-09-30 08:33:16 +02:00
key.py Merge bitcoin#9956: Reorganise qa directory (#2912) 2019-05-19 23:20:34 +03:00
mininode.py Merge #11323: mininode: add an optimistic write and disable nagle 2020-01-11 18:22:25 -06:00
netutil.py Merge #10781: Python cleanups 2020-01-02 22:01:29 -06:00
script.py Merge #10781: Python cleanups 2020-01-02 22:01:29 -06:00
siphash.py Merge bitcoin#9956: Reorganise qa directory (#2912) 2019-05-19 23:20:34 +03:00
socks5.py Merge #10781: Python cleanups 2020-01-02 22:01:29 -06:00
test_framework.py Merge #11466: Specify custom wallet directory with -walletdir param 2020-02-08 23:33:25 -06:00
test_node.py Merge #14413: tests: Allow closed rpc handler in assert_start_raises_init_error (#3157) 2019-10-17 11:59:21 +02:00
util.py Bump copyright year to 2020 (#3290) 2020-01-17 15:42:55 +01:00