e4fcb170cf
1b41c2c8a126ef4be183e1d800a17d85cab8837b test: improve gettransaction test coverage (Jon Atack) 0f34f54888f680bfbe7a29ac278636d7178a99bb rpc: fix regression in gettransaction (Jon Atack) Pull request description: Closes #16872. PR #16866 renamed the `decode` argument in gettransaction to `verbose` to make it more consistent with other RPC calls like getrawtransaction. However, it inadvertently overloaded the "details" field when `verbose` is passed. The result is that the original "details" field is no longer returned correctly, which seems to be a breaking API change. This PR: - takes the simplest path to restoring the "details" field by renaming the decoded one back to "decoded" while leaving the `verbose` argument for API consistency, which was the main intent of #16866, - addresses [this comment](https://github.com/bitcoin/bitcoin/pull/16185#discussion_r320740413) by mentioning in the RPC help that the new decoded field is equivalent to decoderawtransaction, and - updates the help, functional test, and release note. Reviewers, to test this manually, build and run `bitcoin-cli help gettransaction` and `bitcoin-cli gettransaction <wallet txid> false true`, and verify that the command returns both `details` and `decoded` fields. ACKs for top commit: jnewbery: tACK 1b41c2c8a126ef4be183e1d800a17d85cab8837b Tree-SHA512: 287edd5db7ed58fe8b548975aba58628bd45ed708b28f40174f10a35a455d89f796fbf27430aa881fc376f47aabda8803f74d4d100683bd86577a02279091cf3 |
||
---|---|---|
.. | ||
gitian-building | ||
man | ||
release-notes | ||
.gitignore | ||
assets-attribution.md | ||
benchmarking.md | ||
bips.md | ||
bitcoin_logo_doxygen.png | ||
build-cross.md | ||
build-generic.md | ||
build-netbsd.md | ||
build-osx.md | ||
build-unix.md | ||
build-windows.md | ||
dash-conf.md | ||
dependencies.md | ||
descriptors.md | ||
developer-notes.md | ||
dnsseed-policy.md | ||
Doxyfile.in | ||
files.md | ||
fuzzing.md | ||
gitian-building.md | ||
guix.md | ||
init.md | ||
instantsend.md | ||
JSON-RPC-interface.md | ||
masternode-budget.md | ||
productivity.md | ||
psbt.md | ||
README_doxygen.md | ||
README_windows.txt | ||
README.md | ||
reduce-memory.md | ||
reduce-traffic.md | ||
release-notes-4892.md | ||
release-notes-5021.md | ||
release-notes-5039.md | ||
release-notes-5112.md | ||
release-notes-5125.md | ||
release-notes-5158.md | ||
release-notes-5164.md | ||
release-notes-5206.md | ||
release-notes-5225.md | ||
release-notes-5273.md | ||
release-notes-15427.md | ||
release-notes-15454.md | ||
release-notes-16185.md | ||
release-notes-18733.md | ||
release-notes-18807.md | ||
release-notes.md | ||
release-process.md | ||
REST-interface.md | ||
shared-libraries.md | ||
tor.md | ||
translation_process.md | ||
translation_strings_policy.md | ||
zmq.md |
Dash Core
This is the official reference wallet for Dash digital currency and comprises the backbone of the Dash peer-to-peer network. You can download Dash Core or build it yourself using the guides below.
Running
The following are some helpful notes on how to run Dash Core on your native platform.
Unix
Unpack the files into a directory and run:
bin/dash-qt
(GUI) orbin/dashd
(headless)
Windows
Unpack the files into a directory, and then run dash-qt.exe.
macOS
Drag Dash Core to your applications folder, and then run Dash Core.
Need Help?
- See the Dash documentation for help and more information.
- Ask for help on Dash Discord
- Ask for help on the Dash Forum
Building
The following are developer notes on how to build Dash Core on your native platform. They are not complete guides, but include notes on the necessary libraries, compile flags, etc.
- Dependencies
- macOS Build Notes
- Unix Build Notes
- Windows Build Notes
- OpenBSD Build Notes
- NetBSD Build Notes
- Gitian Building Guide
Development
The Dash Core repo's root README contains relevant information on the development process and automated testing.
- Developer Notes
- Productivity Notes
- Release Notes
- Release Process
- Source Code Documentation TODO
- Translation Process
- Translation Strings Policy
- JSON-RPC Interface
- Unauthenticated REST Interface
- Shared Libraries
- BIPS
- Dnsseed Policy
- Benchmarking
Resources
- See the Dash Developer Documentation for technical specifications and implementation details.
- Discuss on the Dash Forum, in the Development & Technical Discussion board.
- Discuss on Dash Discord
- Discuss on Dash Developers Discord
Miscellaneous
- Assets Attribution
- dash.conf Configuration File
- Files
- Fuzz-testing
- Reduce Memory
- Reduce Traffic
- Tor Support
- Init Scripts (systemd/upstart/openrc)
- ZMQ
- PSBT support
License
Distributed under the MIT software license.