dash/src
MarcoFalke baa37c345c Merge #17138: Remove wallet access to some node arguments
This backports also includes extra changes that were missing from bitcoin#14711
They are required, otherwise impossible to remove validaion.h dependency as it meant in #17138

b96ed0396294fc4fa89d83ceab6bc169dd09f002 [wallet] Remove pruning check for -rescan option (John Newbery)
eea462de9c652dca556ad241d2126b10790f67f8 [wallet] Remove package limit config access from wallet (John Newbery)

Pull request description:

  Removes wallet access to `-limitancestorcount`, `-limitdescendantcount` and `-prune`:

  - `-limitancestorcount` and `-limitdescendantcount` are now accessed with a method `getPackageLimits` in the `Chain` interface.
  - `-prune` is not required. It was only used in wallet component initiation to prevent running `-rescan` when pruning was enabled. This check is not required.

  Partially addresses #17137.

ACKs for top commit:
  MarcoFalke:
    Tested ACK b96ed0396294fc4fa89d83ceab6bc169dd09f002
  ryanofsky:
    Code review ACK b96ed0396294fc4fa89d83ceab6bc169dd09f002
  promag:
    Code review ACK b96ed0396294fc4fa89d83ceab6bc169dd09f002.
  ariard:
    ACK b96ed03, check there isn't left anymore wallet access to node arguments.

Tree-SHA512: 90c8e3e083acbd37724f1bccf63dab642cf9ae95cc5e684872a67443ae048b4fdbf57b52ea47c5a1da6489fd277278fe2d9bbe95e17f3d4965a1a0fbdeb815bf
2023-04-06 20:15:47 +03:00
..
bench Merge #18173: refactor: test/bench: deduplicate SetupDummyInputs() 2023-04-04 12:53:49 -05:00
bls fix: governance correct sig check (#5242) 2023-03-11 11:44:35 -06:00
coinjoin merge bitcoin#20750: Prune g_chainman usage in mempool-related validation functions 2023-04-04 12:41:45 -05:00
compat
config
consensus Merge #19069: refactor: replace pointers by references within tx_verify.{h,cpp} 2023-01-01 20:16:57 -06:00
crc32c
crypto
dashbls build: stop tracking cmake dependency relic_conf.h.in 2023-03-16 16:37:02 +00:00
evo fix: add passed HPMN payments to the list in GetProjectedMNPayees (#5298) 2023-04-06 09:23:26 -05:00
governance fix(governance): use weighted mn count (#5299) 2023-04-06 09:19:32 -05:00
immer build: fix gitian builds 2023-01-03 14:51:16 +03:00
index merge bitcoin#20749: Prune g_chainman usage related to ::LookupBlockIndex 2023-04-04 12:41:45 -05:00
interfaces Merge #16503: Remove p2pEnabled from Chain interface 2023-04-04 12:45:27 -05:00
leveldb Merge bitcoin/bitcoin#25739: Update leveldb subtree (#5005) 2022-09-23 18:43:39 +04:00
llmq merge bitcoin#21055: Prune remaining g_chainman usage in validation functions 2023-04-04 12:41:45 -05:00
logging Merge #18088: build: ensure we aren't using GNU extensions 2023-03-03 23:07:16 +05:30
masternode feat!: 4k collateral high performance masternode implementation (#5039) 2023-02-14 12:48:33 -06:00
node Merge #16503: Remove p2pEnabled from Chain interface 2023-04-04 12:45:27 -05:00
policy merge bitcoin#18766: disable fee estimation in blocksonly mode (by removing the fee estimates global) 2023-02-28 00:11:11 +03:00
primitives Merge #18859: Remove CCoinsViewCache::GetValueIn(...) 2023-03-03 23:07:15 +05:30
qt Merge #14879: qt: Add warning messages to the debug window 2023-04-06 20:14:58 +03:00
rpc Merge #18032: rpc: Output a descriptor in createmultisig and addmultisigaddress 2023-04-06 20:15:47 +03:00
script Merge #17056: descriptors: Introduce sortedmulti descriptor 2023-04-06 20:15:47 +03:00
secp256k1
support fix: Fix missing includes (#5295) 2023-04-05 21:20:41 -05:00
test fix: dashification for rpc_createmultisig introduced in bitcoin#13072 2023-04-06 20:15:47 +03:00
univalue
util fix: Fix missing includes (#5295) 2023-04-05 21:20:41 -05:00
wallet Merge #17138: Remove wallet access to some node arguments 2023-04-06 20:15:47 +03:00
zmq Merge #17477: Remove the mempool's NotifyEntryAdded and NotifyEntryRemoved signals 2023-02-15 00:07:39 -06:00
.clang-format
addrdb.cpp merge bitcoin#19314: Use uint16_t instead of unsigned short 2022-10-20 16:08:45 -05:00
addrdb.h
addressindex.h Merge #16908: txmempool: Make entry time type-safe (std::chrono) 2022-10-03 16:08:31 -04:00
addrman.cpp merge bitcoin#21016: remove boost::thread_group usage 2023-01-19 03:42:51 +00:00
addrman.h merge bitcoin#20291: Consolidate logic around calling CAddrMan::Connected() 2023-02-28 00:11:11 +03:00
amount.h
arith_uint256.cpp
arith_uint256.h
attributes.h
banman.cpp feat(rpc): Added RPC cleardiscouraged (#5273) 2023-03-29 11:23:45 -05:00
banman.h feat(rpc): Added RPC cleardiscouraged (#5273) 2023-03-29 11:23:45 -05:00
base58.cpp merge bitcoin#20429: replace (sizeof(a)/sizeof(a[0])) with C++17 std::size 2022-11-01 00:28:53 -05:00
base58.h
batchedlogger.cpp chore: run copyright_header.py update 2023-01-13 00:49:04 +03:00
batchedlogger.h chore: run copyright_header.py update 2023-01-13 00:49:04 +03:00
bech32.cpp
bech32.h
bip39_english.h
bip39.cpp
bip39.h
bitcoin-cli.cpp Merge #18702: build: fix ASLR for bitcoin-cli on Windows 2023-02-20 09:09:23 -06:00
bitcoin-tx.cpp Merge #15452: Replace CScriptID and CKeyID in CTxDestination with dedicated types 2023-02-10 23:34:57 +03:00
bitcoin-wallet.cpp
bitcoind.cpp Merge #16489: log: harmonize bitcoind logging 2023-04-06 20:14:58 +03:00
blockencodings.cpp
blockencodings.h
blockfilter.cpp
blockfilter.h
bloom.cpp Merge #18806: net: remove is{Empty,Full} flags from CBloomFilter, clarify CVE fix 2023-01-22 00:27:52 -06:00
bloom.h Merge #18806: net: remove is{Empty,Full} flags from CBloomFilter, clarify CVE fix 2023-01-22 00:27:52 -06:00
cachemap.h chore: run copyright_header.py update 2023-01-13 00:49:04 +03:00
cachemultimap.h chore: run copyright_header.py update 2023-01-13 00:49:04 +03:00
chain.cpp
chain.h
chainparams.cpp chore: v19 starttime and timeout bump (#5300) 2023-04-06 11:15:42 -05:00
chainparams.h refactor: tweak GetLLMQ to fail gracefully and let caller handle results accordingly (#5247) 2023-03-13 11:11:17 -05:00
chainparamsbase.cpp feat(llmq): Introduction of llmq_devnet_platform + update llmqPlatform from args (devnets only) (#5205) 2023-02-19 10:53:29 -06:00
chainparamsbase.h merge bitcoin#21328: pass uint16 CService::port as uint16 2022-11-01 00:28:53 -05:00
chainparamsseeds.h
checkqueue.h
clientversion.cpp
clientversion.h
coins.cpp Merge #18859: Remove CCoinsViewCache::GetValueIn(...) 2023-03-03 23:07:15 +05:30
coins.h Merge #18859: Remove CCoinsViewCache::GetValueIn(...) 2023-03-03 23:07:15 +05:30
compat.h
compressor.cpp
compressor.h
context.h merge bitcoin#18766: disable fee estimation in blocksonly mode (by removing the fee estimates global) 2023-02-28 00:11:11 +03:00
core_io.h merge bitcoin#15508: Refactor analyzepsbt for use outside RPC code 2022-09-24 08:51:04 +05:30
core_memusage.h
core_read.cpp merge bitcoin#25057: replace remaining boost::split with SplitString 2023-01-19 03:49:04 +00:00
core_write.cpp Merge #15452: Replace CScriptID and CKeyID in CTxDestination with dedicated types 2023-02-10 23:34:57 +03:00
ctpl_stl.h
cuckoocache.h
cxxtimer.hpp test/refactor: upgrade to cppcheck 2.9 and fix warnings (#5049) 2022-10-18 13:24:00 +03:00
dash-cli-res.rc
dash-tx-res.rc
dash-wallet-res.rc
dashd-res.rc
dbwrapper.cpp
dbwrapper.h
dsnotificationinterface.cpp Merge #17477: Remove the mempool's NotifyEntryAdded and NotifyEntryRemoved signals 2023-02-15 00:07:39 -06:00
dsnotificationinterface.h Merge #17477: Remove the mempool's NotifyEntryAdded and NotifyEntryRemoved signals 2023-02-15 00:07:39 -06:00
dummywallet.cpp fix(gui): remove "Upgrade wallet format" button from "Wallet Repair" tab 2023-02-17 14:21:19 -06:00
flat-database.h chore: run copyright_header.py update 2023-01-13 00:49:04 +03:00
flatfile.cpp
flatfile.h
fs.cpp Merge #19299: refactor: Remove unused vars, Add missing includes 2023-01-22 00:27:52 -06:00
fs.h
hash.cpp
hash.h
hdchain.cpp
hdchain.h chore: run copyright_header.py update 2023-01-13 00:49:04 +03:00
httprpc.cpp merge bitcoin#25057: replace remaining boost::split with SplitString 2023-01-19 03:49:04 +00:00
httprpc.h refactor: replace util::Ref with CoreContext (std::variant) (#5055) 2022-10-22 12:18:03 -05:00
httpserver.cpp merge bitcoin#21328: pass uint16 CService::port as uint16 2022-11-01 00:28:53 -05:00
httpserver.h
indirectmap.h
init.cpp merge bitcoin#21055: Prune remaining g_chainman usage in validation functions 2023-04-04 12:41:45 -05:00
init.h refactor: replace util::Ref with CoreContext (std::variant) (#5055) 2022-10-22 12:18:03 -05:00
key_io.cpp Merge #15452: Replace CScriptID and CKeyID in CTxDestination with dedicated types 2023-02-10 23:34:57 +03:00
key_io.h
key.cpp
key.h
limitedmap.h
logging.cpp
logging.h
Makefile.am Merge #18395: scripts: add PE dylib checking to symbol-check.py 2023-03-26 16:50:26 -05:00
Makefile.bench.include Merge #16267: bench: Benchmark blockToJSON 2023-03-29 21:01:56 +03:00
Makefile.crc32c.include
Makefile.leveldb.include
Makefile.qt_locale.include
Makefile.qt.include partial bitcoin#19077: Add sqlite as an alternative wallet database and use it for new descriptor wallets 2023-02-07 10:53:33 -06:00
Makefile.qttest.include partial bitcoin#19077: Add sqlite as an alternative wallet database and use it for new descriptor wallets 2023-02-07 10:53:33 -06:00
Makefile.test_fuzz.include merge bitcoin#18528: create test_fuzz library from src/test/fuzz/fuzz.cpp 2022-10-02 12:05:13 +05:30
Makefile.test_util.include
Makefile.test.include Merge #18067: wallet: Improve LegacyScriptPubKeyMan::CanProvide script recognition 2023-03-19 11:08:31 -05:00
Makefile.univalue.include
mapport.cpp
mapport.h
memusage.h
merkleblock.cpp
merkleblock.h
messagesigner.cpp chore: run copyright_header.py update 2023-01-13 00:49:04 +03:00
messagesigner.h chore: run copyright_header.py update 2023-01-13 00:49:04 +03:00
miner.cpp partial bitcoin#21270: Prune g_chainman usage in validation-adjacent modules 2023-04-04 12:41:45 -05:00
miner.h partial bitcoin#21270: Prune g_chainman usage in validation-adjacent modules 2023-04-04 12:41:45 -05:00
net_permissions.cpp Merge #17754: net: Don't allow resolving of std::string with embedded NUL characters. Add tests. 2022-10-03 16:08:31 -04:00
net_permissions.h Merge #17985: net: Remove forcerelay of rejected txs 2022-10-20 11:48:21 -04:00
net_processing.cpp merge bitcoin#21055: Prune remaining g_chainman usage in validation functions 2023-04-04 12:41:45 -05:00
net_processing.h partial bitcoin#20228: Make addrman a top-level component 2023-02-28 00:11:11 +03:00
net_types.h
net.cpp format: fix indentation (#5277) 2023-03-29 11:24:16 -05:00
net.h partial bitcoin#20228: Make addrman a top-level component 2023-02-28 00:11:11 +03:00
netaddress.cpp Merge #15718: docs: Improve netaddress comments 2023-03-29 21:01:56 +03:00
netaddress.h Merge #15718: docs: Improve netaddress comments 2023-03-29 21:01:56 +03:00
netbase.cpp merge bitcoin#21328: pass uint16 CService::port as uint16 2022-11-01 00:28:53 -05:00
netbase.h merge bitcoin#21328: pass uint16 CService::port as uint16 2022-11-01 00:28:53 -05:00
netfulfilledman.cpp chore: run copyright_header.py update 2023-01-13 00:49:04 +03:00
netfulfilledman.h chore: run copyright_header.py update 2023-01-13 00:49:04 +03:00
netmessagemaker.h
noui.cpp
noui.h
outputtype.cpp Merge #18067: wallet: Improve LegacyScriptPubKeyMan::CanProvide script recognition 2023-03-19 11:08:31 -05:00
outputtype.h Merge #17261: Make ScriptPubKeyMan an actual interface and the wallet to have multiple 2023-03-19 11:08:31 -05:00
pow.cpp
pow.h
prevector.h Merge #18088: build: ensure we aren't using GNU extensions 2023-03-03 23:07:16 +05:30
protocol.cpp merge bitcoin#15437: Remove BIP61 reject messages 2022-12-02 15:43:01 +05:30
protocol.h merge bitcoin#19486: Remove unused constants CADDR_TIME_VERSION and GETHEADERS_VERSION 2023-02-28 00:11:11 +03:00
psbt.cpp Merge #17156: psbt: check that various indexes and amounts are within bounds 2023-02-04 10:02:37 -06:00
psbt.h Merge #17524: psbt: handle unspendable psbts 2023-02-04 10:02:37 -06:00
pubkey.cpp
pubkey.h
random.cpp merge bitcoin#20429: replace (sizeof(a)/sizeof(a[0])) with C++17 std::size 2022-11-01 00:28:53 -05:00
random.h
randomenv.cpp merge bitcoin#20602: Allow use of C++14 chrono literals 2022-10-20 16:08:45 -05:00
randomenv.h
rest.cpp merge bitcoin#20749: Prune g_chainman usage related to ::LookupBlockIndex 2023-04-04 12:41:45 -05:00
reverse_iterator.h
saltedhasher.cpp chore: run copyright_header.py update 2023-01-13 00:49:04 +03:00
saltedhasher.h chore: run copyright_header.py update 2023-01-13 00:49:04 +03:00
scheduler.cpp merge bitcoin#19090: Misc scheduler cleanups 2023-01-19 03:42:49 +00:00
scheduler.h merge bitcoin#21016: remove boost::thread_group usage 2023-01-19 03:42:51 +00:00
serialize.h merge bitcoin#19314: Use uint16_t instead of unsigned short 2022-10-20 16:08:45 -05:00
shutdown.cpp
shutdown.h
span.h Merge #19508: Work around memory-aliasing in descriptor ParsePubkey 2023-01-23 12:22:31 -06:00
spentindex.h
spork.cpp merge bitcoin#19607: Add Peer struct for per-peer data in net processing 2023-02-28 00:11:11 +03:00
spork.h refactor: using C++11/14/17 features in dash specifict code (#5190) 2023-02-19 17:04:57 -06:00
stacktraces.cpp
stacktraces.h
statsd_client.cpp refactor: resolve implicit-const-int-float-conversion warning in statsd_client 2022-10-21 21:51:35 +05:30
statsd_client.h chore: add missing copyrights via copyright_header.py insert 2023-01-13 00:49:04 +03:00
streams.h Merge #19593: refactor: Drop unused CBufferedFile::Seek() 2022-09-03 10:43:14 -05:00
sync.cpp Merge #19982: test: Fix inconsistent lock order in wallet_tests/CreateWallet 2023-03-19 11:08:31 -05:00
sync.h Merge #19982: test: Fix inconsistent lock order in wallet_tests/CreateWallet 2023-03-19 11:08:31 -05:00
threadinterrupt.cpp
threadinterrupt.h
threadsafety.h
timedata.cpp
timedata.h
tinyformat.h
torcontrol.cpp merge bitcoin#25068: Wrap boost::replace_all 2023-01-19 03:49:04 +00:00
torcontrol.h
txdb.cpp merge bitcoin#21016: remove boost::thread_group usage 2023-01-19 03:42:51 +00:00
txdb.h
txmempool.cpp merge bitcoin#21055: Prune remaining g_chainman usage in validation functions 2023-04-04 12:41:45 -05:00
txmempool.h merge bitcoin#21055: Prune remaining g_chainman usage in validation functions 2023-04-04 12:41:45 -05:00
ui_interface.cpp
ui_interface.h
uint256.cpp Merge #14734: fix an undefined behavior in uint::SetHex 2023-03-29 21:01:56 +03:00
uint256.h chore: run copyright_header.py update 2023-01-13 00:49:04 +03:00
undo.h
unordered_lru_cache.h
validation.cpp merge bitcoin#21055: Prune remaining g_chainman usage in validation functions 2023-04-04 12:41:45 -05:00
validation.h partial bitcoin#21270: Prune g_chainman usage in validation-adjacent modules 2023-04-04 12:41:45 -05:00
validationinterface.cpp Merge #17477: Remove the mempool's NotifyEntryAdded and NotifyEntryRemoved signals 2023-02-15 00:07:39 -06:00
validationinterface.h Merge #17477: Remove the mempool's NotifyEntryAdded and NotifyEntryRemoved signals 2023-02-15 00:07:39 -06:00
version.h chore: Bump MIN_MASTERNODE_PROTO_VERSION for v19 (#5223) 2023-02-28 09:59:57 -06:00
versionbits.cpp fix: speed up GetStateFor (#5100) 2022-12-13 11:42:52 -06:00
versionbits.h merge bitcoin#21055: Prune remaining g_chainman usage in validation functions 2023-04-04 12:41:45 -05:00
versionbitsinfo.cpp feat!: v19 BIP9 fork (#5070) 2022-11-22 11:34:21 -06:00
versionbitsinfo.h
walletinitinterface.h
warnings.cpp merge bitcoin#19905: Remove dead CheckForkWarningConditionsOnNewFork 2023-04-04 12:41:45 -05:00
warnings.h merge bitcoin#19905: Remove dead CheckForkWarningConditionsOnNewFork 2023-04-04 12:41:45 -05:00