mirror of
https://github.com/dashpay/dash.git
synced 2024-12-26 12:32:48 +01:00
9f4f52ae4e
68400d8b96 tests: Use explicit imports (practicalswift) Pull request description: Enable automatic detection of undefined names in Python tests scripts. Remove wildcard imports. Wildcard imports make it unclear which names are present in the namespace, confusing both readers and many automated tools. An additional benefit of not using wildcard imports in tests scripts is that readers of a test script then can infer the rough testing scope just by looking at the imports. Before this commit: ``` $ contrib/devtools/lint-python.sh | head -10 ./test/functional/feature_rbf.py:8:1: F403 'from test_framework.util import *' used; unable to detect undefined names ./test/functional/feature_rbf.py:9:1: F403 'from test_framework.script import *' used; unable to detect undefined names ./test/functional/feature_rbf.py:10:1: F403 'from test_framework.mininode import *' used; unable to detect undefined names ./test/functional/feature_rbf.py:15:12: F405 bytes_to_hex_str may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util ./test/functional/feature_rbf.py:17:58: F405 CScript may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util ./test/functional/feature_rbf.py:25:13: F405 COIN may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util ./test/functional/feature_rbf.py:26:31: F405 satoshi_round may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util ./test/functional/feature_rbf.py:26:60: F405 COIN may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util ./test/functional/feature_rbf.py:30:41: F405 satoshi_round may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util ./test/functional/feature_rbf.py:30:68: F405 COIN may be undefined, or defined from star imports: test_framework.mininode, test_framework.script, test_framework.util $ ``` After this commit: ``` $ contrib/devtools/lint-python.sh | head -10 $ ``` Tree-SHA512: 3f826d39cffb6438388e5efcb20a9622ff8238247e882d68f7b38609877421b2a8e10e9229575f8eb6a8fa42dec4256986692e92922c86171f750a0e887438d9
63 lines
2.3 KiB
Python
Executable File
63 lines
2.3 KiB
Python
Executable File
#!/usr/bin/env python3
|
|
# Copyright (c) 2014-2015 The Bitcoin Core developers
|
|
# Distributed under the MIT software license, see the accompanying
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
|
|
#
|
|
# Test timestampindex generation and fetching
|
|
#
|
|
|
|
from test_framework.test_framework import BitcoinTestFramework
|
|
from test_framework.test_node import ErrorMatch
|
|
from test_framework.util import assert_equal, connect_nodes
|
|
|
|
|
|
class TimestampIndexTest(BitcoinTestFramework):
|
|
|
|
def set_test_params(self):
|
|
self.setup_clean_chain = True
|
|
self.num_nodes = 4
|
|
|
|
def setup_network(self):
|
|
self.add_nodes(self.num_nodes)
|
|
# Nodes 0/1 are "wallet" nodes
|
|
self.start_node(0)
|
|
self.start_node(1, ["-timestampindex"])
|
|
# Nodes 2/3 are used for testing
|
|
self.start_node(2)
|
|
self.start_node(3, ["-timestampindex"])
|
|
connect_nodes(self.nodes[0], 1)
|
|
connect_nodes(self.nodes[0], 2)
|
|
connect_nodes(self.nodes[0], 3)
|
|
|
|
self.is_network_split = False
|
|
self.sync_all()
|
|
|
|
def run_test(self):
|
|
self.log.info("Test that settings can't be changed without -reindex...")
|
|
self.stop_node(1)
|
|
self.nodes[1].assert_start_raises_init_error(["-timestampindex=0"], "You need to rebuild the database using -reindex to change -timestampindex", match=ErrorMatch.PARTIAL_REGEX)
|
|
self.start_node(1, ["-timestampindex=0", "-reindex"])
|
|
connect_nodes(self.nodes[0], 1)
|
|
self.sync_all()
|
|
self.stop_node(1)
|
|
self.nodes[1].assert_start_raises_init_error(["-timestampindex"], "You need to rebuild the database using -reindex to change -timestampindex", match=ErrorMatch.PARTIAL_REGEX)
|
|
self.start_node(1, ["-timestampindex", "-reindex"])
|
|
connect_nodes(self.nodes[0], 1)
|
|
self.sync_all()
|
|
|
|
self.log.info("Mining 5 blocks...")
|
|
blockhashes = self.nodes[0].generate(5)
|
|
low = self.nodes[0].getblock(blockhashes[0])["time"]
|
|
high = self.nodes[0].getblock(blockhashes[4])["time"]
|
|
self.sync_all()
|
|
self.log.info("Checking timestamp index...")
|
|
hashes = self.nodes[1].getblockhashes(high, low)
|
|
assert_equal(len(hashes), 5)
|
|
assert_equal(sorted(blockhashes), sorted(hashes))
|
|
self.log.info("Passed")
|
|
|
|
|
|
if __name__ == '__main__':
|
|
TimestampIndexTest().main()
|