mirror of
https://github.com/dashpay/dash.git
synced 2024-12-28 05:23:01 +01:00
51911388f2
ffe33dfbd4c3b11e3475b022b6c1dd077613de79 chainparams: drop versionbits threshold to 90% for mainnnet and signet (Anthony Towns)
f054f6bcd2c2ce5fea84cf8681013f85a444e7ea versionbits: simplify state transitions (Anthony Towns)
55ac5f568a3b73d6f1ef4654617fb76e8bcbccdf versionbits: Add explicit NEVER_ACTIVE deployments (Anthony Towns)
dd07e6da48040dc7eae46bc7941db48d98a669fd fuzz: test versionbits delayed activation (Anthony Towns)
dd85d5411c1702c8ae259610fe55050ba212e21e tests: test versionbits delayed activation (Anthony Towns)
73d4a706393e6dbd6b6d6b6428f8d3233ac0a2d8 versionbits: Add support for delayed activation (Anthony Towns)
9e6b65f6fa205eee5c3b99343988adcb8d320460 tests: clean up versionbits test (Anthony Towns)
593274445004506c921d5d851361aefb3434d744 tests: test ComputeBlockVersion for all deployments (Anthony Towns)
63879f0a4760c0c0f784029849cb5d21ee088abb tests: pull ComputeBlockVersion test into its own function (Anthony Towns)
Pull request description:
BIP9-based implementation of "speedy trial" activation specification, see https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2021-March/018583.html
Edge cases are tested by fuzzing added in #21380.
ACKs for top commit:
instagibbs:
tACK ffe33dfbd4
jnewbery:
utACK ffe33dfbd4c3b11e3475b022b6c1dd077613de79
MarcoFalke:
review ACK ffe33dfbd4c3b11e3475b022b6c1dd077613de79 💈
achow101:
re-ACK ffe33dfbd4c3b11e3475b022b6c1dd077613de79
gmaxwell:
ACK ffe33dfbd4c3b11e3475b022b6c1dd077613de79
benthecarman:
ACK ffe33dfbd4c3b11e3475b022b6c1dd077613de79
Sjors:
ACK ffe33dfbd4c3b11e3475b022b6c1dd077613de79
jonatack:
Initial approach ACK ffe33dfbd4c3b11e3475b022b6c1dd077613de79 after a first pass of review, building and testing each commit, mostly looking at the changes and diffs. Will do a more high-level review iteration. A few minor comments follow to pick/choose/ignore.
ariard:
Code Review ACK ffe33df
Tree-SHA512: f79a7146b2450057ee92155cbbbcec12cd64334236d9239c6bd7d31b32eec145a9781c320f178da7b44ababdb8808b84d9d22a40e0851e229ba6d224e3be747c
146 lines
5.5 KiB
C++
146 lines
5.5 KiB
C++
// Copyright (c) 2021-2023 The Dash Core developers
|
|
// Distributed under the MIT software license, see the accompanying
|
|
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
|
|
#include <test/util/setup_common.h>
|
|
|
|
#include <chainparams.h>
|
|
#include <consensus/validation.h>
|
|
#include <deploymentstatus.h>
|
|
#include <evo/evodb.h>
|
|
#include <governance/governance.h>
|
|
#include <llmq/blockprocessor.h>
|
|
#include <llmq/chainlocks.h>
|
|
#include <llmq/context.h>
|
|
#include <llmq/instantsend.h>
|
|
#include <miner.h>
|
|
#include <script/interpreter.h>
|
|
#include <spork.h>
|
|
#include <validation.h>
|
|
#include <versionbits.h>
|
|
|
|
#include <boost/test/unit_test.hpp>
|
|
|
|
const auto deployment_id = Consensus::DEPLOYMENT_TESTDUMMY;
|
|
constexpr int window{100}, th_start{80}, th_end{60};
|
|
|
|
static constexpr int threshold(int attempt)
|
|
{
|
|
// An implementation of VersionBitsConditionChecker::Threshold()
|
|
int threshold_calc = th_start - attempt * attempt * window / 100 / 5;
|
|
if (threshold_calc < th_end) {
|
|
return th_end;
|
|
}
|
|
return threshold_calc;
|
|
}
|
|
|
|
struct TestChainDATSetup : public TestChainSetup
|
|
{
|
|
TestChainDATSetup() : TestChainSetup(window - 2, {"-vbparams=testdummy:0:999999999999:0:100:80:60:5:0"}) {}
|
|
|
|
void signal(int num_blocks, bool expected_lockin)
|
|
{
|
|
const auto& consensus_params = Params().GetConsensus();
|
|
// Mine non-signalling blocks
|
|
gArgs.ForceSetArg("-blockversion", "536870912");
|
|
for (int i = 0; i < window - num_blocks; ++i) {
|
|
CreateAndProcessBlock({}, coinbaseKey);
|
|
}
|
|
gArgs.ForceRemoveArg("blockversion");
|
|
if (num_blocks > 0) {
|
|
// Mine signalling blocks
|
|
for (int i = 0; i < num_blocks; ++i) {
|
|
CreateAndProcessBlock({}, coinbaseKey);
|
|
}
|
|
}
|
|
LOCK(cs_main);
|
|
if (expected_lockin) {
|
|
BOOST_CHECK_EQUAL(g_versionbitscache.State(::ChainActive().Tip(), consensus_params, deployment_id), ThresholdState::LOCKED_IN);
|
|
} else {
|
|
BOOST_CHECK_EQUAL(g_versionbitscache.State(::ChainActive().Tip(), consensus_params, deployment_id), ThresholdState::STARTED);
|
|
}
|
|
}
|
|
|
|
void test(int activation_index, bool check_activation_at_min)
|
|
{
|
|
const auto& consensus_params = Params().GetConsensus();
|
|
CScript coinbasePubKey = CScript() << ToByteVector(coinbaseKey.GetPubKey()) << OP_CHECKSIG;
|
|
|
|
{
|
|
LOCK(cs_main);
|
|
BOOST_CHECK_EQUAL(::ChainActive().Height(), window - 2);
|
|
BOOST_CHECK_EQUAL(g_versionbitscache.State(::ChainActive().Tip(), consensus_params, deployment_id), ThresholdState::DEFINED);
|
|
}
|
|
|
|
CreateAndProcessBlock({}, coinbaseKey);
|
|
|
|
{
|
|
LOCK(cs_main);
|
|
// Advance from DEFINED to STARTED at height = window - 1
|
|
BOOST_CHECK_EQUAL(::ChainActive().Height(), window - 1);
|
|
BOOST_CHECK_EQUAL(g_versionbitscache.State(::ChainActive().Tip(), consensus_params, deployment_id), ThresholdState::STARTED);
|
|
BOOST_CHECK_EQUAL(g_versionbitscache.Statistics(::ChainActive().Tip(), consensus_params, deployment_id).threshold, threshold(0));
|
|
// Next block should be signaling by default
|
|
const auto pblocktemplate = BlockAssembler(::ChainstateActive(), m_node, *m_node.mempool, Params()).CreateNewBlock(coinbasePubKey);
|
|
const uint32_t bitmask = ((uint32_t)1) << consensus_params.vDeployments[deployment_id].bit;
|
|
BOOST_CHECK_EQUAL(::ChainActive().Tip()->nVersion & bitmask, 0);
|
|
BOOST_CHECK_EQUAL(pblocktemplate->block.nVersion & bitmask, bitmask);
|
|
}
|
|
|
|
// Reach activation_index level
|
|
for (int i = 0; i < activation_index; ++i) {
|
|
signal(threshold(i) - 1, false); // 1 block short
|
|
|
|
{
|
|
// Still STARTED but with a (potentially) new threshold
|
|
LOCK(cs_main);
|
|
BOOST_CHECK_EQUAL(::ChainActive().Height(), window * (i + 2) - 1);
|
|
BOOST_CHECK_EQUAL(g_versionbitscache.State(::ChainActive().Tip(), consensus_params, deployment_id), ThresholdState::STARTED);
|
|
const auto vbts = g_versionbitscache.Statistics(::ChainActive().Tip(), consensus_params, deployment_id);
|
|
BOOST_CHECK_EQUAL(vbts.threshold, threshold(i + 1));
|
|
BOOST_CHECK(vbts.threshold <= th_start);
|
|
BOOST_CHECK(vbts.threshold >= th_end);
|
|
}
|
|
}
|
|
if (LOCK(cs_main); check_activation_at_min) {
|
|
BOOST_CHECK_EQUAL(g_versionbitscache.Statistics(::ChainActive().Tip(), consensus_params, deployment_id).threshold, th_end);
|
|
} else {
|
|
BOOST_CHECK(g_versionbitscache.Statistics(::ChainActive().Tip(), consensus_params, deployment_id).threshold > th_end);
|
|
}
|
|
|
|
// activate
|
|
signal(threshold(activation_index), true);
|
|
for (int i = 0; i < window; ++i) {
|
|
CreateAndProcessBlock({}, coinbaseKey);
|
|
}
|
|
{
|
|
LOCK(cs_main);
|
|
BOOST_CHECK_EQUAL(g_versionbitscache.State(::ChainActive().Tip(), consensus_params, deployment_id), ThresholdState::ACTIVE);
|
|
}
|
|
|
|
}
|
|
};
|
|
|
|
|
|
BOOST_AUTO_TEST_SUITE(dynamic_activation_thresholds_tests)
|
|
|
|
#define TEST(INDEX, activate_at_min_level) BOOST_FIXTURE_TEST_CASE(activate_at_##INDEX##_level, TestChainDATSetup) \
|
|
{ \
|
|
test(INDEX, activate_at_min_level); \
|
|
}
|
|
|
|
TEST(1, false)
|
|
TEST(2, false)
|
|
TEST(3, false)
|
|
TEST(4, false)
|
|
TEST(5, false)
|
|
TEST(6, false)
|
|
TEST(7, false)
|
|
TEST(8, false)
|
|
TEST(9, false)
|
|
TEST(10, true)
|
|
TEST(11, true)
|
|
TEST(12, true)
|
|
|
|
BOOST_AUTO_TEST_SUITE_END()
|