dash/test/functional/test_framework
Wladimir J. van der Laan 64e33f715f
Merge #12220: Error if relative -walletdir is specified
ec527c6 Don't allow relative -walletdir paths (Russell Yanofsky)

Pull request description:

  This makes it an error to explicitly specify a non-absolute -walletdir path, and also adds a debug.log warning if a relative rather than absolute -datadir path is configured.

  Specifying paths relative to the current working directory in a daemon process can be dangerous, because files can fail to be located even if the configuration doesn't change, but the daemon is started up differently.

  Specifying a relative -datadir now adds a warning to the debug log. It would not be backwards-compatible to forbid relative -datadir paths entirely, and it could also be inconvenient for command line testing.

  Specifying a relative -walletdir now results in a startup error. But since the -walletdir option is new in 0.16.0, there should be no compatibility issues. Another reason not to use working directory paths for -walletdir specifically is that the default -walletdir is a "wallets" subdirectory inside the datadir, so it could be surprising that setting -walletdir manually would choose a directory rooted in a completely different location.

Tree-SHA512: 67cbdae677f82487a9031c5ec96b0205a488ab08718a0f4f49365e025119f3d7f6cfc88ba1eba04c1ecd8b9561a5b2c42e2e1a267af7c08c76b83e5e361f5a31
2020-03-04 10:13:31 -06:00
..
__init__.py Merge bitcoin#9956: Reorganise qa directory (#2912) 2019-05-19 23:20:34 +03:00
authproxy.py Merge #11277: Fix uninitialized URI in batch RPC requests 2019-09-30 08:33:16 +02:00
bignum.py Merge #10781: Python cleanups 2020-01-02 22:01:29 -06:00
blocktools.py Merge bitcoin#9956: Reorganise qa directory (#2912) 2019-05-19 23:20:34 +03:00
coverage.py Merge #11277: Fix uninitialized URI in batch RPC requests 2019-09-30 08:33:16 +02:00
key.py Merge bitcoin#9956: Reorganise qa directory (#2912) 2019-05-19 23:20:34 +03:00
mininode.py Merge #11323: mininode: add an optimistic write and disable nagle 2020-01-11 18:22:25 -06:00
netutil.py Merge #10781: Python cleanups 2020-01-02 22:01:29 -06:00
script.py Merge #10781: Python cleanups 2020-01-02 22:01:29 -06:00
siphash.py Merge bitcoin#9956: Reorganise qa directory (#2912) 2019-05-19 23:20:34 +03:00
socks5.py Merge #10781: Python cleanups 2020-01-02 22:01:29 -06:00
test_framework.py Merge #12220: Error if relative -walletdir is specified 2020-03-04 10:13:31 -06:00
test_node.py Merge #12220: Error if relative -walletdir is specified 2020-03-04 10:13:31 -06:00
util.py Bump copyright year to 2020 (#3290) 2020-01-17 15:42:55 +01:00