mirror of
https://github.com/dashpay/dash.git
synced 2024-12-26 12:32:48 +01:00
be7bf2e9d8
aac6b3f067Update files.md for new wallets/ subdirectory (MeshCollider)b67342906cCleanups for walletdir PR (MeshCollider) Pull request description: This addresses the remaining nits from https://github.com/bitcoin/bitcoin/pull/11466 - Updates `doc/files.md` with respect to the new default wallet directory - Fixes @promag and @laanwj's error message nit, and Jonas' release notes nit - ~Addresses @laanwj's net-specific wallet subdirectory concern in the case that a walletdir is specified~ - Changes the #includes from "" to <> style after #11651 Tree-SHA512: b86bf5fdc4de54c1b0f65b60a83af3cf82b35d216ce9c0de724803bfba6934796238b6c412659dcc29ae2e3e856d4eb97ae777c80f36f4089d8acecfddefe9aa
122 lines
5.2 KiB
Python
Executable File
122 lines
5.2 KiB
Python
Executable File
#!/usr/bin/env python3
|
|
# Copyright (c) 2017 The Bitcoin Core developers
|
|
# Distributed under the MIT software license, see the accompanying
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
"""Test multiwallet.
|
|
|
|
Verify that a bitcoind node can load multiple wallet files
|
|
"""
|
|
import os
|
|
import shutil
|
|
|
|
from test_framework.test_framework import BitcoinTestFramework
|
|
from test_framework.util import assert_equal, assert_raises_rpc_error
|
|
|
|
class MultiWalletTest(BitcoinTestFramework):
|
|
def set_test_params(self):
|
|
self.setup_clean_chain = True
|
|
self.num_nodes = 1
|
|
self.extra_args = [['-wallet=w1', '-wallet=w2', '-wallet=w3', '-wallet=w']]
|
|
|
|
def run_test(self):
|
|
assert_equal(set(self.nodes[0].listwallets()), {"w1", "w2", "w3", "w"})
|
|
|
|
self.stop_node(0)
|
|
|
|
# should not initialize if there are duplicate wallets
|
|
self.assert_start_raises_init_error(0, ['-wallet=w1', '-wallet=w1'], 'Error loading wallet w1. Duplicate -wallet filename specified.')
|
|
|
|
# should not initialize if wallet file is a directory
|
|
wallet_dir = os.path.join(self.options.tmpdir, 'node0', 'regtest', 'wallets')
|
|
os.mkdir(os.path.join(wallet_dir, 'w11'))
|
|
self.assert_start_raises_init_error(0, ['-wallet=w11'], 'Error loading wallet w11. -wallet filename must be a regular file.')
|
|
|
|
# should not initialize if one wallet is a copy of another
|
|
shutil.copyfile(os.path.join(wallet_dir, 'w2'), os.path.join(wallet_dir, 'w22'))
|
|
self.assert_start_raises_init_error(0, ['-wallet=w2', '-wallet=w22'], 'duplicates fileid')
|
|
|
|
# should not initialize if wallet file is a symlink
|
|
os.symlink(os.path.join(wallet_dir, 'w1'), os.path.join(wallet_dir, 'w12'))
|
|
self.assert_start_raises_init_error(0, ['-wallet=w12'], 'Error loading wallet w12. -wallet filename must be a regular file.')
|
|
|
|
# should not initialize if the specified walletdir does not exist
|
|
self.assert_start_raises_init_error(0, ['-walletdir=bad'], 'Error: Specified -walletdir "bad" does not exist')
|
|
# should not initialize if the specified walletdir is not a directory
|
|
not_a_dir = os.path.join(wallet_dir, 'notadir')
|
|
open(not_a_dir, 'a').close()
|
|
self.assert_start_raises_init_error(0, ['-walletdir='+not_a_dir], 'Error: Specified -walletdir "' + not_a_dir + '" is not a directory')
|
|
|
|
# if wallets/ doesn't exist, datadir should be the default wallet dir
|
|
wallet_dir2 = os.path.join(self.options.tmpdir, 'node0', 'regtest', 'walletdir')
|
|
os.rename(wallet_dir, wallet_dir2)
|
|
self.start_node(0, ['-wallet=w4', '-wallet=w5'])
|
|
assert_equal(set(self.nodes[0].listwallets()), {"w4", "w5"})
|
|
w5 = self.nodes[0].get_wallet_rpc("w5")
|
|
w5.generate(1)
|
|
self.stop_node(0)
|
|
|
|
# now if wallets/ exists again, but the rootdir is specified as the walletdir, w4 and w5 should still be loaded
|
|
os.rename(wallet_dir2, wallet_dir)
|
|
self.start_node(0, ['-wallet=w4', '-wallet=w5', '-walletdir=' + os.path.join(self.options.tmpdir, 'node0', 'regtest')])
|
|
assert_equal(set(self.nodes[0].listwallets()), {"w4", "w5"})
|
|
w5 = self.nodes[0].get_wallet_rpc("w5")
|
|
w5_info = w5.getwalletinfo()
|
|
assert_equal(w5_info['immature_balance'], 500)
|
|
|
|
self.stop_node(0)
|
|
|
|
self.start_node(0, self.extra_args[0])
|
|
|
|
w1 = self.nodes[0].get_wallet_rpc("w1")
|
|
w2 = self.nodes[0].get_wallet_rpc("w2")
|
|
w3 = self.nodes[0].get_wallet_rpc("w3")
|
|
w4 = self.nodes[0].get_wallet_rpc("w")
|
|
wallet_bad = self.nodes[0].get_wallet_rpc("bad")
|
|
|
|
w1.generate(1)
|
|
|
|
# accessing invalid wallet fails
|
|
assert_raises_rpc_error(-18, "Requested wallet does not exist or is not loaded", wallet_bad.getwalletinfo)
|
|
|
|
# accessing wallet RPC without using wallet endpoint fails
|
|
assert_raises_rpc_error(-19, "Wallet file not specified", self.nodes[0].getwalletinfo)
|
|
|
|
# check w1 wallet balance
|
|
w1_info = w1.getwalletinfo()
|
|
assert_equal(w1_info['immature_balance'], 500)
|
|
w1_name = w1_info['walletname']
|
|
assert_equal(w1_name, "w1")
|
|
|
|
# check w2 wallet balance
|
|
w2_info = w2.getwalletinfo()
|
|
assert_equal(w2_info['immature_balance'], 0)
|
|
w2_name = w2_info['walletname']
|
|
assert_equal(w2_name, "w2")
|
|
|
|
w3_name = w3.getwalletinfo()['walletname']
|
|
assert_equal(w3_name, "w3")
|
|
|
|
w4_name = w4.getwalletinfo()['walletname']
|
|
assert_equal(w4_name, "w")
|
|
|
|
w1.generate(101)
|
|
assert_equal(w1.getbalance(), 1000)
|
|
assert_equal(w2.getbalance(), 0)
|
|
assert_equal(w3.getbalance(), 0)
|
|
assert_equal(w4.getbalance(), 0)
|
|
|
|
w1.sendtoaddress(w2.getnewaddress(), 1)
|
|
w1.sendtoaddress(w3.getnewaddress(), 2)
|
|
w1.sendtoaddress(w4.getnewaddress(), 3)
|
|
w1.generate(1)
|
|
assert_equal(w2.getbalance(), 1)
|
|
assert_equal(w3.getbalance(), 2)
|
|
assert_equal(w4.getbalance(), 3)
|
|
|
|
batch = w1.batch([w1.getblockchaininfo.get_request(), w1.getwalletinfo.get_request()])
|
|
assert_equal(batch[0]["result"]["chain"], "regtest")
|
|
assert_equal(batch[1]["result"]["walletname"], "w1")
|
|
|
|
if __name__ == '__main__':
|
|
MultiWalletTest().main()
|