mirror of
https://github.com/dashpay/dash.git
synced 2024-12-28 13:32:47 +01:00
c1c84d6987
db983beba6tests: Add lint-tests.sh which checks the test suite naming convention (practicalswift)5fd864fe8atests: Rename test suits not following the test suite naming convention (practicalswift)7b4a296a71tests: Add note about test suite naming convention (practicalswift) Pull request description: Changes: * Add note about test suite naming convention * Fix exceptions * Add regression test Rationale: * Consistent naming of test suites makes programmatic test running of specific tests/subsets of tests easier * Explicit is better than implicit Before this commit: ``` $ contrib/devtools/lint-tests.sh The test suite in file src/test/foo_tests.cpp should be named "foo_tests". Please make sure the following test suites follow that convention: src/test/blockchain_tests.cpp:BOOST_FIXTURE_TEST_SUITE(blockchain_difficulty_tests, BasicTestingSetup) src/test/prevector_tests.cpp:BOOST_FIXTURE_TEST_SUITE(PrevectorTests, TestingSetup) src/wallet/test/coinselector_tests.cpp:BOOST_FIXTURE_TEST_SUITE(coin_selection_tests, WalletTestingSetup) src/wallet/test/crypto_tests.cpp:BOOST_FIXTURE_TEST_SUITE(wallet_crypto, BasicTestingSetup) $ ``` After this commit: ``` $ contrib/devtools/lint-tests.sh $ ``` Tree-SHA512: 7258ab9a6b9b8fc1939efadc619e2f2f02cfce8034c7f2e5dc5ecc769aa12e17f6fb8e363817feaf15c026c5b958b2574525b8d2d3f6be69658679bf8ceea9e9
20 lines
715 B
Bash
Executable File
20 lines
715 B
Bash
Executable File
#!/bin/bash
|
|
#
|
|
# Copyright (c) 2018 The Bitcoin Core developers
|
|
# Distributed under the MIT software license, see the accompanying
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
#
|
|
# Check the test suite naming convention
|
|
|
|
NAMING_INCONSISTENCIES=$(git grep -E '^BOOST_FIXTURE_TEST_SUITE\(' -- \
|
|
"src/test/**.cpp" "src/wallet/test/**.cpp" | \
|
|
grep -vE '/(.*?)\.cpp:BOOST_FIXTURE_TEST_SUITE\(\1, .*\)$')
|
|
if [[ ${NAMING_INCONSISTENCIES} != "" ]]; then
|
|
echo "The test suite in file src/test/foo_tests.cpp should be named"
|
|
echo "\"foo_tests\". Please make sure the following test suites follow"
|
|
echo "that convention:"
|
|
echo
|
|
echo "${NAMING_INCONSISTENCIES}"
|
|
exit 1
|
|
fi
|