Wladimir J. van der Laan c23ba61230 Merge #13968: [wallet] couple of walletcreatefundedpsbt fixes ... faaac5caaab4d5131040292f4ef2404074ad268b RPCTypeCheck bip32derivs arg in walletcreatefunded (Gregory Sanders) 1f0c4282e961baea85d5f74d7493bd7459784391 QA: add basic walletcreatefunded optional arg test (Gregory Sanders) 1f18d7b591ffcc8bb9422a9b728bd9a0d8da6a2a walletcreatefundedpsbt: remove duplicate replaceable arg (Gregory Sanders) 2252ec50085c151e7998ca9a30cda6a33ee862b6 Allow ConstructTransaction to not throw error with 0-input txn (Gregory Sanders) Pull request description: 1) Previously an empty input argument transaction that is marked for replaceability fails to pass the `SignalsOptInRBF` check right before funding it. Explicitly check for that condition before throwing an error. 2) The rpc call had two separate `replaceable` arguments, each of which being used in mutually exclusive places. I preserved the `options` version to retain compatability with `fundtransaction`. Tree-SHA512: 26eb0c9e2d38ea51d11f741d61100223253271a084adadeb7e78c6d4e9004636f089e4273c5bf64a41bd7e9ff795317acf30531cb36aeb0d8db9304b3c8270c3		2022-03-06 14:40:40 -05:00
..
bench	merge bitcoin#19310: BerkeleyDatabase make BerkeleyDatabase::Create, CreateMock, and CreateDummy non-static functions	2022-03-06 12:30:58 +05:30
bls	refactor: fix numerous compilation warnings (#4682)	2022-02-11 19:15:26 +03:00
coinjoin	refactor: fix numerous compilation warnings (#4682)	2022-02-11 19:15:26 +03:00
compat	merge bitcoin#15146: Solve SmartOS FD_ZERO build issue	2021-12-21 12:25:17 +05:30
config
consensus	refactor: use a vector instead of map for llmqs (#4658)	2022-01-10 21:36:18 +03:00
crc32c	Merge #20603: build: Update crc32c subtree	2021-09-24 13:26:41 -04:00
crypto	Implement PKCS5_PBKDF2_HMAC_SHA512 (#4665)	2022-01-24 17:21:38 +03:00
evo	tests: (in)valid unit test vectors against IsTriviallyValid() evo calls (#4660)	2022-03-06 00:54:26 -06:00
governance	Fix "cs_main not held" in SyncObjects (#4694)	2022-02-23 12:55:37 +03:00
index	Merge #16659: refactoring: Remove unused includes	2021-12-12 16:44:54 -05:00
interfaces	merge bitcoin#18077: Add NAT-PMP port forwarding support	2022-02-26 17:49:13 +05:30
leveldb	build: enable experimental Cxx20 support (#4600)	2021-12-12 01:14:17 +03:00
llmq	tests: (in)valid unit test vectors against IsTriviallyValid() evo calls (#4660)	2022-03-06 00:54:26 -06:00
logging
masternode	Keep verified LLMQ connections (#4701)	2022-02-23 13:03:31 -06:00
node	lint: Fix typos flagged by codespell (#4639)	2021-12-29 00:45:54 +03:00
policy	Reduce MIN_STANDARD_TX_SIZE to 83 bytes (#4668)	2022-01-20 19:05:34 +03:00
primitives	Merge #16129: refactor: Remove unused includes (#4623)	2022-01-03 13:10:02 -06:00
qt	Merge pull request #4714 from kittywhiskers/db_refactor	2022-03-06 21:29:31 +03:00
rpc	Merge #15332: [Docs] Small updates to getrawtransaction description	2022-03-04 23:38:33 -05:00
script	merge bitcoin#13204: Faster sigcache nonce	2022-02-26 10:47:54 +05:30
secp256k1
support	Merge #14922: windows: Set _WIN32_WINNT to 0x0601 (Windows 7)	2022-03-04 23:38:33 -05:00
test	tests: (in)valid unit test vectors against IsTriviallyValid() evo calls (#4660)	2022-03-06 00:54:26 -06:00
univalue
util	qt: Fix Repair tab (#4715)	2022-03-05 22:44:54 +03:00
wallet	Merge #13968: [wallet] couple of walletcreatefundedpsbt fixes	2022-03-06 14:40:40 -05:00
zmq	refactor: fix numerous compilation warnings (#4682)	2022-02-11 19:15:26 +03:00
.clang-format
addrdb.cpp	Merge #21222: log: Clarify log message when file does not exist	2021-09-18 21:41:47 -04:00
addrdb.h
addressindex.h
addrman.cpp	Merge #16129: refactor: Remove unused includes (#4623)	2022-01-03 13:10:02 -06:00
addrman.h
amount.h
arith_uint256.cpp	Merge #16129: refactor: Remove unused includes (#4623)	2022-01-03 13:10:02 -06:00
arith_uint256.h	Merge #16659: refactoring: Remove unused includes	2021-12-12 16:44:54 -05:00
attributes.h
banman.cpp	Merge pull request #4435 from PastaPastaPasta/backport-trivial-pr20	2021-09-24 23:10:10 +03:00
banman.h
base58.cpp	Merge #14585: refactor: remove usage of locale dependent std::isspace	2021-09-09 10:53:54 -07:00
base58.h
batchedlogger.cpp	16659 continuation	2021-12-17 12:02:16 -05:00
batchedlogger.h
bech32.cpp
bech32.h
bip39_english.h
bip39.cpp	Implement PKCS5_PBKDF2_HMAC_SHA512 (#4665)	2022-01-24 17:21:38 +03:00
bip39.h
blockencodings.cpp
blockencodings.h	Merge #16659: refactoring: Remove unused includes	2021-12-12 16:44:54 -05:00
blockfilter.cpp	Merge #15532: Remove sharp edge (uninit member) when using the compiler-generated ctor for BlockFilter	2021-10-13 23:44:38 -05:00
blockfilter.h	Merge #15532: Remove sharp edge (uninit member) when using the compiler-generated ctor for BlockFilter	2021-10-13 23:44:38 -05:00
bloom.cpp	16659 continuation	2021-12-17 12:02:16 -05:00
bloom.h
cachemap.h	refactor: Fix warnings from cppcheck (#4625)	2021-12-29 00:54:50 +03:00
cachemultimap.h	refactor: replace instances of typedef with using in dash code (#4488)	2021-10-06 00:26:29 +03:00
chain.cpp	Merge #15670: refactor: combine Chain::findFirstBlockWithTime/findFirstBlockWithTimeAndHeight	2021-12-26 22:23:01 -05:00
chain.h	Merge #15670: refactor: combine Chain::findFirstBlockWithTime/findFirstBlockWithTimeAndHeight	2021-12-26 22:23:01 -05:00
chainparams.cpp	Revert "feat: introduce devnetVersion for devnet breaking changes; always use DGW on devnets (#4685)" (#4712)	2022-02-28 10:43:00 -06:00
chainparams.h	Revert "feat: introduce devnetVersion for devnet breaking changes; always use DGW on devnets (#4685)" (#4712)	2022-02-28 10:43:00 -06:00
chainparamsbase.cpp	merge bitcoin#16097: Add Flags enum to ArgsManager class (#4569)	2021-11-12 19:25:46 -05:00
chainparamsbase.h	Merge #16402: Remove wallet settings from chainparams	2022-01-30 18:31:00 -05:00
chainparamsseeds.h
checkqueue.h	Merge #17971: refactor: Remove redundant conditional	2021-09-18 17:15:44 -04:00
clientversion.cpp	Merge #18616: refactor: Cleanup clientversion.cpp	2021-12-28 00:27:10 -05:00
clientversion.h
coins.cpp	merge bitcoin#16355: move CCoinsViewErrorCatcher out of init.cpp	2021-10-22 08:15:38 +05:30
coins.h	merge bitcoin#16355: move CCoinsViewErrorCatcher out of init.cpp	2021-10-22 08:15:38 +05:30
compat.h	Merge #14922: windows: Set _WIN32_WINNT to 0x0601 (Windows 7)	2022-03-04 23:38:33 -05:00
compressor.cpp	Merge #16659: refactoring: Remove unused includes	2021-12-12 16:44:54 -05:00
compressor.h
core_io.h
core_memusage.h
core_read.cpp	16659 continuation	2021-12-17 12:02:16 -05:00
core_write.cpp	Merge #16129: refactor: Remove unused includes (#4623)	2022-01-03 13:10:02 -06:00
ctpl_stl.h	Fix get_future data race in ctpl (#4690)	2022-02-15 19:28:29 +03:00
cuckoocache.h
cxxtimer.hpp
dash-cli-res.rc
dash-cli.cpp	Merge #16659: refactoring: Remove unused includes	2021-12-12 16:44:54 -05:00
dash-tx-res.rc
dash-tx.cpp	Merge #19956: rpc: Improve invalid vout value rpc error message	2021-12-28 00:27:10 -05:00
dash-wallet-res.rc	Merge #13926: [Tools] bitcoin-wallet - a tool for creating and managing wallets offline	2021-11-13 11:04:56 -05:00
dash-wallet.cpp	merge bitcoin#18918: Move salvagewallet into wallettool	2022-03-06 12:30:20 +05:30
dashd-res.rc
dashd.cpp	Merge #16129: refactor: Remove unused includes (#4623)	2022-01-03 13:10:02 -06:00
dbwrapper.cpp
dbwrapper.h	refactor: Fix warnings from cppcheck (#4625)	2021-12-29 00:54:50 +03:00
dsnotificationinterface.cpp	refactor: Misc LLMQ refactoring (#4590)	2021-11-29 08:12:09 +03:00
dsnotificationinterface.h
dummywallet.cpp	Remove KeePass integration (#4628)	2021-12-22 12:53:11 +03:00
flat-database.h	refactor: Include adjustments (#4526)	2021-10-25 16:55:34 +03:00
flatfile.cpp	bitcoin#15118: Refactor block file logic	2021-08-12 12:32:29 +05:30
flatfile.h	bitcoin#15118: Refactor block file logic	2021-08-12 12:32:29 +05:30
fs.cpp	Merge #15782: Avoid redefine warning	2021-09-28 14:46:47 -04:00
fs.h
hash.cpp
hash.h	Merge #13258: uint256: Remove unnecessary crypto/common.h dependency	2021-10-21 17:41:33 +05:30
hdchain.cpp	Merge #14021: Import key origin data through descriptors in importmulti (+ changes from PRs partially merged earlier: 15368, 15749)	2022-02-18 03:42:05 +03:00
hdchain.h	Merge #14021: Import key origin data through descriptors in importmulti (+ changes from PRs partially merged earlier: 15368, 15749)	2022-02-18 03:42:05 +03:00
httprpc.cpp	Merge #16129: refactor: Remove unused includes (#4623)	2022-01-03 13:10:02 -06:00
httprpc.h	Merge #16659: refactoring: Remove unused includes	2021-12-12 16:44:54 -05:00
httpserver.cpp	16659 continuation	2021-12-17 12:02:16 -05:00
httpserver.h	Merge #16659: refactoring: Remove unused includes	2021-12-12 16:44:54 -05:00
indirectmap.h
init.cpp	Merge pull request #4638 from Munkybooty/backports-0.18-pr18	2022-03-05 12:43:14 -06:00
init.h	Merge #14437: Refactor: Start to separate wallet from node	2021-10-20 12:29:45 -04:00
key_io.cpp	16659 continuation	2021-12-17 12:02:16 -05:00
key_io.h	refactor: Include adjustments (#4526)	2021-10-25 16:55:34 +03:00
key.cpp	Merge #16129: refactor: Remove unused includes (#4623)	2022-01-03 13:10:02 -06:00
key.h
keystore.cpp	merge bitcoin#16753: extract PubKey from P2PK script with Solver	2021-12-22 19:43:18 +05:30
keystore.h
limitedmap.h
logging.cpp	merge bitcoin#16540: Add ASSERT_DEBUG_LOG to unit test framework	2022-02-26 10:37:36 +05:30
logging.h	merge bitcoin#16540: Add ASSERT_DEBUG_LOG to unit test framework	2022-02-26 10:37:36 +05:30
Makefile.am	Merge pull request #4714 from kittywhiskers/db_refactor	2022-03-06 21:29:31 +03:00
Makefile.bench.include	Merge pull request #4706 from kittywhiskers/libnatpmp	2022-03-05 11:03:44 -06:00
Makefile.crc32c.include	Merge #20603: build: Update crc32c subtree	2021-09-24 13:26:41 -04:00
Makefile.leveldb.include
Makefile.qt_locale.include	Merge #16982: build: Factor out qt translations from build system	2021-12-22 20:13:18 -05:00
Makefile.qt.include	merge bitcoin#18077: Add NAT-PMP port forwarding support	2022-02-26 17:49:13 +05:30
Makefile.qttest.include	Merge pull request #4706 from kittywhiskers/libnatpmp	2022-03-05 11:03:44 -06:00
Makefile.test_util.include	merge bitcoin#17542: Create test utility library from src/test/util	2022-02-26 10:45:13 +05:30
Makefile.test.include	tests: (in)valid unit test vectors against IsTriviallyValid() evo calls (#4660)	2022-03-06 00:54:26 -06:00
mapport.cpp	merge bitcoin#18077: Add NAT-PMP port forwarding support	2022-02-26 17:49:13 +05:30
mapport.h	merge bitcoin#18077: Add NAT-PMP port forwarding support	2022-02-26 17:49:13 +05:30
memusage.h
merkleblock.cpp	Merge #16129: refactor: Remove unused includes (#4623)	2022-01-03 13:10:02 -06:00
merkleblock.h
messagesigner.cpp	merge bitcoin#15638: Pull wallet code out of libbitcoin_server (#4560)	2021-11-16 10:19:47 -05:00
messagesigner.h
miner.cpp	Merge #15383: [rpc] mining: Omit uninitialized currentblockweight, currentblocktx	2022-02-27 13:33:36 -05:00
miner.h	Merge #15383: [rpc] mining: Omit uninitialized currentblockweight, currentblocktx	2022-02-27 13:33:36 -05:00
net_permissions.cpp
net_permissions.h
net_processing.cpp	Revert "feat: introduce devnetVersion for devnet breaking changes; always use DGW on devnets (#4685)" (#4712)	2022-02-28 10:43:00 -06:00
net_processing.h	merge bitcoin#16452: use RelayTransaction in BroadcastTransaction utility	2021-12-22 19:43:18 +05:30
net.cpp	Merge pull request #4638 from Munkybooty/backports-0.18-pr18	2022-03-05 12:43:14 -06:00
net.h	merge bitcoin#18077: Add NAT-PMP port forwarding support	2022-02-26 17:49:13 +05:30
netaddress.cpp	16659 continuation	2021-12-17 12:02:16 -05:00
netaddress.h	lint: Fix typos flagged by codespell (#4639)	2021-12-29 00:45:54 +03:00
netbase.cpp	Merge #14922: windows: Set _WIN32_WINNT to 0x0601 (Windows 7)	2022-03-04 23:38:33 -05:00
netbase.h	merge bitcoin#16566: refactor upper/lowercase functions	2021-11-01 21:41:35 +05:30
netfulfilledman.cpp	refactor: Fix warnings from cppcheck (#4625)	2021-12-29 00:54:50 +03:00
netfulfilledman.h	refactor: Fix warnings from cppcheck (#4625)	2021-12-29 00:54:50 +03:00
netmessagemaker.h
noui.cpp	merge bitcoin#16540: Add ASSERT_DEBUG_LOG to unit test framework	2022-02-26 10:37:36 +05:30
noui.h	merge bitcoin#16540: Add ASSERT_DEBUG_LOG to unit test framework	2022-02-26 10:37:36 +05:30
optional.h	Merge #15292: Remove 'boost::optional'-related false positive -Wmaybe-uninitialized warnings on GCC compiler (#4635)	2021-12-22 12:59:27 +03:00
pow.cpp	16659 continuation	2021-12-17 12:02:16 -05:00
pow.h
prevector.h	refactor: fix numerous compilation warnings (#4682)	2022-02-11 19:15:26 +03:00
protocol.cpp	Merge #19112: rpc: Remove special case for unknown service flags	2021-12-28 00:27:10 -05:00
protocol.h	Merge #16995: Fix gcc 9 warnings	2021-12-28 00:27:09 -05:00
psbt.cpp	Merge #15408: Remove unused TransactionError constants	2021-09-30 16:18:49 -07:00
psbt.h	16659 continuation	2021-12-17 12:02:16 -05:00
pubkey.cpp
pubkey.h
random.cpp	build: allow building without openssl, enables native m1 development builds (#4683)	2022-02-13 11:50:23 +03:00
random.h	Merge #15250: Use RdSeed when available, and reduce RdRand load	2021-09-16 13:34:59 +03:00
rest.cpp	Merge #16659: refactoring: Remove unused includes	2021-12-12 16:44:54 -05:00
reverse_iterator.h
saltedhasher.cpp
saltedhasher.h
scheduler.cpp	partial Merge #18234: refactor: Replace boost::mutex,condition_var,chrono with std equivalents in scheduler	2021-09-28 19:42:22 -04:00
scheduler.h	partial Merge #19090: refactor: Misc scheduler cleanups	2021-09-28 19:42:27 -04:00
serialize.h	refactor: fix numerous compilation warnings (#4682)	2022-02-11 19:15:26 +03:00
shutdown.cpp
shutdown.h
span.h
spentindex.h
spork.cpp	util: add ranges.h to emulate c++20 std::ranges (#4622)	2021-12-21 15:05:29 +03:00
spork.h	refactor: misc spork refactoring (#4620)	2021-12-17 20:22:11 +03:00
stacktraces.cpp	refactor: fix numerous compilation warnings (#4682)	2022-02-11 19:15:26 +03:00
stacktraces.h
statsd_client.cpp	refactor: Fix warnings from cppcheck (#4625)	2021-12-29 00:54:50 +03:00
statsd_client.h	refactor: Fix warnings from cppcheck (#4625)	2021-12-29 00:54:50 +03:00
streams.h	Merge #16659: refactoring: Remove unused includes	2021-12-12 16:44:54 -05:00
sync.cpp	Merge #16659: refactoring: Remove unused includes	2021-12-12 16:44:54 -05:00
sync.h	merge bitcoin#19340: Preserve the LockData initial state if "potential deadlock detected" exception thrown	2021-10-12 19:48:19 -04:00
threadinterrupt.cpp
threadinterrupt.h	Merge #16659: refactoring: Remove unused includes	2021-12-12 16:44:54 -05:00
threadsafety.h	Merge #14437: Refactor: Start to separate wallet from node	2021-10-20 12:29:45 -04:00
timedata.cpp	Merge #16129: refactor: Remove unused includes (#4623)	2022-01-03 13:10:02 -06:00
timedata.h
tinyformat.h	Merge bitcoin#16205: Refactor: Replace fprintf with tfm::format (#4531)	2021-10-24 13:51:47 +03:00
torcontrol.cpp	Merge #16186: doc/lint: Fix spelling errors identified by codespell 1.15.0	2021-10-05 20:34:00 +03:00
torcontrol.h	Merge #16659: refactoring: Remove unused includes	2021-12-12 16:44:54 -05:00
txdb.cpp	Merge #16129: refactor: Remove unused includes (#4623)	2022-01-03 13:10:02 -06:00
txdb.h	Merge #16659: refactoring: Remove unused includes	2021-12-12 16:44:54 -05:00
txmempool.cpp	Merge #16129: refactor: Remove unused includes (#4623)	2022-01-03 13:10:02 -06:00
txmempool.h	Merge #15323: rpc: Expose g_is_mempool_loaded via getmempoolinfo	2021-12-25 18:32:19 +05:30
ui_interface.cpp	Merge #16129: refactor: Remove unused includes (#4623)	2022-01-03 13:10:02 -06:00
ui_interface.h	Merge #16659: refactoring: Remove unused includes	2021-12-12 16:44:54 -05:00
uint256.cpp	Merge #16659: refactoring: Remove unused includes	2021-12-12 16:44:54 -05:00
uint256.h	Merge #16659: refactoring: Remove unused includes	2021-12-12 16:44:54 -05:00
undo.h
unordered_lru_cache.h	Fix error int64_t was not declared (#4419)	2021-09-13 12:56:35 -04:00
validation.cpp	merge bitcoin#13204: Faster sigcache nonce	2022-02-26 10:47:54 +05:30
validation.h	Merge #15383: [rpc] mining: Omit uninitialized currentblockweight, currentblocktx	2022-02-27 13:33:36 -05:00
validationinterface.cpp	Merge #16129: refactor: Remove unused includes (#4623)	2022-01-03 13:10:02 -06:00
validationinterface.h	refactor: fix numerous compilation warnings (#4682)	2022-02-11 19:15:26 +03:00
version.h	feat: Implement support for P2SH payouts for proposals (#4672)	2022-02-02 12:08:05 +03:00
versionbits.cpp	Merge #16587: doc: Improve versionbits.h documentation	2021-11-16 07:13:48 +05:30
versionbits.h	Merge #16587: doc: Improve versionbits.h documentation	2021-11-16 07:13:48 +05:30
versionbitsinfo.cpp	governance: Implement reduced governance fee (#4241)	2021-11-01 18:31:48 +03:00
versionbitsinfo.h	merge bitcoin#13311: Don't edit Chainparams after initialization (#4362)	2021-09-03 01:36:11 +03:00
walletinitinterface.h	Remove KeePass integration (#4628)	2021-12-22 12:53:11 +03:00
warnings.cpp	Merge #16129: refactor: Remove unused includes (#4623)	2022-01-03 13:10:02 -06:00
warnings.h	Merge #16659: refactoring: Remove unused includes	2021-12-12 16:44:54 -05:00