dash/qa/rpc-tests
Alexander Block c3602372cc Implement retroactive IS locking of transactions first seen in blocks instead of mempool (#2770)
* Don't rely on UTXO set in CheckCanLock

The UTXO set only works for TXs in the mempool and won't work when we try
to retroactively lock unlocked TXs from blocks.

This is safe as ProcessTx is only called when a TX was accepted into the
mempool or connected in a block, which means that all input checks were
good.

* Rename RetryLockMempoolTxs to RetryLockTxs and let it retry connected TXs

* Instead of manually calling ProcessTx, let SyncTransaction handle all cases

SyncTransaction is called from AcceptToMemoryPool and when transactions got
connected in a block. So this is the time we want to run TXs through
ProcessTx. This also enables retroactive signing of TXs that were unknown
before a new block appeared.

* Test retroactive signing and safe TXs in LLMQ ChainLocks tests

* Also test for retroactive signing of chained TXs

* Honor lockedParentTx when looking for TXs to retry signing

* Stop scanning for TXs to retry after a depth of 6

* Generate 6 block to avoid retroactive signing overloading Travis

* Avoid retroactive signing

* Don't rely on NewPoWValidBlock and use SyncTransaction to build blockTxs

NewPoWValidBlock is not guaranteed to be called when blocks come in fast.
When a block is accepted in AcceptBlock, NewPoWValidBlock is only called
when the new block is a successor of the currently active tip. This is not
the case when after the first block a second block is accepted immediately
as the first block is not connected yet.

This might be a bug actually in the handling of NewPoWValidBlock, so we
might need to check/fix this later, but currently I prefer to not touch
that part.

Instead, we now use SyncTransaction to gather TXs for blockTxs. This works
because SyncTransaction is called for all transactions in a freshly
connected block in one go. The call also happens before UpdatedBlockTip is
called, so it's fine with the existing logic.

* Use tx.IsCoinBase() instead of checking index 0

Also check for empty vin.
2019-03-19 13:55:51 +03:00
..
test_framework Multiple refactorings/fixes for LLMQ bases InstantSend and ChainLocks (#2779) 2019-03-19 10:38:16 +03:00
.gitignore
abandonconflict.py Merge bitcoin#9602: Remove coin age priority and free transactions - implementation (#2768) 2019-03-14 17:44:42 +03:00
addressindex.py Fix tests after 2768 (#2772) 2019-03-15 07:18:16 +01:00
assumevalid.py Merge #9768: [qa] Add logging to test_framework.py 2019-02-26 15:54:32 -06:00
autois-mempool.py Implement retroactive IS locking of transactions first seen in blocks instead of mempool (#2770) 2019-03-19 13:55:51 +03:00
bip9-softforks.py Merge #9768: [qa] Add logging to test_framework.py 2019-02-26 15:54:32 -06:00
bip65-cltv-p2p.py Merge #9768: [qa] Add logging to test_framework.py 2019-02-26 15:54:32 -06:00
bip65-cltv.py Backports 0.15 pr2 (#2597) 2019-01-07 12:55:35 +03:00
bip68-112-113-p2p.py code review and reset file perms 2019-03-03 20:50:39 -06:00
bip68-sequence.py Merge bitcoin#9602: Remove coin age priority and free transactions - implementation (#2768) 2019-03-14 17:44:42 +03:00
bipdersig-p2p.py Merge #9768: [qa] Add logging to test_framework.py 2019-02-26 15:54:32 -06:00
bipdersig.py Backports 0.15 pr2 (#2597) 2019-01-07 12:55:35 +03:00
blockchain.py Revert "Fix use of missing self.log in blockchain.py" 2019-03-08 14:22:49 -06:00
create_cache.py Backports 0.15 pr2 (#2597) 2019-01-07 12:55:35 +03:00
decodescript.py Backports 0.15 pr2 (#2597) 2019-01-07 12:55:35 +03:00
dip3-deterministicmns.py Move simple PoSe tests into llmq-simplepose.py 2019-03-12 07:02:52 +01:00
disablewallet.py Backports 0.15 pr2 (#2597) 2019-01-07 12:55:35 +03:00
forknotify.py Backports 0.15 pr2 (#2597) 2019-01-07 12:55:35 +03:00
fundrawtransaction-hd.py Use logging framework in Dash specific tests 2019-03-08 14:22:40 -06:00
fundrawtransaction.py Merge #9768: [qa] Add logging to test_framework.py 2019-02-26 15:54:32 -06:00
getblocktemplate_longpoll.py code review and reset file perms 2019-03-03 20:50:39 -06:00
getblocktemplate_proposals.py Backports 0.15 pr2 (#2597) 2019-01-07 12:55:35 +03:00
getchaintips.py Backports 0.15 pr2 (#2597) 2019-01-07 12:55:35 +03:00
httpbasics.py Backports 0.15 pr2 (#2597) 2019-01-07 12:55:35 +03:00
import-rescan.py Merge #9768: [qa] Add logging to test_framework.py 2019-02-26 15:54:32 -06:00
importmulti.py Merge #9768: [qa] Add logging to test_framework.py 2019-02-26 15:54:32 -06:00
importprunedfunds.py Merge #9768: [qa] Add logging to test_framework.py 2019-02-26 15:54:32 -06:00
invalidateblock.py Merge #9768: [qa] Add logging to test_framework.py 2019-02-26 15:54:32 -06:00
invalidblockrequest.py Backports 0.15 pr2 (#2597) 2019-01-07 12:55:35 +03:00
invalidtxrequest.py Backports 0.15 pr2 (#2597) 2019-01-07 12:55:35 +03:00
keypool-hd.py Run tests in mocked time (#2031) 2018-04-18 14:48:59 +03:00
keypool.py Backports 0.15 pr2 (#2597) 2019-01-07 12:55:35 +03:00
listsinceblock.py Merge #9768: [qa] Add logging to test_framework.py 2019-02-26 15:54:32 -06:00
listtransactions.py reset file perms 2019-02-26 16:50:25 -06:00
llmq-chainlocks.py Implement retroactive IS locking of transactions first seen in blocks instead of mempool (#2770) 2019-03-19 13:55:51 +03:00
llmq-signing.py Use smaller (3 out of 5) quorums for regtest/Travis (#2774) 2019-03-15 11:48:24 +03:00
llmq-simplepose.py Use smaller (3 out of 5) quorums for regtest/Travis (#2774) 2019-03-15 11:48:24 +03:00
maxblocksinflight.py Merge #9972: Fix extended rpc tests broken by #9768 2019-02-26 16:41:00 -06:00
maxuploadtarget.py code review and reset file perms 2019-03-03 20:50:39 -06:00
mempool_limit.py Merge #9768: [qa] Add logging to test_framework.py 2019-02-26 15:54:32 -06:00
mempool_packages.py Merge bitcoin#9602: Remove coin age priority and free transactions - implementation (#2768) 2019-03-14 17:44:42 +03:00
mempool_reorg.py Merge #9768: [qa] Add logging to test_framework.py 2019-02-26 15:54:32 -06:00
mempool_resurrect_test.py Merge #9768: [qa] Add logging to test_framework.py 2019-02-26 15:54:32 -06:00
mempool_spendcoinbase.py Fix tests after 2768 (#2772) 2019-03-15 07:18:16 +01:00
merkle_blocks.py Fix tests after 2768 (#2772) 2019-03-15 07:18:16 +01:00
multi_rpc.py Backports 0.15 pr2 (#2597) 2019-01-07 12:55:35 +03:00
multikeysporks.py Use logging framework in Dash specific tests 2019-03-08 14:22:40 -06:00
nodehandling.py Merge #9853: Fix error codes from various RPCs 2019-02-05 13:40:40 -06:00
nulldummy.py code review and reset file perms 2019-03-03 20:50:39 -06:00
p2p-acceptblock.py Merge #9768: [qa] Add logging to test_framework.py 2019-02-26 15:54:32 -06:00
p2p-autoinstantsend.py Implement retroactive IS locking of transactions first seen in blocks instead of mempool (#2770) 2019-03-19 13:55:51 +03:00
p2p-compactblocks.py code review and reset file perms 2019-03-03 20:50:39 -06:00
p2p-fingerprint.py Add compatibility code to P2PFingerprintTest until we catch up with backports 2019-03-12 10:43:47 +01:00
p2p-fullblocktest.py Backports 0.15 pr2 (#2597) 2019-01-07 12:55:35 +03:00
p2p-instantsend.py Implement retroactive IS locking of transactions first seen in blocks instead of mempool (#2770) 2019-03-19 13:55:51 +03:00
p2p-leaktests.py Merge #9768: [qa] Add logging to test_framework.py 2019-02-26 15:54:32 -06:00
p2p-mempool.py Merge #9768: [qa] Add logging to test_framework.py 2019-02-26 15:54:32 -06:00
p2p-timeouts.py Merge #9768: [qa] Add logging to test_framework.py 2019-02-26 15:54:32 -06:00
p2p-versionbits-warning.py Merge #9768: [qa] Add logging to test_framework.py 2019-02-26 15:54:32 -06:00
preciousblock.py Merge #9768: [qa] Add logging to test_framework.py 2019-02-26 15:54:32 -06:00
prioritise_transaction.py Fix tests after 2768 (#2772) 2019-03-15 07:18:16 +01:00
proxy_test.py Merge #9768: [qa] Add logging to test_framework.py 2019-02-26 15:54:32 -06:00
pruning.py Merge #9972: Fix extended rpc tests broken by #9768 2019-02-26 16:41:00 -06:00
rawtransactions.py Merge #9853: Fix error codes from various RPCs 2019-02-05 13:40:40 -06:00
README.md test: remove necessity to call create_callback_map 2015-12-07 12:45:14 +01:00
receivedby.py Backports 0.15 pr2 (#2597) 2019-01-07 12:55:35 +03:00
reindex.py Merge #9768: [qa] Add logging to test_framework.py 2019-02-26 15:54:32 -06:00
rest.py Merge #9768: [qa] Add logging to test_framework.py 2019-02-26 15:54:32 -06:00
rpcbind_test.py Merge #9768: [qa] Add logging to test_framework.py 2019-02-26 15:54:32 -06:00
rpcnamedargs.py Backports 0.15 pr2 (#2597) 2019-01-07 12:55:35 +03:00
sendheaders.py Merge #11580: Do not send (potentially) invalid headers in response to getheaders 2019-03-12 10:43:47 +01:00
signmessages.py Backports 0.15 pr2 (#2597) 2019-01-07 12:55:35 +03:00
signrawtransactions.py Backports 0.15 pr2 (#2597) 2019-01-07 12:55:35 +03:00
smartfees.py Merge bitcoin#9602: Remove coin age priority and free transactions - implementation (#2768) 2019-03-14 17:44:42 +03:00
spentindex.py Fix tests after 2768 (#2772) 2019-03-15 07:18:16 +01:00
sporks.py Use logging framework in Dash specific tests 2019-03-08 14:22:40 -06:00
timestampindex.py Use logging framework in Dash specific tests 2019-03-08 14:22:40 -06:00
txindex.py Use logging framework in Dash specific tests 2019-03-08 14:22:40 -06:00
txn_clone.py Backports 0.15 pr2 (#2597) 2019-01-07 12:55:35 +03:00
txn_doublespend.py Backports 0.15 pr2 (#2597) 2019-01-07 12:55:35 +03:00
wallet-accounts.py Backports 0.15 pr2 (#2597) 2019-01-07 12:55:35 +03:00
wallet-dump.py Backports 0.15 pr2 (#2597) 2019-01-07 12:55:35 +03:00
wallet-hd.py code review and reset file perms 2019-03-03 20:50:39 -06:00
wallet.py Fix tests after 2768 (#2772) 2019-03-15 07:18:16 +01:00
walletbackup.py Merge #9768: [qa] Add logging to test_framework.py 2019-02-26 15:54:32 -06:00
zapwallettxes.py Merge #9768: [qa] Add logging to test_framework.py 2019-02-26 15:54:32 -06:00
zmq_test.py Merge #9768: [qa] Add logging to test_framework.py 2019-02-26 15:54:32 -06:00

Regression tests

test_framework/authproxy.py

Taken from the python-bitcoinrpc repository.

test_framework/test_framework.py

Base class for new regression tests.

test_framework/util.py

Generally useful functions.

test_framework/mininode.py

Basic code to support p2p connectivity to a bitcoind.

test_framework/comptool.py

Framework for comparison-tool style, p2p tests.

test_framework/script.py

Utilities for manipulating transaction scripts (originally from python-bitcoinlib)

test_framework/blockstore.py

Implements disk-backed block and tx storage.

test_framework/key.py

Wrapper around OpenSSL EC_Key (originally from python-bitcoinlib)

test_framework/bignum.py

Helpers for script.py

test_framework/blocktools.py

Helper functions for creating blocks and transactions.

P2P test design notes

Mininode

  • mininode.py contains all the definitions for objects that pass over the network (CBlock, CTransaction, etc, along with the network-level wrappers for them, msg_block, msg_tx, etc).

  • P2P tests have two threads. One thread handles all network communication with the bitcoind(s) being tested (using python's asyncore package); the other implements the test logic.

  • NodeConn is the class used to connect to a bitcoind. If you implement a callback class that derives from NodeConnCB and pass that to the NodeConn object, your code will receive the appropriate callbacks when events of interest arrive.

  • You can pass the same handler to multiple NodeConn's if you like, or pass different ones to each -- whatever makes the most sense for your test.

  • Call NetworkThread.start() after all NodeConn objects are created to start the networking thread. (Continue with the test logic in your existing thread.)

  • RPC calls are available in p2p tests.

  • Can be used to write free-form tests, where specific p2p-protocol behavior is tested. Examples: p2p-accept-block.py, maxblocksinflight.py.

Comptool

  • Testing framework for writing tests that compare the block/tx acceptance behavior of a bitcoind against 1 or more other bitcoind instances, or against known outcomes, or both.

  • Set the num_nodes variable (defined in ComparisonTestFramework) to start up 1 or more nodes. If using 1 node, then --testbinary can be used as a command line option to change the bitcoind binary used by the test. If using 2 or more nodes, then --refbinary can be optionally used to change the bitcoind that will be used on nodes 2 and up.

  • Implement a (generator) function called get_tests() which yields TestInstances. Each TestInstance consists of:

    • a list of [object, outcome, hash] entries
      • object is a CBlock, CTransaction, or CBlockHeader. CBlock's and CTransaction's are tested for acceptance. CBlockHeaders can be used so that the test runner can deliver complete headers-chains when requested from the bitcoind, to allow writing tests where blocks can be delivered out of order but still processed by headers-first bitcoind's.
      • outcome is True, False, or None. If True or False, the tip is compared with the expected tip -- either the block passed in, or the hash specified as the optional 3rd entry. If None is specified, then the test will compare all the bitcoind's being tested to see if they all agree on what the best tip is.
      • hash is the block hash of the tip to compare against. Optional to specify; if left out then the hash of the block passed in will be used as the expected tip. This allows for specifying an expected tip while testing the handling of either invalid blocks or blocks delivered out of order, which complete a longer chain.
    • sync_every_block: True/False. If False, then all blocks are inv'ed together, and the test runner waits until the node receives the last one, and tests only the last block for tip acceptance using the outcome and specified tip. If True, then each block is tested in sequence and synced (this is slower when processing many blocks).
    • sync_every_transaction: True/False. Analogous to sync_every_block, except if the outcome on the last tx is "None", then the contents of the entire mempool are compared across all bitcoind connections. If True or False, then only the last tx's acceptance is tested against the given outcome.
  • For examples of tests written in this framework, see invalidblockrequest.py and p2p-fullblocktest.py.