mirror of
https://github.com/dashpay/dash.git
synced 2024-12-26 20:42:59 +01:00
eba325d7a2
Backport notice:
- data have real blocks from testnet
- due to big gap in blocks before checkpoints (half-year) for sack of this test is added one more checkpoint, otherwise blocks are not accepted due to non-mockable time for other chains except regtest
- data for 2 blocks in split chain are generated locally for testnet
--------------
333317ce6b67aa92f7363d48cd750712190b4b6b test: Test that low difficulty chain fork is rejected (MarcoFalke)
fa31dc1bf4ee471c4641eef8de02702ba0619ae7 test: Pass down correct chain name in tests (MarcoFalke)
Pull request description:
To prevent OOM, Bitcoin Core will reject chain forks at low difficulty by default. This is the only use-case of checkpoints, so add a test for it to make sure the feature works as expected. If it didn't work, checkpoints would have no use-case and we might as well remove them
ACKs for top commit:
Sjors:
Thanks for adding the node 1 example. Code review ACK 333317c
Tree-SHA512: 90dffa540d0904f3cffb61d2382b1a26f84fe9560b7013e4461546383add31a8757b350616a6d43217c59ef7b8b2a1b62bb3bab582c679cbb2c660a782ce7be1
90 lines
3.8 KiB
Python
Executable File
90 lines
3.8 KiB
Python
Executable File
#!/usr/bin/env python3
|
|
# Copyright (c) 2019 The Bitcoin Core developers
|
|
# Distributed under the MIT software license, see the accompanying
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
"""Test that we reject low difficulty headers to prevent our block tree from filling up with useless bloat"""
|
|
|
|
from test_framework.blocktools import filter_tip_keys
|
|
|
|
from test_framework.messages import (
|
|
CBlockHeader,
|
|
from_hex,
|
|
)
|
|
from test_framework.p2p import (
|
|
P2PInterface,
|
|
msg_headers,
|
|
)
|
|
from test_framework.test_framework import BitcoinTestFramework
|
|
|
|
import os
|
|
|
|
class RejectLowDifficultyHeadersTest(BitcoinTestFramework):
|
|
def set_test_params(self):
|
|
self.setup_clean_chain = True
|
|
self.chain = 'testnet3' # Use testnet chain because it has an early checkpoint
|
|
self.num_nodes = 2
|
|
|
|
def add_options(self, parser):
|
|
parser.add_argument(
|
|
'--datafile',
|
|
default='data/blockheader_testnet3.hex',
|
|
help='Test data file (default: %(default)s)',
|
|
)
|
|
|
|
def run_test(self):
|
|
self.log.info("Read headers data")
|
|
self.headers_file_path = os.path.join(os.path.dirname(os.path.realpath(__file__)), self.options.datafile)
|
|
with open(self.headers_file_path, encoding='utf-8') as headers_data:
|
|
h_lines = [l.strip() for l in headers_data.readlines()]
|
|
|
|
# The headers data is taken from testnet3 for early blocks from genesis until the first checkpoint. There are
|
|
# two headers with valid POW at height 1 and 2, forking off from genesis. They are indicated by the FORK_PREFIX.
|
|
FORK_PREFIX = 'fork:'
|
|
self.headers = [l for l in h_lines if not l.startswith(FORK_PREFIX)]
|
|
self.headers_fork = [l[len(FORK_PREFIX):] for l in h_lines if l.startswith(FORK_PREFIX)]
|
|
|
|
self.headers = [from_hex(CBlockHeader(), h) for h in self.headers]
|
|
self.headers_fork = [from_hex(CBlockHeader(), h) for h in self.headers_fork]
|
|
|
|
self.log.info("Feed all non-fork headers, including and up to the first checkpoint")
|
|
peer_checkpoint = self.nodes[0].add_p2p_connection(P2PInterface())
|
|
peer_checkpoint.send_and_ping(msg_headers(self.headers))
|
|
|
|
assert {
|
|
'height': 255,
|
|
'hash': '0000080b600e06f4c07880673f027210f9314575f5f875fafe51971e268b886a',
|
|
'branchlen': 255,
|
|
'status': 'headers-only',
|
|
} in filter_tip_keys(self.nodes[0].getchaintips())
|
|
|
|
self.log.info("Feed all fork headers (fails due to checkpoint)")
|
|
with self.nodes[0].assert_debug_log(['bad-fork-prior-to-checkpoint']):
|
|
peer_checkpoint.send_message(msg_headers(self.headers_fork))
|
|
peer_checkpoint.wait_for_disconnect()
|
|
|
|
self.log.info("Feed all fork headers (succeeds without checkpoint)")
|
|
# On node 0 it succeeds because checkpoints are disabled
|
|
self.restart_node(0, extra_args=['-nocheckpoints'])
|
|
peer_no_checkpoint = self.nodes[0].add_p2p_connection(P2PInterface())
|
|
peer_no_checkpoint.send_and_ping(msg_headers(self.headers_fork))
|
|
assert {
|
|
"height": 2,
|
|
"hash": "00000d3aca6b09e1e0a91196f53654e08eb7bfc897ffbf24040c7686584f0209",
|
|
"branchlen": 2,
|
|
"status": "headers-only",
|
|
} in filter_tip_keys(self.nodes[0].getchaintips())
|
|
|
|
# On node 1 it succeeds because no checkpoint has been reached yet by a chain tip
|
|
peer_before_checkpoint = self.nodes[1].add_p2p_connection(P2PInterface())
|
|
peer_before_checkpoint.send_and_ping(msg_headers(self.headers_fork))
|
|
assert {
|
|
"height": 2,
|
|
"hash": "00000d3aca6b09e1e0a91196f53654e08eb7bfc897ffbf24040c7686584f0209",
|
|
"branchlen": 2,
|
|
"status": "headers-only",
|
|
} in filter_tip_keys(self.nodes[0].getchaintips())
|
|
|
|
|
|
if __name__ == '__main__':
|
|
RejectLowDifficultyHeadersTest().main()
|