mirror of
https://github.com/dashpay/dash.git
synced 2024-12-26 20:42:59 +01:00
1ff42b40e3
bb822a7af86897a9b6a5d616f193c258e8e76729 wallet, rpc: add listdescriptors private option (S3RK)
Pull request description:
Rationale: make it possible to backup your wallet with `listdescriptors` command
* The default behaviour is still to show public version
* For private version only the root xprv is returned
Example use-case:
```
> bitcoin-cli -regtest -named createwallet wallet_name=old descriptors=true
> bitcoin-cli -regtest -rpcwallet=old listdescriptors true | jq '.descriptors' > descriptors.txt
> bitcoin-cli -regtest -named createwallet wallet_name=new descriptors=true blank=true
> bitcoin-cli -regtest -rpcwallet=new importdescriptors "$(cat descriptors.txt)"
```
In case of watch-only wallet without private keys there will be following output:
```
error code: -4
error message:
Can't get descriptor string.
```
ACKs for top commit:
achow101:
re-ACK bb822a7af86897a9b6a5d616f193c258e8e76729
Rspigler:
tACK bb822a7af86897a9b6a5d616f193c258e8e76729
jonatack:
ACK bb822a7af86897a9b6a5d616f193c258e8e76729 per `git diff 2854ddc bb822a7`
prayank23:
tACK bb822a7af8
meshcollider:
Code review ACK bb822a7af86897a9b6a5d616f193c258e8e76729
Tree-SHA512: f6dddc72a74e5667071ccd77f8dce578382e8e29e7ed6a0834ac2e114a6d3918b59c2f194f4079b3259e13d9ba3b4f405619940c3ecb7a1a0344615aed47c43d
128 lines
5.3 KiB
Python
Executable File
128 lines
5.3 KiB
Python
Executable File
#!/usr/bin/env python3
|
|
# Copyright (c) 2014-2021 The Bitcoin Core developers
|
|
# Distributed under the MIT software license, see the accompanying
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
"""Test the listdescriptors RPC."""
|
|
|
|
from test_framework.descriptors import (
|
|
descsum_create
|
|
)
|
|
from test_framework.test_framework import BitcoinTestFramework
|
|
from test_framework.util import (
|
|
assert_equal,
|
|
assert_raises_rpc_error,
|
|
)
|
|
|
|
|
|
class ListDescriptorsTest(BitcoinTestFramework):
|
|
def set_test_params(self):
|
|
self.num_nodes = 1
|
|
|
|
def skip_test_if_missing_module(self):
|
|
self.skip_if_no_wallet()
|
|
self.skip_if_no_sqlite()
|
|
|
|
# do not create any wallet by default
|
|
def init_wallet(self, i):
|
|
return
|
|
|
|
def run_test(self):
|
|
node = self.nodes[0]
|
|
assert_raises_rpc_error(-18, 'No wallet is loaded.', node.listdescriptors)
|
|
|
|
if self.is_bdb_compiled():
|
|
self.log.info('Test that the command is not available for legacy wallets.')
|
|
node.createwallet(wallet_name='w1', descriptors=False)
|
|
assert_raises_rpc_error(-4, 'listdescriptors is not available for non-descriptor wallets', node.listdescriptors)
|
|
|
|
self.log.info('Test the command for empty descriptors wallet.')
|
|
node.createwallet(wallet_name='w2', blank=True, descriptors=True)
|
|
assert_equal(0, len(node.get_wallet_rpc('w2').listdescriptors()['descriptors']))
|
|
|
|
self.log.info('Test the command for a default descriptors wallet.')
|
|
node.createwallet(wallet_name='w3', descriptors=True)
|
|
result = node.get_wallet_rpc('w3').listdescriptors()
|
|
assert_equal("w3", result['wallet_name'])
|
|
assert_equal(2, len(result['descriptors']))
|
|
assert_equal(2, len([d for d in result['descriptors'] if d['active']]))
|
|
assert_equal(1, len([d for d in result['descriptors'] if d['internal']]))
|
|
for item in result['descriptors']:
|
|
assert item['desc'] != ''
|
|
assert item['next'] == 0
|
|
assert item['range'] == [0, 0]
|
|
assert item['timestamp'] is not None
|
|
|
|
self.log.info('Test descriptors with hardened derivations are listed in importable form.')
|
|
xprv = 'tprv8ZgxMBicQKsPeuVhWwi6wuMQGfPKi9Li5GtX35jVNknACgqe3CY4g5xgkfDDJcmtF7o1QnxWDRYw4H5P26PXq7sbcUkEqeR4fg3Kxp2tigg'
|
|
xpub_acc = 'tpubDCMVLhErorrAGfApiJSJzEKwqeaf2z3NrkVMxgYQjZLzMjXMBeRw2muGNYbvaekAE8rUFLftyEar4LdrG2wXyyTJQZ26zptmeTEjPTaATts'
|
|
hardened_path = '/84\'/1\'/0\''
|
|
wallet = node.get_wallet_rpc('w2')
|
|
wallet.importdescriptors([{
|
|
'desc': descsum_create('pkh(' + xprv + hardened_path + '/0/*)'),
|
|
'timestamp': 1296688602,
|
|
}])
|
|
expected = {
|
|
'wallet_name': 'w2',
|
|
'descriptors': [
|
|
{'desc': descsum_create('pkh([80002067' + hardened_path + ']' + xpub_acc + '/0/*)'),
|
|
'timestamp': 1296688602,
|
|
'active': False,
|
|
'range': [0, 0],
|
|
'next': 0},
|
|
],
|
|
}
|
|
assert_equal(expected, wallet.listdescriptors())
|
|
assert_equal(expected, wallet.listdescriptors(False))
|
|
|
|
self.log.info('Test list private descriptors')
|
|
expected_private = {
|
|
'wallet_name': 'w2',
|
|
'descriptors': [
|
|
{'desc': descsum_create('pkh(' + xprv + hardened_path + '/0/*)'),
|
|
'timestamp': 1296688602,
|
|
'active': False,
|
|
'range': [0, 0],
|
|
'next': 0},
|
|
],
|
|
}
|
|
assert_equal(expected_private, wallet.listdescriptors(True))
|
|
|
|
self.log.info("Test listdescriptors with encrypted wallet")
|
|
wallet.encryptwallet("pass")
|
|
assert_equal(expected, wallet.listdescriptors())
|
|
|
|
self.log.info('Test list private descriptors with encrypted wallet')
|
|
assert_raises_rpc_error(-13, 'Please enter the wallet passphrase with walletpassphrase first.', wallet.listdescriptors, True)
|
|
wallet.walletpassphrase(passphrase="pass", timeout=1000000)
|
|
assert_equal(expected_private, wallet.listdescriptors(True))
|
|
|
|
self.log.info('Test list private descriptors with watch-only wallet')
|
|
node.createwallet(wallet_name='watch-only', descriptors=True, disable_private_keys=True)
|
|
watch_only_wallet = node.get_wallet_rpc('watch-only')
|
|
watch_only_wallet.importdescriptors([{
|
|
'desc': descsum_create('pkh(' + xpub_acc + ')'),
|
|
'timestamp': 1296688602,
|
|
}])
|
|
assert_raises_rpc_error(-4, 'Can\'t get descriptor string', watch_only_wallet.listdescriptors, True)
|
|
|
|
self.log.info('Test non-active non-range combo descriptor')
|
|
node.createwallet(wallet_name='w4', blank=True, descriptors=True)
|
|
wallet = node.get_wallet_rpc('w4')
|
|
wallet.importdescriptors([{
|
|
'desc': descsum_create('combo(' + node.get_deterministic_priv_key().key + ')'),
|
|
'timestamp': 1296688602,
|
|
}])
|
|
expected = {
|
|
'wallet_name': 'w4',
|
|
'descriptors': [
|
|
{'active': False,
|
|
'desc': 'combo(038af19f35924e37ad7c3c8045d1e19b9b90b7310e08b892e620c253a102fe49f0)#2j2j0825',
|
|
'timestamp': 1296688602},
|
|
]
|
|
}
|
|
assert_equal(expected, wallet.listdescriptors())
|
|
|
|
|
|
if __name__ == '__main__':
|
|
ListDescriptorsTest().main()
|