mirror of
https://github.com/dashpay/dash.git
synced 2024-12-27 13:03:17 +01:00
6dbc9aba0d
5ac804a9eb0cdbdcff8b50ecfb736f8793cab805 tests: Use a default of supports_cli=True (instead of supports_cli=False) (practicalswift)
993e38a4e2fa66093314b988dfbe459f46aa5864 tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such (practicalswift)
Pull request description:
Annotate functional tests supporting `bitcoin-cli` (`--usecli`) as such.
Prior to this commit 74 tests were unnecessarily skipped when running `test_runner.py --usecli`.
Before [bitcoin original commit stats]:
```
$ test/functional/test_runner.py --usecli > /dev/null 2>&1
$ echo $?
0
$ test/functional/test_runner.py --usecli 2>&1 | cut -f2 -d'|' | \
grep -E ' (Passed|Skipped) *$' | sort | uniq -c
9 ✓ Passed
126 ○ Skipped
```
After [dash numbers]:
```
$ test/functional/test_runner.py --usecli > /dev/null 2>&1
$ echo $?
0
$ test/functional/test_runner.py --usecli 2>&1 | cut -f2 -d'|' | \
grep -E ' (Passed|Skipped) *$' | sort | uniq -c
110 ✓ Passed
51 ○ Skipped
```
Context: `--usecli` was introduced in f6ade9ce1a
ACKs for top commit:
laanwj:
Code review ACK 5ac804a9eb0cdbdcff8b50ecfb736f8793cab805
Tree-SHA512: 249c0b691a74cf201c729df86c3db2b3faefa53b94703941e566943d252c6d14924e935a8da4f592951574235923fbb7cd22612a5e7e02ff6c762c55a2320ca3
75 lines
3.4 KiB
Python
Executable File
75 lines
3.4 KiB
Python
Executable File
#!/usr/bin/env python3
|
|
# Copyright (c) 2014-2016 The Bitcoin Core developers
|
|
# Distributed under the MIT software license, see the accompanying
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
"""Test mempool limiting together/eviction with the wallet."""
|
|
|
|
from decimal import Decimal
|
|
|
|
from test_framework.test_framework import BitcoinTestFramework
|
|
from test_framework.util import assert_equal, assert_greater_than, assert_raises_rpc_error, create_confirmed_utxos, create_lots_of_big_transactions, gen_return_txouts
|
|
|
|
class MempoolLimitTest(BitcoinTestFramework):
|
|
def set_test_params(self):
|
|
self.setup_clean_chain = True
|
|
self.num_nodes = 1
|
|
self.extra_args = [[
|
|
"-acceptnonstdtxn=1",
|
|
"-maxmempool=5",
|
|
"-spendzeroconfchange=0",
|
|
]]
|
|
self.supports_cli = False
|
|
|
|
def skip_test_if_missing_module(self):
|
|
self.skip_if_no_wallet()
|
|
|
|
def run_test(self):
|
|
txouts = gen_return_txouts()
|
|
relayfee = self.nodes[0].getnetworkinfo()['relayfee']
|
|
|
|
self.log.info('Check that mempoolminfee is minrelytxfee')
|
|
assert_equal(self.nodes[0].getmempoolinfo()['minrelaytxfee'], Decimal('0.00001000'))
|
|
assert_equal(self.nodes[0].getmempoolinfo()['mempoolminfee'], Decimal('0.00001000'))
|
|
|
|
txids = []
|
|
utxos = create_confirmed_utxos(relayfee, self.nodes[0], 491)
|
|
|
|
self.log.info('Create a mempool tx that will be evicted')
|
|
us0 = utxos.pop()
|
|
inputs = [{ "txid" : us0["txid"], "vout" : us0["vout"]}]
|
|
outputs = {self.nodes[0].getnewaddress() : 0.0001}
|
|
tx = self.nodes[0].createrawtransaction(inputs, outputs)
|
|
self.nodes[0].settxfee(relayfee) # specifically fund this tx with low fee
|
|
txF = self.nodes[0].fundrawtransaction(tx)
|
|
self.nodes[0].settxfee(0) # return to automatic fee selection
|
|
txFS = self.nodes[0].signrawtransactionwithwallet(txF['hex'])
|
|
txid = self.nodes[0].sendrawtransaction(txFS['hex'])
|
|
|
|
relayfee = self.nodes[0].getnetworkinfo()['relayfee']
|
|
base_fee = relayfee*100
|
|
for i in range (3):
|
|
txids.append([])
|
|
txids[i] = create_lots_of_big_transactions(self.nodes[0], txouts, utxos[30*i:30*i+30], 30, (i+1)*base_fee)
|
|
|
|
self.log.info('The tx should be evicted by now')
|
|
assert txid not in self.nodes[0].getrawmempool()
|
|
txdata = self.nodes[0].gettransaction(txid)
|
|
assert txdata['confirmations'] == 0 #confirmation should still be 0
|
|
|
|
self.log.info('Check that mempoolminfee is larger than minrelytxfee')
|
|
assert_equal(self.nodes[0].getmempoolinfo()['minrelaytxfee'], Decimal('0.00001000'))
|
|
assert_greater_than(self.nodes[0].getmempoolinfo()['mempoolminfee'], Decimal('0.00001000'))
|
|
|
|
self.log.info('Create a mempool tx that will not pass mempoolminfee')
|
|
us0 = utxos.pop()
|
|
inputs = [{ "txid" : us0["txid"], "vout" : us0["vout"]}]
|
|
outputs = {self.nodes[0].getnewaddress() : 0.0001}
|
|
tx = self.nodes[0].createrawtransaction(inputs, outputs)
|
|
# specifically fund this tx with a fee < mempoolminfee, >= than minrelaytxfee
|
|
txF = self.nodes[0].fundrawtransaction(tx, {'feeRate': relayfee})
|
|
txFS = self.nodes[0].signrawtransactionwithwallet(txF['hex'])
|
|
assert_raises_rpc_error(-26, "mempool min fee not met", self.nodes[0].sendrawtransaction, txFS['hex'])
|
|
|
|
if __name__ == '__main__':
|
|
MempoolLimitTest().main()
|