fanquake f670118cce Merge bitcoin/bitcoin#28851: build: Patch Qt to handle minimum macOS version properly ... 05aca093819be276ac7d648472c6ed5c7d235cc5 build: Patch Qt to handle minimum macOS version properly (Hennadii Stepanov) Pull request description: This PR is: - required to [switch](https://github.com/bitcoin/bitcoin/pull/28622) to macOS 14 SDK (Xcode 15). - an alternative to https://github.com/bitcoin/bitcoin/pull/28732 and https://github.com/bitcoin/bitcoin/pull/28775. Qt relies on the `__MAC_OS_X_VERSION_MIN_REQUIRED` macro, which is set in the `AvailabilityInternal.h` SDK header to the value provided by the Clang driver from the `-mmacos-version-min` / `-mmacosx-version-min` option. Xcode 12 SDK expects the OS-specific `__ENVIRONMENT_MAC_OS_X_VERSION_MIN_REQUIRED__` macro: ```c++ #ifndef __MAC_OS_X_VERSION_MIN_REQUIRED #ifdef __ENVIRONMENT_MAC_OS_X_VERSION_MIN_REQUIRED__ /* compiler for Mac OS X sets __ENVIRONMENT_MAC_OS_X_VERSION_MIN_REQUIRED__ */ #define __MAC_OS_X_VERSION_MIN_REQUIRED __ENVIRONMENT_MAC_OS_X_VERSION_MIN_REQUIRED__ #endif #endif /* __MAC_OS_X_VERSION_MIN_REQUIRED*/ ``` In the other hand, Xcode 15 SDK expects a general `__ENVIRONMENT_OS_VERSION_MIN_REQUIRED__` macro: ```c++ #ifndef __MAC_OS_X_VERSION_MIN_REQUIRED #if defined(__has_builtin) && __has_builtin(__is_target_os) #if __is_target_os(macos) #define __MAC_OS_X_VERSION_MIN_REQUIRED __ENVIRONMENT_OS_VERSION_MIN_REQUIRED__ #define __MAC_OS_X_VERSION_MAX_ALLOWED __MAC_14_0 #endif #elif __ENVIRONMENT_MAC_OS_X_VERSION_MIN_REQUIRED__ #define __MAC_OS_X_VERSION_MIN_REQUIRED __ENVIRONMENT_MAC_OS_X_VERSION_MIN_REQUIRED__ #define __MAC_OS_X_VERSION_MAX_ALLOWED __MAC_14_0 #endif /* __has_builtin(__is_target_os) && __is_target_os(macos) */ #endif /* __MAC_OS_X_VERSION_MIN_REQUIRED */ ``` The latter macro is not provided by LLVM Clang until c8e2dd8c6f, which is available in Clang 17. The suggested patch makes Qt "borrow" the `__MAC_OS_X_VERSION_MIN_REQUIRED` value from `MAC_OS_X_VERSION_MIN_REQUIRED`, which is set in the `AvailabilityMacros.h` SDK header. ACKs for top commit: maflcko: lgtm ACK 05aca093819be276ac7d648472c6ed5c7d235cc5 Tree-SHA512: 8891aefde4b8a48885abf0648f4ec71a22f7fcfca1e17ebb8c70ce1ef44751ea5db6b8b652de6ee8a716ca5f96f720fef01600bc23986162d0146c946e2e8743		2024-10-24 13:50:33 -05:00
..
bdb
boost	partial bitcoin#28622: use macOS 14 SDK (Xcode 15.0)	2024-08-13 22:53:52 +07:00
fontconfig	partial Merge #20842: docs: consolidate typo & url fixing	2024-07-26 13:32:54 +07:00
libevent	Merge bitcoin/bitcoin#30488: depends: Fix CMake-generated libevent*.pc files	2024-09-27 12:52:15 -05:00
libxcb	Merge bitcoin/bitcoin#25738: depends: use a patch instead of sed in libxcb	2024-06-08 20:59:36 -05:00
miniupnpc
native_libdmg-hfsplus
qrencode	Merge bitcoin/bitcoin#29725: depends: build libqrencode with CMake	2024-09-29 10:54:41 +03:00
qt	Merge bitcoin/bitcoin#28851: build: Patch Qt to handle minimum macOS version properly	2024-10-24 13:50:33 -05:00
systemtap	merge bitcoin#26945: systemtap 4.8	2024-09-04 18:46:14 +00:00
zeromq	Merge bitcoin/bitcoin#30508: depends: Fix CMake-generated libzmq.pc file	2024-09-27 12:52:15 -05:00