mirror of
https://github.com/dashpay/dash.git
synced 2024-12-27 13:03:17 +01:00
ae488ba3da
d84e78e[wallet] Specify wallet name in wallet loading errors (John Newbery)a6da027Reject invalid wallet files (João Barbosa)3ef77a0Reject duplicate wallet filenames (João Barbosa) Pull request description: This PR prevents loading the same wallet more than once in a multi wallet scenario. It also prevents loading with invalid files: non regular files or symlinks. Tree-SHA512: 45bf814096bb788db1c76ff334e679a10686cee7d9c8cd48fe5d924031353ace271f6fb0d4af49a34246d336945515c176920a552be7b9fbe07ab8e00e5f6e5e
79 lines
3.1 KiB
Python
Executable File
79 lines
3.1 KiB
Python
Executable File
#!/usr/bin/env python3
|
|
# Copyright (c) 2017 The Bitcoin Core developers
|
|
# Distributed under the MIT software license, see the accompanying
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
"""Test multiwallet.
|
|
|
|
Verify that a bitcoind node can load multiple wallet files
|
|
"""
|
|
import os
|
|
|
|
from test_framework.test_framework import BitcoinTestFramework
|
|
from test_framework.util import assert_equal, assert_raises_jsonrpc
|
|
|
|
class MultiWalletTest(BitcoinTestFramework):
|
|
|
|
def __init__(self):
|
|
super().__init__()
|
|
self.setup_clean_chain = True
|
|
self.num_nodes = 1
|
|
self.extra_args = [['-wallet=w1', '-wallet=w2', '-wallet=w3']]
|
|
|
|
def run_test(self):
|
|
self.stop_node(0)
|
|
|
|
# should not initialize if there are duplicate wallets
|
|
self.assert_start_raises_init_error(0, self.options.tmpdir, ['-wallet=w1', '-wallet=w1'], 'Error loading wallet w1. Duplicate -wallet filename specified.')
|
|
|
|
# should not initialize if wallet file is a directory
|
|
os.mkdir(os.path.join(self.options.tmpdir, 'node0', 'regtest', 'w11'))
|
|
self.assert_start_raises_init_error(0, self.options.tmpdir, ['-wallet=w11'], 'Error loading wallet w11. -wallet filename must be a regular file.')
|
|
|
|
# should not initialize if wallet file is a symlink
|
|
os.symlink(os.path.join(self.options.tmpdir, 'node0', 'regtest', 'w1'), os.path.join(self.options.tmpdir, 'node0', 'regtest', 'w12'))
|
|
self.assert_start_raises_init_error(0, self.options.tmpdir, ['-wallet=w12'], 'Error loading wallet w12. -wallet filename must be a regular file.')
|
|
|
|
self.nodes[0] = self.start_node(0, self.options.tmpdir, self.extra_args[0])
|
|
|
|
w1 = self.nodes[0] / "wallet/w1"
|
|
w1.generate(1)
|
|
|
|
# accessing invalid wallet fails
|
|
assert_raises_jsonrpc(-18, "Requested wallet does not exist or is not loaded", (self.nodes[0] / "wallet/bad").getwalletinfo)
|
|
|
|
# accessing wallet RPC without using wallet endpoint fails
|
|
assert_raises_jsonrpc(-19, "Wallet file not specified", self.nodes[0].getwalletinfo)
|
|
|
|
# check w1 wallet balance
|
|
w1_info = w1.getwalletinfo()
|
|
assert_equal(w1_info['immature_balance'], 500)
|
|
w1_name = w1_info['walletname']
|
|
assert_equal(w1_name, "w1")
|
|
|
|
# check w1 wallet balance
|
|
w2 = self.nodes[0] / "wallet/w2"
|
|
w2_info = w2.getwalletinfo()
|
|
assert_equal(w2_info['immature_balance'], 0)
|
|
w2_name = w2_info['walletname']
|
|
assert_equal(w2_name, "w2")
|
|
|
|
w3 = self.nodes[0] / "wallet/w3"
|
|
w3_name = w3.getwalletinfo()['walletname']
|
|
assert_equal(w3_name, "w3")
|
|
|
|
assert_equal({"w1", "w2", "w3"}, {w1_name, w2_name, w3_name})
|
|
|
|
w1.generate(101)
|
|
assert_equal(w1.getbalance(), 1000)
|
|
assert_equal(w2.getbalance(), 0)
|
|
assert_equal(w3.getbalance(), 0)
|
|
|
|
w1.sendtoaddress(w2.getnewaddress(), 1)
|
|
w1.sendtoaddress(w3.getnewaddress(), 2)
|
|
w1.generate(1)
|
|
assert_equal(w2.getbalance(), 1)
|
|
assert_equal(w3.getbalance(), 2)
|
|
|
|
if __name__ == '__main__':
|
|
MultiWalletTest().main()
|