mirror of
https://github.com/dashpay/dash.git
synced 2024-12-26 04:22:55 +01:00
f39fcd1402
fa82a1ed833fd749849fa19267207b63e338d84d lint: Mention NONFATAL_UNREACHABLE in lint-assertions.py (MacroFake)
Pull request description:
Follow up to commit b1c5991eebb916755be188f355ad36fe01a3f529. Also remove empty newline added in that commit.
ACKs for top commit:
fanquake:
ACK fa82a1ed833fd749849fa19267207b63e338d84d
Tree-SHA512: cf398eceb135672137183bfa19ee57a82553a3dbcbce74db954c6fcd79f9606092cc0d8217610fe6cd67b7ef2d4f01d90329f0f568516d9b14aa2cd0f0715478
53 lines
1.5 KiB
Python
Executable File
53 lines
1.5 KiB
Python
Executable File
#!/usr/bin/env python3
|
|
#
|
|
# Copyright (c) 2018-2022 The Bitcoin Core developers
|
|
# Distributed under the MIT software license, see the accompanying
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
#
|
|
# Check for assertions with obvious side effects.
|
|
|
|
import sys
|
|
import subprocess
|
|
|
|
|
|
def git_grep(params: [], error_msg: ""):
|
|
try:
|
|
output = subprocess.check_output(["git", "grep", *params], universal_newlines=True, encoding="utf8")
|
|
print(error_msg)
|
|
print(output)
|
|
return 1
|
|
except subprocess.CalledProcessError as ex1:
|
|
if ex1.returncode > 1:
|
|
raise ex1
|
|
return 0
|
|
|
|
|
|
def main():
|
|
# PRE31-C (SEI CERT C Coding Standard):
|
|
# "Assertions should not contain assignments, increment, or decrement operators."
|
|
exit_code = git_grep([
|
|
"-E",
|
|
r"[^_]assert\(.*(\+\+|\-\-|[^=!<>]=[^=!<>]).*\);",
|
|
"--",
|
|
"*.cpp",
|
|
"*.h",
|
|
], "Assertions should not have side effects:")
|
|
|
|
# Aborting the whole process is undesirable for RPC code. So nonfatal
|
|
# checks should be used over assert. See: src/util/check.h
|
|
# src/rpc/server.cpp is excluded from this check since it's mostly meta-code.
|
|
exit_code |= git_grep([
|
|
"-nE",
|
|
r"\<(A|a)ss(ume|ert) *\(.*\);",
|
|
"--",
|
|
"src/rpc/",
|
|
"src/wallet/rpc*",
|
|
":(exclude)src/rpc/server.cpp",
|
|
], "CHECK_NONFATAL(condition) or NONFATAL_UNREACHABLE should be used instead of assert for RPC code.")
|
|
|
|
sys.exit(exit_code)
|
|
|
|
|
|
if __name__ == "__main__":
|
|
main()
|