sikkienl/dash
1
0
Fork 0
mirror of https://github.com/dashpay/dash.git synced 2024-12-26 04:22:55 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity
d0288fba58
dash/test/util/data
History
Wladimir J. van der Laan cd490905be
Merge #10999: Fix amounts formatting in decoderawtransaction 
ce07638 doc: Add comment to use ValueFromAmount/AmountFromValue for JSON, not utilmoneystr (Wladimir J. van der Laan)
ec05c50 rpc: Use ValueFromAmount instead of FormatMoney in TxToUniv (Wladimir J. van der Laan)
46347ad rpc: Move ValueFromAmount to core_write (Wladimir J. van der Laan)
dac3782 doc: Correct AmountFromValue/ValueFromAmount names (Wladimir J. van der Laan)

Pull request description:

  With this, the amounts returned in `decoderawtransaction` will be padded to 8 digits like anywhere else in the API.

  This is accomplished by using `ValueFromAmount` in `TxToUniv`, instead of `FormatMoney` which it currently (mistakingly) uses. The `FormatMoney` function is only for debugging/logging use!

  To avoid dependency issues, `ValueFromAmount` is moved to `core_write.cpp`, where it also fits better. I don't move `AmountFromValue` to `core_read.cpp` at the same time, as this would have more impact due to the RPCError dependency there.

  (n.b.: large number of changed files is solely due to the util_tests JSONs needing update)

Tree-SHA512: 10fc2d27d33a77dbcb57aa7eccd4f53110c05d38eb7df6d40f10f14c08fad4274472e93af75aa59fe68ad0720fdf0930f0108124abef518e0dd162b3d2b2b292
2019-08-12 09:07:03 -05:00
..
bitcoin-util-test.json
blanktxv1.hex
blanktxv1.json
blanktxv2.hex
blanktxv2.json
tt-delin1-out.hex
tt-delin1-out.json Merge #10999: Fix amounts formatting in decoderawtransaction 2019-08-12 09:07:03 -05:00
tt-delout1-out.hex
tt-delout1-out.json Merge #10999: Fix amounts formatting in decoderawtransaction 2019-08-12 09:07:03 -05:00
tt-locktime317000-out.hex
tt-locktime317000-out.json Merge #10999: Fix amounts formatting in decoderawtransaction 2019-08-12 09:07:03 -05:00
tx394b54bb.hex
txcreate1.hex
txcreate1.json Merge #10999: Fix amounts formatting in decoderawtransaction 2019-08-12 09:07:03 -05:00
txcreate2.hex
txcreate2.json Merge #10999: Fix amounts formatting in decoderawtransaction 2019-08-12 09:07:03 -05:00
txcreatedata1.hex
txcreatedata1.json Merge #10999: Fix amounts formatting in decoderawtransaction 2019-08-12 09:07:03 -05:00
txcreatedata2.hex
txcreatedata2.json Merge #10999: Fix amounts formatting in decoderawtransaction 2019-08-12 09:07:03 -05:00
txcreatedata_seq0.hex
txcreatedata_seq0.json Merge #10999: Fix amounts formatting in decoderawtransaction 2019-08-12 09:07:03 -05:00
txcreatedata_seq1.hex
txcreatedata_seq1.json Merge #10999: Fix amounts formatting in decoderawtransaction 2019-08-12 09:07:03 -05:00
txcreatemultisig1.hex
txcreatemultisig1.json Merge #10999: Fix amounts formatting in decoderawtransaction 2019-08-12 09:07:03 -05:00
txcreatemultisig2.hex
txcreatemultisig2.json Merge #10999: Fix amounts formatting in decoderawtransaction 2019-08-12 09:07:03 -05:00
txcreateoutpubkey1.hex
txcreateoutpubkey1.json Merge #10999: Fix amounts formatting in decoderawtransaction 2019-08-12 09:07:03 -05:00
txcreatescript1.hex
txcreatescript1.json Merge #10999: Fix amounts formatting in decoderawtransaction 2019-08-12 09:07:03 -05:00
txcreatescript2.hex
txcreatescript2.json Merge #10999: Fix amounts formatting in decoderawtransaction 2019-08-12 09:07:03 -05:00
txcreatesignv1.hex
txcreatesignv1.json Merge #10999: Fix amounts formatting in decoderawtransaction 2019-08-12 09:07:03 -05:00
txcreatesignv2.hex