mirror of
https://github.com/dashpay/dash.git
synced 2024-12-26 12:32:48 +01:00
6dbc9aba0d
5ac804a9eb0cdbdcff8b50ecfb736f8793cab805 tests: Use a default of supports_cli=True (instead of supports_cli=False) (practicalswift)
993e38a4e2fa66093314b988dfbe459f46aa5864 tests: Mark functional tests not supporting bitcoin-cli (--usecli) as such (practicalswift)
Pull request description:
Annotate functional tests supporting `bitcoin-cli` (`--usecli`) as such.
Prior to this commit 74 tests were unnecessarily skipped when running `test_runner.py --usecli`.
Before [bitcoin original commit stats]:
```
$ test/functional/test_runner.py --usecli > /dev/null 2>&1
$ echo $?
0
$ test/functional/test_runner.py --usecli 2>&1 | cut -f2 -d'|' | \
grep -E ' (Passed|Skipped) *$' | sort | uniq -c
9 ✓ Passed
126 ○ Skipped
```
After [dash numbers]:
```
$ test/functional/test_runner.py --usecli > /dev/null 2>&1
$ echo $?
0
$ test/functional/test_runner.py --usecli 2>&1 | cut -f2 -d'|' | \
grep -E ' (Passed|Skipped) *$' | sort | uniq -c
110 ✓ Passed
51 ○ Skipped
```
Context: `--usecli` was introduced in f6ade9ce1a
ACKs for top commit:
laanwj:
Code review ACK 5ac804a9eb0cdbdcff8b50ecfb736f8793cab805
Tree-SHA512: 249c0b691a74cf201c729df86c3db2b3faefa53b94703941e566943d252c6d14924e935a8da4f592951574235923fbb7cd22612a5e7e02ff6c762c55a2320ca3
80 lines
3.3 KiB
Python
Executable File
80 lines
3.3 KiB
Python
Executable File
#!/usr/bin/env python3
|
|
# Copyright (c) 2014-2016 The Bitcoin Core developers
|
|
# Distributed under the MIT software license, see the accompanying
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
"""Test longpolling with getblocktemplate."""
|
|
|
|
from decimal import Decimal
|
|
|
|
from test_framework.test_framework import BitcoinTestFramework
|
|
from test_framework.util import get_rpc_proxy, random_transaction, wait_until
|
|
|
|
import threading
|
|
|
|
class LongpollThread(threading.Thread):
|
|
def __init__(self, node):
|
|
threading.Thread.__init__(self)
|
|
# query current longpollid
|
|
template = node.getblocktemplate()
|
|
self.longpollid = template['longpollid']
|
|
# create a new connection to the node, we can't use the same
|
|
# connection from two threads
|
|
self.node = get_rpc_proxy(node.url, 1, timeout=600, coveragedir=node.coverage_dir)
|
|
|
|
def run(self):
|
|
self.node.getblocktemplate({'longpollid':self.longpollid})
|
|
|
|
class GetBlockTemplateLPTest(BitcoinTestFramework):
|
|
def set_test_params(self):
|
|
self.num_nodes = 2
|
|
self.supports_cli = False
|
|
|
|
def skip_test_if_missing_module(self):
|
|
self.skip_if_no_wallet()
|
|
|
|
def run_test(self):
|
|
self.log.info("Warning: this test will take about 70 seconds in the best case. Be patient.")
|
|
self.nodes[0].generate(10)
|
|
template = self.nodes[0].getblocktemplate()
|
|
longpollid = template['longpollid']
|
|
# longpollid should not change between successive invocations if nothing else happens
|
|
template2 = self.nodes[0].getblocktemplate()
|
|
assert template2['longpollid'] == longpollid
|
|
|
|
# Test 1: test that the longpolling wait if we do nothing
|
|
thr = LongpollThread(self.nodes[0])
|
|
thr.start()
|
|
# check that thread still lives
|
|
thr.join(5) # wait 5 seconds or until thread exits
|
|
assert thr.is_alive()
|
|
|
|
# Test 2: test that longpoll will terminate if another node generates a block
|
|
self.nodes[1].generate(1) # generate a block on another node
|
|
# check that thread will exit now that new transaction entered mempool
|
|
thr.join(5) # wait 5 seconds or until thread exits
|
|
assert not thr.is_alive()
|
|
|
|
# Test 3: test that longpoll will terminate if we generate a block ourselves
|
|
thr = LongpollThread(self.nodes[0])
|
|
thr.start()
|
|
self.nodes[0].generate(1) # generate a block on another node
|
|
thr.join(5) # wait 5 seconds or until thread exits
|
|
assert not thr.is_alive()
|
|
|
|
# Test 4: test that introducing a new transaction into the mempool will terminate the longpoll
|
|
thr = LongpollThread(self.nodes[0])
|
|
thr.start()
|
|
# generate a random transaction and submit it
|
|
min_relay_fee = self.nodes[0].getnetworkinfo()["relayfee"]
|
|
# min_relay_fee is fee per 1000 bytes, which should be more than enough.
|
|
(txid, txhex, fee) = random_transaction(self.nodes, Decimal("1.1"), min_relay_fee, Decimal("0.001"), 20)
|
|
# after one minute, every 10 seconds the mempool is probed, so in 80 seconds it should have returned
|
|
|
|
def check():
|
|
self.bump_mocktime(1)
|
|
return not thr.is_alive()
|
|
wait_until(check, timeout=60 + 20, sleep=1)
|
|
|
|
if __name__ == '__main__':
|
|
GetBlockTemplateLPTest().main()
|