MarcoFalke d03d75fba8 Merge #16898: test: Remove connect_nodes_bi ... fadfd844de8c53034a97dfa6f771ffe9f523fba2 test: Remove unused connect_nodes_bi (MarcoFalke) fa3b9ee8b2280af4bcbcfffff275aaf8dd125929 scripted-diff: test: Replace connect_nodes_bi with connect_nodes (MarcoFalke) faaee1e39a91b3f603881655d3980c29af09852b test: Use connect_nodes when connecting nodes in the test_framework (MarcoFalke) 1111bb91f517838e5b9f778bf6b5a9c8d561e857 test: Reformat python imports to aid scripted diff (MarcoFalke) Pull request description: By default all test nodes are connected in a chain. However, instead of just a single connection between each pair of nodes, we end up with up to four connections for a "middle" node (two outbound, two inbound, from each side). This is generally redundant (tx and block relay should succeed with just a single connection) and confusing. For example, test timeouts after a call to `sync_` may be racy and hard to reproduce. On top of that, the test `debug.log`s are hard to read because txs and block invs may be relayed on the same connection multiple times. Fix this by inlining `connect_nodes_bi` in the two tests that need it, and then replace it with a single `connect_nodes` in all other tests. Historic background: `connect_nodes_bi` has been introduced as a (temporary?) workaround for bug #5113 and #5138, which has long been fixed in #5157 and #5662. ACKs for top commit: laanwj: ACK fadfd844de8c53034a97dfa6f771ffe9f523fba2 jonasschnelli: utACK fadfd844de8c53034a97dfa6f771ffe9f523fba2 - more of less a cleanup PR. promag: Tested ACK fadfd844de8c53034a97dfa6f771ffe9f523fba2, ran extended tests. Tree-SHA512: 2d027a8fd150749c071b64438a0a78ec922178628a7dbb89fd1212b0fa34febd451798c940101155d3617c0426c2c4865174147709894f1f1bb6cfa336aa7e24		2021-12-15 20:09:59 +05:30
..
__init__.py
address.py	Merge #14324: qa: Run more tests with wallet disabled	2021-09-24 18:48:44 -04:00
authproxy.py	Merge #18596: test: Try once more when RPC connection fails on Windows	2021-09-28 14:46:44 -04:00
bignum.py
blocktools.py	Merge #16363: test: Add test for BIP30 duplicate tx	2021-11-30 00:01:38 -05:00
coverage.py
descriptors.py	merge bitcoin#15368: Descriptor checksums	2021-10-28 14:01:02 +05:30
key.py	Merge #15826: Pure python EC	2021-11-14 20:57:40 +05:30
messages.py	merge bitcoin#16850: servicesnames field in getpeerinfo and getnetworkinfo	2021-12-12 18:57:02 +05:30
mininode.py	Merge #15897: QA/mininode: Send all headers upfront in send_blocks_and_test to avoid sending an unconnected one	2021-11-21 07:13:16 +05:30
netutil.py	merge #14954: Require python 3.5	2021-08-31 11:16:12 +05:30
script.py	merge #14954: Require python 3.5	2021-08-31 11:16:12 +05:30
siphash.py
socks5.py	merge #14954: Require python 3.5	2021-08-31 11:16:12 +05:30
test_framework.py	Merge #16898: test: Remove connect_nodes_bi	2021-12-15 20:09:59 +05:30
test_node.py	Merge #16804: test: Remove unused try-block in assert_debug_log	2021-11-25 06:38:16 +05:30
util.py	Merge #16898: test: Remove connect_nodes_bi	2021-12-15 20:09:59 +05:30