dash/src
MarcoFalke d0a4198166
Merge #21598: refactor: Remove negative lock annotations from globals
fa5eabe72117f6e3704858e8d5b2c57a120258ed refactor: Remove negative lock annotations from globals (MarcoFalke)

Pull request description:

  They only make sense for mutexes that are private members. Until cs_main is a private member the negative annotations should be replaced by excluded annotations, which are optional.

ACKs for top commit:
  sipa:
    utACK fa5eabe72117f6e3704858e8d5b2c57a120258ed
  ajtowns:
    ACK fa5eabe72117f6e3704858e8d5b2c57a120258ed
  hebasto:
    ACK fa5eabe72117f6e3704858e8d5b2c57a120258ed
  vasild:
    ACK fa5eabe72117f6e3704858e8d5b2c57a120258ed

Tree-SHA512: 06f8a200304f81533010efcc42d9f59b8c4d0ae355920c0a28efb6fa161a3e3e68f2dfffb0c009afd9c2501e6a293c6e5a419a64d718f1f4e79668ab2ab1fcdc
2024-10-12 20:06:28 +07:00
..
bench Merge #6312: chore: Update copyrights and copyright_header.py script 2024-10-07 15:29:29 -05:00
bls chore: run contrib/devtools/copyright_header.py update . 2024-10-05 23:17:41 +03:00
coinjoin fix: add multiple missing annotation about locks for dash specific code 2024-10-12 20:06:23 +07:00
compat
config
consensus merge bitcoin#23173: Add ChainstateManager::ProcessTransaction 2024-10-05 17:10:02 +00:00
crc32c
crypto refactor: segregate x11 hashing 2024-10-04 14:57:07 -05:00
dashbls build: stop tracking cmake dependency relic_conf.h.in 2024-10-09 17:26:10 +03:00
evo fix: add multiple missing annotation about locks for dash specific code 2024-10-12 20:06:23 +07:00
governance fix: add multiple missing annotation about locks for dash specific code 2024-10-12 20:06:23 +07:00
gsl fix: optimize includes in gsl/pointer.h to speed up compile time 2024-08-26 16:16:31 +07:00
immer
index Merge #21598: refactor: Remove negative lock annotations from globals 2024-10-12 20:06:28 +07:00
init Merge bitcoin/bitcoin#22216: refactor: Make SetupServerArgs callable without NodeContext 2024-08-28 01:09:45 +07:00
interfaces Merge #6250: backport: Merge bitcoin#22217, 23025, 22362 2024-09-27 00:32:20 +07:00
ipc
leveldb
llmq fix: add ignoring safety-annotation for llmq/signing_shares due to template lambdas 2024-10-12 20:06:27 +07:00
logging merge bitcoin#22872: improve checkaddrman logging with duration in milliseconds 2024-09-03 14:57:48 +00:00
masternode fix: add multiple missing annotation about locks for dash specific code 2024-10-12 20:06:23 +07:00
node merge bitcoin#23630: Remove GetSpendHeight 2024-10-08 15:59:17 +00:00
policy Merge #20305: wallet: introduce fee_rate sat/vB param/option 2024-09-23 02:13:14 +07:00
primitives refactor: segregate x11 hashing 2024-10-04 14:57:07 -05:00
qt chore: run contrib/devtools/copyright_header.py update . 2024-10-05 23:17:41 +03:00
rpc fix: add multiple missing annotation about locks for dash specific code 2024-10-12 20:06:23 +07:00
script Merge #6240: backport: partial bitcoin#27920, #28799, #29007 - to improve CI experience 2024-08-30 10:32:20 -05:00
secp256k1
stats Merge #6312: chore: Update copyrights and copyright_header.py script 2024-10-07 15:29:29 -05:00
support merge bitcoin#25325: Add pool based memory resource 2024-09-04 16:29:30 +00:00
test Merge #6297: backport: merge bitcoin#23156, #23213, #23227, #23223, #23564, #23538, #23437, #23630, #23465, #23738, #17631, #22875 (auxiliary backports: part 18) 2024-10-08 17:28:25 -05:00
univalue Merge bitcoin/bitcoin#30464: test, refactor: Fix MSVC warning C4101 "unreferenced local variable" 2024-09-27 12:52:15 -05:00
util partial Merge #29040: refactor: Remove pre-C++20 code, fs::path cleanup 2024-10-12 20:02:06 +07:00
wallet Merge #21598: refactor: Remove negative lock annotations from globals 2024-10-12 20:06:28 +07:00
zmq merge bitcoin#26261: cleanup LookupIntern, Lookup and LookupHost 2024-09-11 18:34:06 +00:00
.clang-format
addrdb.cpp merge bitcoin#26847: track AddrMan totals by network and table, improve precision of adding fixed seeds 2024-09-11 16:18:46 +00:00
addrdb.h merge bitcoin#22910: Encapsulate asmap in NetGroupManager 2024-09-03 14:57:50 +00:00
addressindex.cpp chore: run contrib/devtools/copyright_header.py update . 2024-10-05 23:17:41 +03:00
addressindex.h chore: run contrib/devtools/copyright_header.py update . 2024-10-05 23:17:41 +03:00
addrman_impl.h merge bitcoin#27745: select addresses by network follow-up 2024-09-11 18:34:07 +00:00
addrman.cpp merge bitcoin#28341: Use HashWriter over legacy CHashWriter 2024-09-11 18:34:07 +00:00
addrman.h merge bitcoin#27015: bitcoin#26847 fixups (AddrMan totals) 2024-09-13 16:57:54 +00:00
amount.h
arith_uint256.cpp
arith_uint256.h
attributes.h
banman.cpp
banman.h
base58.cpp
base58.h
batchedlogger.cpp
batchedlogger.h
bech32.cpp Merge bitcoin/bitcoin#22579: doc: Add references for the generator/constant used in Bech32(m) 2024-10-04 14:59:02 +05:30
bech32.h
bip324.cpp merge bitcoin#28433: Follow-up to BIP324 connection support 2024-09-20 12:24:22 +00:00
bip324.h merge bitcoin#28433: Follow-up to BIP324 connection support 2024-09-20 12:24:22 +00:00
bitcoin-cli.cpp chore: run contrib/devtools/copyright_header.py update . 2024-10-05 23:17:41 +03:00
bitcoin-tx.cpp Merge bitcoin/bitcoin#24139: Avoid unsigned integer overflow in bitcoin-tx 2024-09-12 20:24:08 +05:30
bitcoin-wallet.cpp
bitcoind.cpp Merge bitcoin/bitcoin#22216: refactor: Make SetupServerArgs callable without NodeContext 2024-08-28 01:09:45 +07:00
blockencodings.cpp
blockencodings.h
blockfilter.cpp
blockfilter.h
bloom.cpp
bloom.h
cachemap.h
cachemultimap.h
chain.cpp merge bitcoin#25349: CBlockIndex/CDiskBlockIndex improvements for safety, consistent behavior 2024-08-23 06:57:37 +00:00
chain.h merge bitcoin#23769: Disallow copies of CChain 2024-09-08 16:24:36 +00:00
chainparams.cpp feat: quick assemble of devnets 2024-10-03 19:42:19 +07:00
chainparams.h
chainparamsbase.cpp feat: bury fork mn_rr (masternode reward reallocation) 2024-09-30 12:56:26 +07:00
chainparamsbase.h
chainparamsseeds.h
checkqueue.h
clientversion.cpp
clientversion.h
coins.cpp merge bitcoin#22902: utxocache tracepoints 2024-09-04 18:46:13 +00:00
coins.h merge bitcoin#25325: Add pool based memory resource 2024-09-04 16:29:30 +00:00
compat.h
compressor.cpp
compressor.h
context.h chore: run contrib/devtools/copyright_header.py update . 2024-10-05 23:17:41 +03:00
core_io.h
core_memusage.h
core_read.cpp merge bitcoin#22875: Fix Racy ParseOpCode function initialization 2024-10-08 15:59:18 +00:00
core_write.cpp
ctpl_stl.h
cuckoocache.h
cxxtimer.hpp
dash-cli-res.rc Merge bitcoin/bitcoin#22724: windres: use PACKAGE_VERSION rather than building more version numbers 2024-09-27 15:35:12 -05:00
dash-tx-res.rc Merge bitcoin/bitcoin#22724: windres: use PACKAGE_VERSION rather than building more version numbers 2024-09-27 15:35:12 -05:00
dash-wallet-res.rc Merge bitcoin/bitcoin#22724: windres: use PACKAGE_VERSION rather than building more version numbers 2024-09-27 15:35:12 -05:00
dashd-res.rc Merge bitcoin/bitcoin#22724: windres: use PACKAGE_VERSION rather than building more version numbers 2024-09-27 15:35:12 -05:00
dbwrapper.cpp
dbwrapper.h
deploymentinfo.cpp feat: bury fork mn_rr (masternode reward reallocation) 2024-09-30 12:56:26 +07:00
deploymentinfo.h
deploymentstatus.cpp
deploymentstatus.h
dsnotificationinterface.cpp refactor: make pdsNotificationInterface a unique_ptr, rename 2024-09-13 13:06:22 +00:00
dsnotificationinterface.h refactor: make pdsNotificationInterface a unique_ptr, rename 2024-09-13 13:06:22 +00:00
dummywallet.cpp
flat-database.h Merge #6318: refactor: remove circular dependency governance/object over governance/classes 2024-10-08 17:12:24 -05:00
flatfile.cpp
flatfile.h
fs.cpp
fs.h Merge #6213: backport: trivial 2024 08 14 2024-08-21 09:00:07 -05:00
hash_x11.h fmt: run clang-format on hash_x11.h 2024-10-04 15:35:45 -05:00
hash.cpp
hash.h Merge #6312: chore: Update copyrights and copyright_header.py script 2024-10-07 15:29:29 -05:00
httprpc.cpp merge bitcoin#25619: avoid overriding non-virtual ToString() in CService and use better naming 2024-09-11 16:18:46 +00:00
httprpc.h
httpserver.cpp merge bitcoin#26261: cleanup LookupIntern, Lookup and LookupHost 2024-09-11 18:34:06 +00:00
httpserver.h
i2p.cpp merge bitcoin#25619: avoid overriding non-virtual ToString() in CService and use better naming 2024-09-11 16:18:46 +00:00
i2p.h
indirectmap.h
init.cpp Merge #6318: refactor: remove circular dependency governance/object over governance/classes 2024-10-08 17:12:24 -05:00
init.h Merge bitcoin/bitcoin#22216: refactor: Make SetupServerArgs callable without NodeContext 2024-08-28 01:09:45 +07:00
key_io.cpp
key_io.h
key.cpp
key.h
limitedmap.h
logging.cpp
logging.h
Makefile.am Merge #6303: refactor: segregate x11 hashing 2024-10-07 14:43:27 -05:00
Makefile.bench.include merge bitcoin#25325: Add pool based memory resource 2024-09-04 16:29:30 +00:00
Makefile.crc32c.include
Makefile.leveldb.include
Makefile.qt_locale.include
Makefile.qt.include Merge bitcoin-core/gui#313: qt: Optimize string concatenation by default 2024-09-24 21:38:43 +07:00
Makefile.qttest.include
Makefile.test_fuzz.include
Makefile.test_util.include merge bitcoin#25325: Add pool based memory resource 2024-09-04 16:29:30 +00:00
Makefile.test.include merge bitcoin#23185: Add ParseMoney and ParseScript tests 2024-10-05 17:10:02 +00:00
Makefile.univalue.include
mapport.cpp merge bitcoin#26261: cleanup LookupIntern, Lookup and LookupHost 2024-09-11 18:34:06 +00:00
mapport.h
memusage.h merge bitcoin#25325: Add pool based memory resource 2024-09-04 16:29:30 +00:00
merkleblock.cpp
merkleblock.h
messagesigner.cpp
messagesigner.h
miner.cpp
miner.h partial merge bitcoin/bitcoin#27783: Add public Boost headers explicitly 2024-10-07 15:14:10 -05:00
net_permissions.cpp merge bitcoin#26261: cleanup LookupIntern, Lookup and LookupHost 2024-09-11 18:34:06 +00:00
net_permissions.h
net_processing.cpp Merge #21598: refactor: Remove negative lock annotations from globals 2024-10-12 20:06:28 +07:00
net_processing.h refactor: new type of message processing result for resolving circular dependency over PeerManager 2024-10-03 16:30:45 +07:00
net_types.cpp Merge bitcoin/bitcoin#22362: Drop only invalid entries when reading banlist.json 2024-09-25 10:18:12 +05:30
net_types.h refactor: new type of message processing result for resolving circular dependency over PeerManager 2024-10-03 16:30:45 +07:00
net.cpp fix: drop unneded lock assert in net.cpp for m_nodes_mutex 2024-10-12 20:00:06 +07:00
net.h merge bitcoin#23636: Remove GetAdjustedTime from init.cpp 2024-10-05 17:10:03 +00:00
netaddress.cpp merge bitcoin#27411: Restrict self-advertisements with privacy networks to avoid fingerprinting 2024-09-13 17:04:45 +00:00
netaddress.h merge bitcoin#27411: Restrict self-advertisements with privacy networks to avoid fingerprinting 2024-09-13 17:04:45 +00:00
netbase.cpp merge bitcoin#26261: cleanup LookupIntern, Lookup and LookupHost 2024-09-11 18:34:06 +00:00
netbase.h merge bitcoin#26261: cleanup LookupIntern, Lookup and LookupHost 2024-09-11 18:34:06 +00:00
netfulfilledman.cpp chore: run contrib/devtools/copyright_header.py update . 2024-10-05 23:17:41 +03:00
netfulfilledman.h chore: run contrib/devtools/copyright_header.py update . 2024-10-05 23:17:41 +03:00
netgroup.cpp merge bitcoin#28341: Use HashWriter over legacy CHashWriter 2024-09-11 18:34:07 +00:00
netgroup.h merge bitcoin#22910: Encapsulate asmap in NetGroupManager 2024-09-03 14:57:50 +00:00
netmessagemaker.h fix: release unused memory in CNetMsgMaker::Make() 2024-08-27 20:45:36 +03:00
noui.cpp
noui.h
outputtype.cpp
outputtype.h
pow.cpp
pow.h
prevector.h
protocol.cpp feat: broadcast dsq messages using the inventory system 2024-09-10 09:23:22 -05:00
protocol.h docs: explain meaning of MessageProcessingResult's members 2024-10-05 02:23:56 +07:00
psbt.cpp
psbt.h
pubkey.cpp merge bitcoin#28196: BIP324 connection support 2024-09-20 12:24:22 +00:00
pubkey.h merge bitcoin#28196: BIP324 connection support 2024-09-20 12:24:22 +00:00
random.cpp merge bitcoin#24238: use arc4random on OpenBSD 2024-09-08 16:24:37 +00:00
random.h stats: clean up randomization code, move FastRandomContext inward 2024-09-11 14:34:19 +00:00
randomenv.cpp Merge bitcoin/bitcoin#30491: Fix MSVC warning C4273 "inconsistent dll linkage" 2024-10-03 01:16:40 -05:00
randomenv.h
rest.cpp merge bitcoin#17631: Expose block filters over REST 2024-10-08 15:59:18 +00:00
reverse_iterator.h
saltedhasher.cpp
saltedhasher.h
scheduler.cpp
scheduler.h
serialize.h
shutdown.cpp
shutdown.h
source_location.h
span.h
spentindex.h chore: run contrib/devtools/copyright_header.py update . 2024-10-05 23:17:41 +03:00
spork.cpp chore: run contrib/devtools/copyright_header.py update . 2024-10-05 23:17:41 +03:00
spork.h chore: run contrib/devtools/copyright_header.py update . 2024-10-05 23:17:41 +03:00
stacktraces.cpp chore: run contrib/devtools/copyright_header.py update . 2024-10-05 23:17:41 +03:00
stacktraces.h
streams.h
sync.cpp Merge #19668: Do not hide compile-time thread safety warnings 2024-10-12 20:06:28 +07:00
sync.h Merge #21598: refactor: Remove negative lock annotations from globals 2024-10-12 20:06:28 +07:00
threadinterrupt.cpp
threadinterrupt.h
threadsafety.h
timedata.cpp
timedata.h
timestampindex.h chore: run contrib/devtools/copyright_header.py update . 2024-10-05 23:17:41 +03:00
tinyformat.h
torcontrol.cpp merge bitcoin#23538: Remove strtol in torcontrol 2024-10-08 15:59:17 +00:00
torcontrol.h
txdb.cpp merge bitcoin#22626: Remove txindex migration code 2024-10-05 17:10:03 +00:00
txdb.h merge bitcoin#22626: Remove txindex migration code 2024-10-05 17:10:03 +00:00
txmempool.cpp fix: add multiple missing annotation about locks for dash specific code 2024-10-12 20:06:23 +07:00
txmempool.h partial merge bitcoin/bitcoin#27783: Add public Boost headers explicitly 2024-10-07 15:14:10 -05:00
txorphanage.cpp fix: fixes for orphange's locks and cs_main 2024-10-12 20:06:27 +07:00
txorphanage.h Merge #21598: refactor: Remove negative lock annotations from globals 2024-10-12 20:06:28 +07:00
uint256.cpp
uint256.h chore: run contrib/devtools/copyright_header.py update . 2024-10-05 23:17:41 +03:00
undo.h
unordered_lru_cache.h
validation.cpp fix: add missing lock annotation for ContextualCheckBlock and related TODO 2024-10-12 20:06:27 +07:00
validation.h merge bitcoin#23465: Remove CTxMemPool params from ATMP 2024-10-08 15:59:17 +00:00
validationinterface.cpp merge bitcoin#19572: Create "sequence" notifier, enabling client-side mempool tracking 2024-08-26 15:35:12 +00:00
validationinterface.h merge bitcoin#19572: Create "sequence" notifier, enabling client-side mempool tracking 2024-08-26 15:35:12 +00:00
version.h chore: run contrib/devtools/copyright_header.py update . 2024-10-05 23:17:41 +03:00
versionbits.cpp
versionbits.h
walletinitinterface.h
warnings.cpp
warnings.h