Wladimir J. van der Laan d4bc451492 Merge #15584: build: disable BIP70 support by default ... BIP70 is removed in "merge #17165: Remove BIP70 support (#4023)". So, this commit contains only some follow-ups to unify codebase e09913f1c47e693b0c6fafef55b9ca78e5f3abc0 doc: specify protobuf as optional in build docs (fanquake) 376f4929f8f75011b72b2f9c3164980db482278a build: disable BIP70 support by default (fanquake) Pull request description: Disable BIP70 support in the GUI by default for `0.19.0` (for eventual removal in `0.20.0`?). Users who want to compile with BIP70 support enabled can pass `--enable-bip70` to `./configure`. I've inverted the current `--disable-bip70` test to instead pass `--enable-bip70`. Tested configurations on `macOS` (`protobuf` installed with `brew`). Protobuf available and `./configure`: ``` Options used to compile and link: with wallet = yes with gui / qt = yes with bip70 = no ``` Protobuf available and `./configure --enable-bip70`: ``` Options used to compile and link: with wallet = yes with gui / qt = yes with bip70 = yes ``` Protobuf not available (i.e `brew unlink protobuf`) and `./configure`: ``` Options used to compile and link: with wallet = yes with gui / qt = yes with bip70 = no ``` Protobuf not available and `./configure --enable-bip70`: ``` checking whether to build test_bitcoin-qt... yes checking whether to build BIP70 support... configure: error: protobuf missing ``` TODO: - [x] Remove `protobuf` from other Travis builds - [ ] Documentation updates (mention that `protobuf` is now optional)? - [ ] Could split release notes into GUI and build ACKs for top commit: laanwj: ACK e09913f1c47e693b0c6fafef55b9ca78e5f3abc0 elichai: ACK e09913f1c47e693b0c6fafef55b9ca78e5f3abc0 Read the autotools changes. awesome that this removes the protobuf requirement. practicalswift: ACK e09913f1c47e693b0c6fafef55b9ca78e5f3abc0 -- diff looks correct Tree-SHA512: 7bf87ae8555e24db2da2e89cc4d4e90d09be27499ad386ad65879d05df8f96d9a1384379891ac8963d17728c90e55961560813df97e849e631e2de8c08e210c8		2023-04-25 23:41:20 -05:00
..
00_setup_env_arm.sh	ci: reconcile differences between ci setups	2022-07-01 09:04:01 +05:30
00_setup_env_i686_ubsan.sh	ci: reconcile differences between ci setups	2022-07-01 09:04:01 +05:30
00_setup_env_i686.sh	ci: reconcile differences between ci setups	2022-07-01 09:04:01 +05:30
00_setup_env_mac_host.sh	Merge #15584: build: disable BIP70 support by default	2023-04-25 23:41:20 -05:00
00_setup_env_mac.sh	partial Merge bitcoin/bitcoin#19817: build: macOS toolchain bump	2023-03-26 16:50:26 -05:00
00_setup_env_native_centos.sh	Merge #17635: ci: Add CentOS 7 build	2022-08-30 09:08:16 -05:00
00_setup_env_native_cxx20.sh	Merge #15584: build: disable BIP70 support by default	2023-04-25 23:41:20 -05:00
00_setup_env_native_fuzz_with_valgrind.sh	Merge #18901: fuzz: use std::optional for sep_pos_opt variable	2023-01-23 11:21:05 -06:00
00_setup_env_native_fuzz.sh	Merge #18901: fuzz: use std::optional for sep_pos_opt variable	2023-01-23 11:21:05 -06:00
00_setup_env_native_nowallet.sh	ci: reconcile differences between ci setups	2022-07-01 09:04:01 +05:30
00_setup_env_native_qt5.sh	ci: align TEST_RUNNER_EXTRA with INTEGRATION_TESTS_ARGS	2022-07-01 09:04:01 +05:30
00_setup_env_native_sqlite.sh	ci: add sqlite-only linux64 test build	2023-02-17 14:21:19 -06:00
00_setup_env_native_tsan.sh	Merge #14092: tests: Dry run bench_bitcoin as part "make check" to allow for quick identification of assertion/sanitizer failures in benchmarking code	2023-04-06 20:14:58 +03:00
00_setup_env_s390x.sh	Merge #17661: ci: use depends for s390x	2023-04-25 23:14:25 +03:00
00_setup_env_win64.sh	ci: reconcile differences between ci setups	2022-07-01 09:04:01 +05:30
00_setup_env.sh	Merge #17549: ci: misc cleanups	2023-04-25 23:14:25 +03:00
03_before_install.sh
04_install.sh	Merge #17549: ci: misc cleanups	2023-04-25 23:14:25 +03:00
05_before_script.sh	Merge #17549: ci: misc cleanups	2023-04-25 23:14:25 +03:00